Jerome Velociter wrote:
11 +1
I'll move the new WYSIWYG into the platform tomorrow morning.
Regarding the integration, I forgot one important detail that may cause some problems: the GWT version. A few weeks ago I switched from 1.4.61 to 1.5-rc1. The latest version is now 1.5-rc2 and I believe they will soon provide a final 1.5 version (AFAIK, there's no publicly available roadmap). Some of the reasons that made me move to GWT 1.5 are:
* Java 1.5 goodies (use of generics instead of @gwt.typeArgs annotations) * Improved API (Element#getInnerHTML() instead of DOM#getInnerHTML(Element)) * Curiosity
Right now, platform-web-gwt depends on GWT 1.4.61. It seems to work on 1.5 since the new WYSIWYG depends on it and on GWT 1.5. So, what are the options?
* Move platform-web-gwt to GWT 1.5 (but may cause problems in other projects like Watch and Curriki)
AFAIK Curriki is currently on core/XE 1.4 branch,
AFAIK Curriki is on its way to being moved to 1.5.
as well as watch trunk (which could upgrade to 1.5 branch for its 1.1 release I think, or better upgrade to core/XE 1.6 + GWT 1.5); so upgrading XE trunk to GWT 1.5-rc-2
Most probable 1.6, but I didn't do it yet because I didn't need it.
should not be an issue IMO, there's just the uncertainty that 1.5 final release of GWT being out by the time we are ready for XE 1.6 final...
Jerome.
* Use maven magic to obtain a special XE distribution which will include the new WYSIWYG and will depend on GWT 1.5 (but we won't have the new WYSIWYG in the default distribution) * Degrade the WYSIWYG to GWT 1.4 (but it will make me unhappy) * Something else? Create the 1.7 GWT1.5ish branch for xwiki-web-gwt and depend on that in your experimental XE? That might be just equivalent to first option, though...
So WDYT? Marius
Hi devs,
I propose to move the new WYSIWYG editor into the platform in order to have it as an experimental feature for 1.6M1.
The following steps should be taken: * Create a platform/web/wysiwyg module to host the code currently resided in sandbox/wysiwyg * Change templates/edit.vm, templates/editpanels.vm and create templates/editwysiwygnew.vm to make XE aware of the new editor. This way our users will be able to experiment the new WYSIWYG editor on any page, by having editor=wysiwygnew in the edit URL. * Change platform/web/pom/xml and enterprise/web/pom.xml
Here's my +1 Marius
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs