Re: [xwiki-devs] [xwiki-notifications] r9090 - in xwiki-platform/core/trunk/xwiki-core/src: main/java/com/xpn/xwiki/plugin/packaging test/java/com/xpn/xwiki/plugin/packaging

Vincent Massol wrote:

Hi Anca,

cool for the tests :)

if you don't mind, some comments: * Why name the test ImportTest when the practice is to name it PackageTest and that class already exists? * There are lots of duplications with PackageTest * The test setup sounds very (too) complex * Missing spaces after comment //something vs // Something (note the uppercase to start a sentence :)) * several typos ;)

I guess every first patch and every first commit must be followed by a mail/comment like this... Nobody was spared so far, IIRC :) . -- Sergiu Dumitriu http://purl.org/net/sergiu/