On Tue, Apr 6, 2010 at 17:03, Vincent Massol <[email protected]> wrote:
Hi Milind,
On Apr 6, 2010, at 5:00 PM, Milind Kamble wrote:
Denis, I understand your point that XE being used globally, needs to support more than Ascii char set. While the new reference model matures, could you clarify if underscore in a file name would break the functionality under the current model where attachment name is used as a reference for attachments? If not, would it be possible to eliminate the stripping of just the underscore chars and push that fix in the next XE release -- I am OK with space chars getting stripped off.
I don't think that underscores are a problem even with the old "reference as string" code. Actually I don't even know why we're stripping them. Sergiu might know more. Any idea Sergiu?
I am not saying that it will not work for "_", my feeling is mainly that "_" is just a small part of the issue and that we need to fix it as a whole. The story about why we clean attachment names is in XWIKI-94 ( http://jira.xwiki.org/jira/browse/XWIKI-94), so it is quite old. I have not checked if recent changes has mitigate this or not. Denis -- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO