2015-02-18 15:25 GMT+01:00 [email protected] <[email protected]>:
On 18 Feb 2015 at 15:08:21, Guillaume Louis-Marie Delhumeau ( [email protected](mailto:[email protected])) wrote:
[snip]
This is the solution I will put in place internally in order to have valid HTML5 in XWiki 6.4, but this discussion still remains for 7.x.
Has this been done already for 6.4? I don’t remember seeing it.
Hello.
No, I did not have time to do it earlier and it seems we do not have a clear agreement on this.
Thanks,
Don’t know if it’s related to this email thread, but it would be great if we/you could fix the broken HTML validation tests ( http://ci.xwiki.org/job/xwiki-enterprise-test-webstandards/ - they’ve been failing on our CI for months now). Including WCAG tests. So it’s very likely that we have regressed in WCAG and in conformity in our HTML code… :(
I don’t think it’s important if in the meantime we/you hardcode the syntax id to use based on the skin name in those validation tests. Actually this is probably not even needed since we support only 1 skin (Flamingo). [BTW we need to remove support for Colibri in 7.x, possibly sooner than later to ensure we can stabilize before the end of 7.x].
The problem is not to hardcode the syntax in the validation tests. The problem is to set, in XWiki, the rendering syntax that we want to use. Currently, it's XHTML 1.0 hard-coded in a lot of places. That is why I have done this proposal.
What’s important is that the validity tests get fixed ASAP and we can go back to normal.
Thanks -Vincent
Note that AFAIK skins don’t need to have a parent nowadays (and by default new skins don’t have parents).
Thanks -Vincent
[snip]
What I plan to do: - add a property in the Skin Class about the rendering syntax to use - add the same property for the skin located in the filesystem (skin.properties) - add an API that returns the current rendering syntax (depending on the skin) - add a Script Service that generates the doctype string to display in htmlheaders.vm so that we cannot have a sync problem. Thanks, -- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project