Hi Marius,
On 19 Aug 2017, at 13:19, Marius Dumitru Florea <[email protected]> wrote:
On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
We have several pages requiring PR and we’re not doing much about them.
This is a major pain, for example on myxwiki.org where, every time some admin update their wikis they break features. It’s not showing XWiki in good light neither.
I’ve found at least those pages requiring PR:
* XWiki.AllAttachmentsResults
Doesn't require PR anymore.
Ok that’s cool. When was it done? Is it on LTS? I see it’s still there on playground which is on XWiki 8.4.4.
* XWiki.DeletedDocumentsJSON * AppWithinMinutes.DynamicMessageTool
This is deprecated and not used. I was kept only for backwards compatibility. See https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwik...
This is not what I saw on the subwiki (started working after I resaved that page). It was still used there and the wiki is on XWiki 9.3.1. Thanks -Vincent
.
* AnnotationCode.Style * XWiki.DeletedDocuments * AppWithinMinutes.LiveTableEditSheet * AppWithinMinutes.ClassEditSheet * XWiki.DeletedAttachments * Main.Activity * AnnotationCode.Script
(see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId= 83579&page=com.atlassian.jira.plugin.system.issuetabpanels: comment-tabpanel#comment-83579 )
And FTR we keep adding more over time. For example in 2012, AWM introduced a PR: https://github.com/xwiki/xwiki-platform/commit/ ae09194f83b9fe1f75778e0a2501a6cc37c4b060
I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. in 2 weeks.
WDYT?
Thanks -Vincent