Hi, Lilianne E. Blaze a écrit :
Concerning the code, the main remark I have would be to put it in the com.xpn.xwiki.web.includeservlet package, since it is not specific to Velocity but adds a feature to the XWiki API.
Are you sure? The code is not dependent on Velocity, but it is a solution to Velocity-specific problem? Without Velocity a standard RequestDispatcher would completely suffice.
Yes it would.. but for Groovy or plugins it is also necessary.. It's just the way XWiki handles the content that makes it necessary, so it's not specific to velocity.. It is specific to XWiki though..
Finally, it would be great if you could add a TestCase which demonstrates the features and verifies that it works fine. You will probably need to add the test to ViewEditTest which means it involves a TomCat local install to make it run.
Is it necessary? Honestly, I'm not a big fan of high or medium -level TestCases, and I'm just not sure how to write it to fit it in existing XWiki test code.
Well since this calls the RequestDispatcher unless you fake a XWikiRequest object (which is possible) you will need a high level test case.. If you are having difficulties we'll have Jeremi look at it..
You haven't said anything about the second patch ("A small patch for XWiki.getAuthService and XWiki.getRightService (easier debugging mostly)")?
I've answered this one separately.. Sorry for missing it. Ludovic -- Ludovic Dubost XPertNet: http://www.xpertnet.fr/ Blog: http://www.ludovic.org/blog/ XWiki: http://www.xwiki.com Skype: ldubost AIM: nvludo Yahoo: ludovic