So far: - sergiu: +1 for internal - thomas: +1 for internal - marius: +1 for internal - vincent: +1 for internal but not as strongly as the others above ;) Ok so I've added it to our best practices here: http://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle Thanks -Vincent On Aug 22, 2008, at 11:05 PM, Vincent Massol wrote:
Hi,
We need to decide if we want our component implementations (the class implementing the interface of a component) to be user-public or not.
By user-public I mean allowing user of the code to use them (for composition, for inheritance). The alternative is to make them internal and forbid users to import them. This means moving them to an internal package (see http://www.eclipse.org/articles/ article.php?file=Article-API-Use/index.html) and telling our users that they change anytime so they shouldn't use them. This would also mean we wouldn't have to go through a deprecation stage to make any change to our components.
My initial reaction to this was that they should be public but the more I think about it the more I think making them internal might be the best choice.
WDYT?
Thanks -Vincent