Hi, ok I've checked more precisely what were the APIs that are broken and
for which we could want to maintain backward compat (I have not listed internal implementation classes):
1) xwiki-bridge: - DocumentAccesssBridge - DocumentModelBridge - DocumentNameFactory - DocumentNameSerializer
2) xwiki-core: - XWikiDocument (for getDocumentName())
3) xwiki-openoffice: - XDOMOfficeDocumentBuilder - XHTMLOfficeDocumentBuilder - TargetPageDescriptor - XDOMOfficeDocumentSplitter
4) xwiki-macro-wikibridge - WikiMacroManager - WikiMacroFactory
5) xwiki-url - XWikiAttachmentURL - XWikiDocumentURL
So here's what I propose: - We keep backward compat for 1) and 2)
- We don't keep backward compat for 4) (I doubt it's used by anyone
else and the backward compat has already been broken for that module a week ago) and for 5) (it's not used yet) - I'm hesitating for 3). We could keep backward compat to make it easier for some projects. Thus I'm slighty in favor of keeping backward compat for it.
- We use aspects whenever we want to keep backward compat
- We need a new method name in DocumentModelBridge to add in addition of getCurrentDocumentName(). I don't have a good idea: getDocumentName2(), getNewDocumentName(), getDocumentNameModel(), getDocumentNameFromModel(), etc. Any idea?
WDYT?
+1 - Asiri