On Sat, Jan 23, 2010 at 2:59 AM, Sergiu Dumitriu <[email protected]> wrote:
On 01/22/2010 11:47 PM, Caleb James DeLisle wrote:
Flavius Olaru wrote:
Hi devs, Hi Caleb
Why not create a LiveValidation Application before adding it to the
core?
There is an application here: http://incubator.myxwiki.org/xwiki/bin/view/XWiki/LiveValidation The idea of a template (registerinline.vm) calling an application seems backward to me.
I second Caleb, this is a functionality used by other applications and even platform elements, so it should also be in the platform.
I am not against adding a javascript library that is required by the platform or other applications, the fact that this library had a missing transparent bugs/issues management raised some questions.
Also there are some leftovers in resources like YUI at an obsolete version... It was my mistake proposing it go in the yui folder, It doesn't depend on yui so it should be in it's own folder.
I prefer something like resources/uicomponents/widgets/validation/
What about "resources/uicomponents/widgets/livevalidation/" ?
and one more thing, i found nothing about their(LiveValidation) bugs management. You make a very good point. I think it's also important to note that the code is under 900 lines fully documented, it contains 1200 lines of unit tests, it will only be used on pages which call it via jsfx.use and it is not intended for security as nefarious users may simply turn off javascript.
We have other small "tools" that don't have a community and advanced stuff like version control, tracker and mailing lists. IMO, this is normal, and acceptable. Such a tool usually has less than 1k likes of code, so there's not much to maintain. If there are bugs or compatibility issues, a mail to the author with either a bugfix request or a patch should be enough.
But yes, the bug management question is a very good one, and one we usually consider for larger libraries/tools.
I took the time and tested it on Windows with their tests page. Firefox 3.5, MSIE 6, 7, 8, Google Chrome and Safari: All tests passed... a good thing. :) Opera 10: 51 tests, 184 assertions, 45 failures, 0 errors (I've submitted them the tests results) http://livevalidation.com/testprototype Maybe if someone has the time to check it on Mac and Linux and post here if the findings would be great. I also found a fork on github, it has some few more lines than the original library and is versioned as 1.4 as opposed the original at 1.3. Maybe when i get the time i will have a better look on that. http://github.com/grockit/livevalidation -- Flavius Olaru