On Jan 3, 2009, at 7:58 PM, Asiri Rathnayake wrote: [snip]
the params don't seem to be used?
The DefaultHTMLCleaner doesn't use the parameters. It's the OpenOfficeHTMLCleaner that will use the params. We discussed this on the chat, if we have a different HTMLCleaner interface only for Office Importer module we don't need to change the xwiki-xml HTMLCleaner interface. But OpenOfficeHTMLCleaner implements HTMLCleaner interface from xwiki- xml This is why we decided to change HTMLCleaner interface. The cleaning parameters are dependant on the implementation classes. I mean, cleaning parameters for DefaultHTMLCleaner (if there going to be any) will not apply for OpenOfficeHTMLCleaner.
I hope there has been no misunderstanding.
This is fine but it needs to be documented in the method with the parameter signature to explain why the params are not used. Thanks -Vincent http://xwiki.com http://massol.net http://xwiki.org