Vincent Massol <[email protected]> writes:
Hi JV,
Are you sure about this patch?
It looks like it's adding a synchronize() that was not there before and thus all threads will be waiting on this synchronize. Since checkHibernate is called for all database access I'm worried this could lead to performance issues.
Has this been tested for performance with a tool like JMeter to simulate multiple users?
Note that I haven't analyzed the patch. I'm just worried that we might be introducing a regression in term of performance.
If the session factory is only created once then maybe it should be created on app init?
Thanks -Vincent
It has been tested with siege (50 users at the same time), profiled with yourkit, and is now on xwiki.org which seems to be faster than before ;) -- Raffaello Pelagalli XPertNet - XWiki.com