Re: [xwiki-devs] [Proposal] Make all click methods be named click*() in UI functional tests

On Fri, Jun 24, 2011 at 15:45, Marius Dumitru Florea <[email protected]> wrote:

-0, the fact that you have to click on a button/link in order to login is an implementation detail IMO. The page object (ViewPage) should hide this. It may be fine for "click", but I wouldn't like to change the name of a page object method (an API) whenever the underlying user interface/interaction changes.

I don't agree with you, it's an implementation details when the purpose of the test is not to validate login UI but the proposal here is not about TestUtils.

Thanks, Marius

On 06/24/2011 10:51 AM, Vincent Massol wrote:

...

Hi,

The proposal is to make all click methods be named click*() in UI functional tests.

For example in ViewPage, instead of:

     public LoginPage login()      {          this.loginLink.click();          return new LoginPage();      }

We would have:

     public LoginPage clickLogin()      {          this.loginLink.click();          return new LoginPage();      }

Right now we have some methods starting with click and other not following this pattern, the idea is to homogeneize it.

WDYT?

Thanks -Vincent

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

---

devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne