For me it's 3. whenever it makes sense (for example the JS/css code of the RMUI should go in the admin app), and 5 when it does not (+ packing different IC together when it makes sense, too). Jerome. Sergiu Dumitriu wrote:
Jean-Vincent Drean wrote:
On Tue, Dec 16, 2008 at 4:36 AM, Sergiu Dumitriu <[email protected]> wrote:
Hi devs,
While working on a UI feature that makes use of skin extensions (both script and style), I was faced with a difficult choice: where to put these extensions?
So, the choices are:
1. Stick to the past and put the code in Albatross, registering it in platform-web/javascript.vm and stylesheet.vm. 2. Put the files as resource skin extensions inside xwiki-core. 3. Force the documents into an existing application, for example administration or enterprise-wiki. 4. Create a new application for holding Interface Components. 5. Create a new application for each IC.
Currently, my preference is +1 for 5, with a +0 for 4 and -1 for the rest. Here's some of my motivations:
I'll make the same votes : +1 for 5, with a +0 for 4 and -1 for the rest. Since you're worried by the number of JIRA projects implied by 5) I'd be curious to see a list of let's say 10 ICs you have in mind. May be we could bundle ICs that are related in single modules.
Almost all UI elements of the current skin will have to be moved into IC. For example:
- Keyboard shortcuts - The bottom tabs behavior (comments, attachments, history, information) - Uploading multiple attachments (like in GMail) - AJAX suggest - A future rich XClass editor - Lightbox - AJAX form validation - Form Tooltips - FullScreen edit - Rights management - Jump to any page - Easy parent setting
Putting these in skins is wrong, since they are not reusable, and they are not specific to only one skin.