Ludovic, you are right. searchDocumentNames should not return anything else than document names. Then we could completely ignore the selectColumns parameter in this function, since it is not used. This will have no impact on the code. I'll write a private function that treats the selectColumns parameter as specified, and if we will ever find it useful, we can make it public and link it to an API. On 1/2/07, Vincent Massol <[email protected]> wrote:
I don't have an opinion on this yet. I'll follow what you guys says is best.
-Vincent
*From:* Sergiu Dumitriu [mailto:[email protected]] *Sent:* dimanche 31 décembre 2006 02:35 *To:* [email protected] *Subject:* [xwiki-dev] [vote] Missing searchDocumentsNames functionality
com.xpn.xwiki.store.XWikiHibernateStore.searchDocumentsNames supports a selectColumns parameter which is supposed to specify which columns should be selected.
This parameter is used when building the select string, but the columns are not included in the returned list, so this parameter just makes a bigger select string and increases the execution time.
In order to include the specified columns in the result, I propose this: - if selectedColumns is the empty string, keep the previous behavior (return a list of document names) - if selectedColumns is not empty, then return a list of hashmaps, with the column name as the key, with a special name for the document name (for example docname)
-- You receive this message as a subscriber of the [email protected] list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws