Re: [xwiki-devs] [VOTE] REST API Changes not passing CLIRR. Ignore errors

8 Aug 2012

      Hi,

Could the dev team answer this one. It would be great to be able to
apply the pull request
for the REST API improvements along with the one Fabio just sent:

https://github.com/xwiki/xwiki-platform/pull/56

I've taken into account the comments sent out.

Ludovic

2012/7/27 Ludovic Dubost <[email protected]>:
...
As part of rest improvements to display pretty names of users and
other improvements, I'm getting CLIRR errors because of API changes of
the model and of public class:
1/ Model CLIRR error because the version field has been moved to
PageSummary from Page. Page extends PageSummary. I need the version
field also in representations sending back only PageSummaries.
Unfortunately CLIRR does not realize that the version field is still
there when moved to the super class. I believe it's safe to ignore
this error. Howerver I've put ignore all errors on the Page class as I
don't have a way to ignore this specific error
2/ CLIRR errors because of parameter additions to objects that are
used (I think) only internally by the REST server API. Here are the
errors:
[ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public
org.xwiki.rest.model.jaxb.Attachment
createAttachment(org.xwiki.rest.model.jaxb.ObjectFactory,
java.net.URI, com.xpn.xwiki.api.Attachment, java.lang.String,
java.lang.String)' the number of arguments has changed
[ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public
org.xwiki.rest.model.jaxb.Attachment
createAttachmentAtVersion(org.xwiki.rest.model.jaxb.ObjectFactory,
java.net.URI, com.xpn.xwiki.api.Attachment, java.lang.String,
java.lang.String)' the number of arguments has changed
[ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public
org.xwiki.rest.model.jaxb.Comment
createComment(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI,
com.xpn.xwiki.api.Document, com.xpn.xwiki.api.Object)' the number of
arguments has changed
[ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public
org.xwiki.rest.model.jaxb.HistorySummary
createHistorySummary(org.xwiki.rest.model.jaxb.ObjectFactory,
java.net.URI, java.lang.String, java.lang.String, java.lang.String,
java.lang.String, org.suigeneris.jrcs.rcs.Version, java.lang.String,
java.util.Date)' the number of arguments has changed
[ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public
org.xwiki.rest.model.jaxb.Object
createObject(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI,
com.xpn.xwiki.XWikiContext, com.xpn.xwiki.api.Document,
com.xpn.xwiki.objects.BaseObject, boolean)' the number of arguments
has changed
[ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public
org.xwiki.rest.model.jaxb.ObjectSummary
createObjectSummary(org.xwiki.rest.model.jaxb.ObjectFactory,
java.net.URI, com.xpn.xwiki.XWikiContext, com.xpn.xwiki.api.Document,
com.xpn.xwiki.objects.BaseObject, boolean)' the number of arguments
has changed
[ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public
org.xwiki.rest.model.jaxb.Page
createPage(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI,
java.net.URI, com.xpn.xwiki.api.Document, boolean,
com.xpn.xwiki.api.XWiki)' the number of arguments has changed
[ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public
org.xwiki.rest.model.jaxb.PageSummary
createPageSummary(org.xwiki.rest.model.jaxb.ObjectFactory,
java.net.URI, com.xpn.xwiki.api.Document, com.xpn.xwiki.api.XWiki)'
the number of arguments has changed
[ERROR] org.xwiki.rest.resources.BaseAttachmentsResource: In method
'public org.xwiki.rest.model.jaxb.Attachments
getAttachments(java.lang.String, java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer, java.lang.Integer)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.BaseAttachmentsResource: In method
'protected org.xwiki.rest.model.jaxb.Attachments
getAttachmentsForDocument(com.xpn.xwiki.api.Document, int, int)' the
number of arguments has changed
[ERROR] org.xwiki.rest.resources.BaseSearchResult: In method
'protected java.util.List search(java.util.List, java.lang.String,
java.lang.String, java.lang.String, boolean, int)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.BaseSearchResult: In method
'protected java.util.List searchObjects(java.lang.String,
java.lang.String, java.lang.String, boolean, int)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.BaseSearchResult: In method
'protected java.util.List searchPages(java.util.List,
java.lang.String, java.lang.String, java.lang.String, boolean, int)'
the number of arguments has changed
[ERROR] org.xwiki.rest.resources.BaseSearchResult: In method
'protected java.util.List searchSpaces(java.lang.String,
java.lang.String, boolean, int)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.ModificationsResource: In method
'public org.xwiki.rest.model.jaxb.History
getModifications(java.lang.String, java.lang.Integer,
java.lang.Integer, java.lang.String, java.lang.Long)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.attachments.AttachmentsAtPageVersionResource:
In method 'public org.xwiki.rest.model.jaxb.Attachments
getAttachmentsAtPageVersion(java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.Integer,
java.lang.Integer)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.attachments.AttachmentsResource: In
method 'public org.xwiki.rest.model.jaxb.Attachments
getAttachments(java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer, java.lang.Integer)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.comments.CommentResource: In method
'public org.xwiki.rest.model.jaxb.Comment getComment(java.lang.String,
java.lang.String, java.lang.String, java.lang.Integer,
java.lang.Integer, java.lang.Integer)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.comments.CommentVersionResource: In
method 'public org.xwiki.rest.model.jaxb.Comment
getCommentVersion(java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.Integer,
java.lang.Integer, java.lang.Integer)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.comments.CommentsResource: In method
'public org.xwiki.rest.model.jaxb.Comments
getComments(java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer, java.lang.Integer)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.comments.CommentsVersionResource: In
method 'public org.xwiki.rest.model.jaxb.Comments
getCommentsVersion(java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.Integer,
java.lang.Integer)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.objects.AllObjectsForClassNameResource:
In method 'public org.xwiki.rest.model.jaxb.Objects
getObjects(java.lang.String, java.lang.String, java.lang.Integer,
java.lang.Integer)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.objects.ObjectAtPageVersionResource:
In method 'public org.xwiki.rest.model.jaxb.Object
getObject(java.lang.String, java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.Integer)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.objects.ObjectPropertiesAtPageVersionResource:
In method 'public org.xwiki.rest.model.jaxb.Properties
getObjectProperties(java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.objects.ObjectPropertiesResource: In
method 'public org.xwiki.rest.model.jaxb.Properties
getObjectProperties(java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.Integer)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.objects.ObjectPropertyAtPageVersionResource:
In method 'public org.xwiki.rest.model.jaxb.Property
getObjectProperty(java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer, java.lang.String)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.objects.ObjectPropertyResource: In
method 'public org.xwiki.rest.model.jaxb.Property
getObjectProperty(java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.Integer,
java.lang.String)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.objects.ObjectResource: In method
'public org.xwiki.rest.model.jaxb.Object getObject(java.lang.String,
java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.objects.ObjectsAtPageVersionResource:
In method 'public org.xwiki.rest.model.jaxb.Objects
getObjects(java.lang.String, java.lang.String, java.lang.String,
java.lang.String, java.lang.Integer, java.lang.Integer)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.objects.ObjectsForClassNameResource:
In method 'public org.xwiki.rest.model.jaxb.Objects
getObjects(java.lang.String, java.lang.String, java.lang.String,
java.lang.String, java.lang.Integer, java.lang.Integer)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.objects.ObjectsResource: In method
'public org.xwiki.rest.model.jaxb.Objects getObjects(java.lang.String,
java.lang.String, java.lang.String, java.lang.Integer,
java.lang.Integer)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.pages.PageChildrenResource: In method
'public org.xwiki.rest.model.jaxb.Pages
getPageChildren(java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer, java.lang.Integer)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.pages.PageHistoryResource: In method
'public org.xwiki.rest.model.jaxb.History
getPageHistory(java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer, java.lang.Integer, java.lang.String)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.pages.PageResource: In method 'public
org.xwiki.rest.model.jaxb.Page getPage(java.lang.String,
java.lang.String, java.lang.String)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.pages.PageTranslationHistoryResource:
In method 'public org.xwiki.rest.model.jaxb.History
getPageTranslationHistory(java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.Integer,
java.lang.Integer, java.lang.String)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.pages.PageTranslationResource: In
method 'public org.xwiki.rest.model.jaxb.Page
getPageTranslation(java.lang.String, java.lang.String,
java.lang.String, java.lang.String)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.pages.PageTranslationVersionResource:
In method 'public org.xwiki.rest.model.jaxb.Page
getPageTranslationVersion(java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.String)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.pages.PageVersionResource: In method
'public org.xwiki.rest.model.jaxb.Page
getPageVersion(java.lang.String, java.lang.String, java.lang.String,
java.lang.String)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.pages.PagesResource: In method
'public org.xwiki.rest.model.jaxb.Pages getPages(java.lang.String,
java.lang.String, java.lang.Integer, java.lang.Integer,
java.lang.String)' the number of arguments has changed
[ERROR] org.xwiki.rest.resources.spaces.SpaceAttachmentsResource: In
method 'public org.xwiki.rest.model.jaxb.Attachments
getAttachments(java.lang.String, java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer, java.lang.Integer)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.spaces.SpaceSearchResource: In method
'public org.xwiki.rest.model.jaxb.SearchResults
search(java.lang.String, java.lang.String, java.lang.String,
java.util.List, java.lang.Integer)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.tags.PagesForTagsResource: In method
'public org.xwiki.rest.model.jaxb.Pages getTags(java.lang.String,
java.lang.String, java.lang.Integer, java.lang.Integer)' the number of
arguments has changed
[ERROR] org.xwiki.rest.resources.wikis.WikiAttachmentsResource: In
method 'public org.xwiki.rest.model.jaxb.Attachments
getAttachments(java.lang.String, java.lang.String, java.lang.String,
java.lang.String, java.lang.String, java.lang.String,
java.lang.Integer, java.lang.Integer)' the number of arguments has
changed
[ERROR] org.xwiki.rest.resources.wikis.WikiSearchResource: In method
'public org.xwiki.rest.model.jaxb.SearchResults
search(java.lang.String, java.lang.String, java.util.List,
java.lang.Integer)' the number of arguments has changed
Ludovic
--
Ludovic Dubost
Founder and CEO
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
-- 
Ludovic Dubost
Founder and CEO
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost