Re: [xwiki-devs] [xwiki-notifications] r27562 - in platform/core/trunk: xwiki-core/src/main/java/com/xpn/xwiki/internal xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge/src/main/java/org/xwiki/rendering/macro/wikibridge

Hi Vincent,

...

If you are referring to this specific new feature or integration tests, No there are none.

Yes that's my question, why are there none? We shouldn't apply or accept patches that don't have tests to prove they work (unless when it's about some old code modifications and writing tests is just too hard).

Could you add some tests to prove this new feature?

ParameterDescriptor interface have the method getDefaultValue() which returns an object. WikiMacroParameterDescriptor class used to return null and what anamaria has done is to make it return a user specified (via a new constructor) default value object. I do not think this needs any test. - Asiri