+0 Vincent Massol wrote:

Hi,

There's currently an API for: public String getURL(String fullname, String action, XWikiContext context)

it's passing null to the underlying call to the URL factory for query string and anchor.

I'm thus proposing to add the following API in XWiki.java: public String getURL(String fullname, String action, String queryString, String anchor, XWikiContext context)

In the future we'll need to rationalize all this of course. I need this because I'd like to remove the throws XWikiException in DocumentAccessBridge.getURL() since getting a URL for a document should never raise an exception.

Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

Vincent Massol wrote:

Hi,

There's currently an API for: public String getURL(String fullname, String action, XWikiContext context)

it's passing null to the underlying call to the URL factory for query string and anchor.

I'm thus proposing to add the following API in XWiki.java: public String getURL(String fullname, String action, String queryString, String anchor, XWikiContext context)

+1, since this is in accordance with the existing methods. Note that this is not an API, since XWiki is an internal class. Also note that there exists another method, getURL(fullname, action, querystring), so just the one with an anchor is missing.

In the future we'll need to rationalize all this of course. I need this because I'd like to remove the throws XWikiException in DocumentAccessBridge.getURL() since getting a URL for a document should never raise an exception.

+1. -- Sergiu Dumitriu http://purl.org/net/sergiu/