On Feb 16, 2009, at 8:52 AM, Vincent Massol wrote:

Hi devs,

I introduced these events initially in order to be able to have inline error reporting in a generic manner. However there are some problems: * it currently works only for macros, if you wrap other blocks with an error block you'll get to see the output of what is wrapped. * there's no block other than the MacroBlock that can raise an error so there's no need to have a generic way of reporting an inline error

Thus I propose the following (suggested by Marius):

1) We remove the begin/endError events 2) When macros fail to execute we output the exact same content

Actually, it would probably be best to output a Box Macro instead of an XMLNode (span). Thanks -Vincent

as is currently output by the begin/endError events but generated as the macro content. Since we have macro marker block around it, it'll work just fine.

Here's my +1

Vincent Massol wrote:

Hi devs,

I introduced these events initially in order to be able to have inline error reporting in a generic manner. However there are some problems: * it currently works only for macros, if you wrap other blocks with an error block you'll get to see the output of what is wrapped. * there's no block other than the MacroBlock that can raise an error so there's no need to have a generic way of reporting an inline error

Thus I propose the following (suggested by Marius):

1) We remove the begin/endError events 2) When macros fail to execute we output the exact same content as is currently output by the begin/endError events but generated as the macro content. Since we have macro marker block around it, it'll work just fine.

+1 The good part is that in WYSIWYG the user will be able to fix the problem by clicking on the "error" and then Edit Macro to change the parameters or content of that macro. Thanks, Marius

Here's my +1

Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

Vincent Massol wrote:

Hi devs,

I introduced these events initially in order to be able to have inline error reporting in a generic manner. However there are some problems: * it currently works only for macros, if you wrap other blocks with an error block you'll get to see the output of what is wrapped. * there's no block other than the MacroBlock that can raise an error so there's no need to have a generic way of reporting an inline error

Thus I propose the following (suggested by Marius):

1) We remove the begin/endError events 2) When macros fail to execute we output the exact same content as is currently output by the begin/endError events but generated as the macro content. Since we have macro marker block around it, it'll work just fine.

+0 -- Sergiu Dumitriu http://purl.org/net/sergiu/