Re: [xwiki-devs] [proposal] New xwiki-commons top-level module (was:XMLRPC)
On Wed, Apr 9, 2008 at 7:49 PM, Fabio Mancinelli <[email protected]> wrote:
Dear all,
I've sent a patch on the Jira for a first version of the new XMLRPC layer. (http://jira.xwiki.org/jira/browse/XWIKI-1560)
Let me know if there are issues.
Hi XWikiers, Fabio, I'm still working on your patch [1] in which you've written a replacement of the swizzle library we're currently using. This replacement is needed and has already been voted [2]. Even if the xwiki core will use it, this library is neither a part of it nor a new product so what do you think about creating a new top-level module : xwiki-commons. - xwiki-commons -- xwiki-commons/xmlrpc/ ? [1] : http://dev.xwiki.org/xwiki/bin/view/Community/Contributing#HCreatingandsubmi... for the next time :) [2] : http://xwiki.markmail.org/message/yx5q63i6h5jkoqo6?q=date:200804+list:org%2E... Thanks, -- Jean-Vincent Drean
On Apr 14, 2008, at 6:43 PM, Jean-Vincent Drean wrote:
On Wed, Apr 9, 2008 at 7:49 PM, Fabio Mancinelli <[email protected]> wrote:
Dear all,
I've sent a patch on the Jira for a first version of the new XMLRPC layer. (http://jira.xwiki.org/jira/browse/XWIKI-1560)
Let me know if there are issues.
Hi XWikiers, Fabio,
I'm still working on your patch [1] in which you've written a replacement of the swizzle library we're currently using. This replacement is needed and has already been voted [2]. Even if the xwiki core will use it, this library is neither a part of it nor a new product so what do you think about creating a new top-level module : xwiki-commons.
- xwiki-commons -- xwiki-commons/xmlrpc/
I don't understand where you're suggesting to put "xwiki-commons" and what it'll contain. Could you explain? Thanks -Vincent
?
[1] : http://dev.xwiki.org/xwiki/bin/view/Community/Contributing#HCreatingandsubmi... for the next time :) [2] : http://xwiki.markmail.org/message/yx5q63i6h5jkoqo6?q=date:200804+list:org%2E...
Thanks, -- Jean-Vincent Drean _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Mon, Apr 14, 2008 at 6:51 PM, Vincent Massol <[email protected]> wrote:
On Apr 14, 2008, at 6:43 PM, Jean-Vincent Drean wrote:
On Wed, Apr 9, 2008 at 7:49 PM, Fabio Mancinelli <[email protected]> wrote:
Dear all,
I've sent a patch on the Jira for a first version of the new XMLRPC layer. (http://jira.xwiki.org/jira/browse/XWIKI-1560)
Let me know if there are issues.
Hi XWikiers, Fabio,
I'm still working on your patch [1] in which you've written a replacement of the swizzle library we're currently using. This replacement is needed and has already been voted [2]. Even if the xwiki core will use it, this library is neither a part of it nor a new product so what do you think about creating a new top-level module : xwiki-commons.
- xwiki-commons -- xwiki-commons/xmlrpc/
I don't understand where you're suggesting to put "xwiki-commons" and what it'll contain. Could you explain?
By top-level I mean at the top of our source tree, next to xwiki-platform and xwiki-products. The only thing I propose to put in it (at least for the moment) is the swizzle replacement Fabio wrote, a standalone library containing both xwiki xmlrpc model and client code (like swizzle). Thanks, -- Jean-Vincent Drean
On Apr 15, 2008, at 11:07 AM, Jean-Vincent Drean wrote:
On Mon, Apr 14, 2008 at 6:51 PM, Vincent Massol <[email protected]> wrote:
On Apr 14, 2008, at 6:43 PM, Jean-Vincent Drean wrote:
On Wed, Apr 9, 2008 at 7:49 PM, Fabio Mancinelli <[email protected]> wrote:
Dear all,
I've sent a patch on the Jira for a first version of the new XMLRPC layer. (http://jira.xwiki.org/jira/browse/XWIKI-1560)
Let me know if there are issues.
Hi XWikiers, Fabio,
I'm still working on your patch [1] in which you've written a replacement of the swizzle library we're currently using. This replacement is needed and has already been voted [2]. Even if the xwiki core will use it, this library is neither a part of it nor a new product so what do you think about creating a new top-level module : xwiki-commons.
- xwiki-commons -- xwiki-commons/xmlrpc/
I don't understand where you're suggesting to put "xwiki-commons" and what it'll contain. Could you explain?
By top-level I mean at the top of our source tree, next to xwiki-platform and xwiki-products.
I don't agree then, -1 from me. This definitely looks like something that goes in the platform or I've missed something... I have no idea what it means to have a directory at the same level as platform and products. It would mean it's not platform related and it's not a product either.
The only thing I propose to put in it (at least for the moment) is the swizzle replacement Fabio wrote, a standalone library containing both xwiki xmlrpc model and client code (like swizzle).
I think I don't understand what you're proposing. More specifically why do you want to introduce a xwiki-commons directory? Why not create: xwiki-platform-core/xwiki-xmlrpc/ |_ xwiki-xmlrpc-model/ |_ xwiki-xmlrpc-client/ And then in the future when we move the server part it can go in xwiki- xmlrpc-server/? note: I assumed the model is used by both the client and the server Thanks -Vincent
On Tue, Apr 15, 2008 at 11:23 AM, Vincent Massol <[email protected]> wrote:
I don't agree then, -1 from me. This definitely looks like something that goes in the platform or I've missed something...
I have no idea what it means to have a directory at the same level as platform and products. It would mean it's not platform related and it's not a product either.
The only thing I propose to put in it (at least for the moment) is the swizzle replacement Fabio wrote, a standalone library containing both xwiki xmlrpc model and client code (like swizzle).
I think I don't understand what you're proposing.
More specifically why do you want to introduce a xwiki-commons directory?
In the first place I've put a xwiki-xmlrpc module into xwiki-platform-core (almost the same as your proposal bellow), what bothered me was to have a library at same level as components, without a clear differentiation.
Why not create:
xwiki-platform-core/xwiki-xmlrpc/ |_ xwiki-xmlrpc-model/ |_ xwiki-xmlrpc-client/
About splitting into model&client, we discussed that with Fabio and since the client is only one java class we agreed that it was a bit overkill to have a module for it. Wdyt ? Thanks, -- Jean-Vincent Drean
On Apr 15, 2008, at 11:51 AM, Jean-Vincent Drean wrote:
On Tue, Apr 15, 2008 at 11:23 AM, Vincent Massol <[email protected]> wrote:
I don't agree then, -1 from me. This definitely looks like something that goes in the platform or I've missed something...
I have no idea what it means to have a directory at the same level as platform and products. It would mean it's not platform related and it's not a product either.
The only thing I propose to put in it (at least for the moment) is the swizzle replacement Fabio wrote, a standalone library containing both xwiki xmlrpc model and client code (like swizzle).
I think I don't understand what you're proposing.
More specifically why do you want to introduce a xwiki-commons directory?
In the first place I've put a xwiki-xmlrpc module into xwiki-platform-core (almost the same as your proposal bellow), what bothered me was to have a library at same level as components, without a clear differentiation.
They're all core modules and all produce jars. I don't think it matters if the jar includes components or not.
Why not create:
xwiki-platform-core/xwiki-xmlrpc/ |_ xwiki-xmlrpc-model/ |_ xwiki-xmlrpc-client/
About splitting into model&client, we discussed that with Fabio and since the client is only one java class we agreed that it was a bit overkill to have a module for it. Wdyt ?
Sure that's fine with me to create a single module for now. Just not sure how to name it then. xwiki-xmlrpc-model? thanks -Vincent
On 15 avr. 08, at 12:01, Vincent Massol wrote:
Why not create:
xwiki-platform-core/xwiki-xmlrpc/ |_ xwiki-xmlrpc-model/ |_ xwiki-xmlrpc-client/
About splitting into model&client, we discussed that with Fabio and since the client is only one java class we agreed that it was a bit overkill to have a module for it. Wdyt ?
Sure that's fine with me to create a single module for now. Just not sure how to name it then. xwiki-xmlrpc-model?
Imho the name should clearly suggest to a potential user who wants to interact with xwiki via xmlrpc that this is the "thing" it should download/use. To me xwiki-xmlrpc-model doesn't seem to convey that idea too much. Simply "xwiki-xmlrpc" seems to be a better name to me, though having xwiki-platform-core/xwiki-xmlrpc/xwiki-xmlrpc is a bit weird/confusing. Or as Vincent suggested, having xwiki-xmlrpc-model and xwiki-xmlrpc- client is fine as well (even though xwiki-xmlrpc-client would be a module with only 1 class) and maybe it's the right solution to the dilemma :) My 2 cents. Cheers, Fabio
On Tue, Apr 15, 2008 at 2:17 PM, Fabio Mancinelli <[email protected]> wrote:
On 15 avr. 08, at 12:01, Vincent Massol wrote:
Why not create:
xwiki-platform-core/xwiki-xmlrpc/ |_ xwiki-xmlrpc-model/ |_ xwiki-xmlrpc-client/
About splitting into model&client, we discussed that with Fabio and since the client is only one java class we agreed that it was a bit overkill to have a module for it. Wdyt ?
Sure that's fine with me to create a single module for now. Just not sure how to name it then. xwiki-xmlrpc-model?
Imho the name should clearly suggest to a potential user who wants to interact with xwiki via xmlrpc that this is the "thing" it should download/use. To me xwiki-xmlrpc-model doesn't seem to convey that idea too much.
Simply "xwiki-xmlrpc" seems to be a better name to me, though having xwiki-platform-core/xwiki-xmlrpc/xwiki-xmlrpc is a bit weird/confusing.
Or as Vincent suggested, having xwiki-xmlrpc-model and xwiki-xmlrpc- client is fine as well (even though xwiki-xmlrpc-client would be a module with only 1 class) and maybe it's the right solution to the dilemma :)
My 2 cents.
+1 for xwiki-platform-core/xwiki-xmlrpc/xwiki-xmlrpc-model and xwiki-platform-core/xwiki-xmlrpc/xwiki-xmlrpc-client
Cheers, Fabio _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Apr 15, 2008, at 2:45 PM, Thomas Mortagne wrote:
On Tue, Apr 15, 2008 at 2:17 PM, Fabio Mancinelli <[email protected]> wrote:
On 15 avr. 08, at 12:01, Vincent Massol wrote:
Why not create:
xwiki-platform-core/xwiki-xmlrpc/ |_ xwiki-xmlrpc-model/ |_ xwiki-xmlrpc-client/
About splitting into model&client, we discussed that with Fabio and since the client is only one java class we agreed that it was a bit overkill to have a module for it. Wdyt ?
Sure that's fine with me to create a single module for now. Just not sure how to name it then. xwiki-xmlrpc-model?
Imho the name should clearly suggest to a potential user who wants to interact with xwiki via xmlrpc that this is the "thing" it should download/use. To me xwiki-xmlrpc-model doesn't seem to convey that idea too much.
Simply "xwiki-xmlrpc" seems to be a better name to me, though having xwiki-platform-core/xwiki-xmlrpc/xwiki-xmlrpc is a bit weird/ confusing.
Or as Vincent suggested, having xwiki-xmlrpc-model and xwiki-xmlrpc- client is fine as well (even though xwiki-xmlrpc-client would be a module with only 1 class) and maybe it's the right solution to the dilemma :)
My 2 cents.
+1 for xwiki-platform-core/xwiki-xmlrpc/xwiki-xmlrpc-model and xwiki-platform-core/xwiki-xmlrpc/xwiki-xmlrpc-client
+1 too -Vincent
Fabio Mancinelli wrote:
On 15 avr. 08, at 12:01, Vincent Massol wrote:
Why not create:
xwiki-platform-core/xwiki-xmlrpc/ |_ xwiki-xmlrpc-model/ |_ xwiki-xmlrpc-client/
About splitting into model&client, we discussed that with Fabio and since the client is only one java class we agreed that it was a bit overkill to have a module for it. Wdyt ? Sure that's fine with me to create a single module for now. Just not sure how to name it then. xwiki-xmlrpc-model?
Imho the name should clearly suggest to a potential user who wants to interact with xwiki via xmlrpc that this is the "thing" it should download/use. To me xwiki-xmlrpc-model doesn't seem to convey that idea too much.
Simply "xwiki-xmlrpc" seems to be a better name to me, though having xwiki-platform-core/xwiki-xmlrpc/xwiki-xmlrpc is a bit weird/confusing.
Or as Vincent suggested, having xwiki-xmlrpc-model and xwiki-xmlrpc- client is fine as well (even though xwiki-xmlrpc-client would be a module with only 1 class) and maybe it's the right solution to the dilemma :)
I think xwiki-xmlrpc-model should be named xwiki-xmlrpc-api (analogous servlet-api, jackrabbit-api). API is more meaningful for user than model. +1 for xwiki-platform-core/xwiki-xmlrpc/* placement. -- Artem Melentyev
On Apr 15, 2008, at 6:18 PM, Artem Melentyev wrote:
Fabio Mancinelli wrote:
On 15 avr. 08, at 12:01, Vincent Massol wrote:
Why not create:
xwiki-platform-core/xwiki-xmlrpc/ |_ xwiki-xmlrpc-model/ |_ xwiki-xmlrpc-client/
About splitting into model&client, we discussed that with Fabio and since the client is only one java class we agreed that it was a bit overkill to have a module for it. Wdyt ? Sure that's fine with me to create a single module for now. Just not sure how to name it then. xwiki-xmlrpc-model?
Imho the name should clearly suggest to a potential user who wants to interact with xwiki via xmlrpc that this is the "thing" it should download/use. To me xwiki-xmlrpc-model doesn't seem to convey that idea too much.
Simply "xwiki-xmlrpc" seems to be a better name to me, though having xwiki-platform-core/xwiki-xmlrpc/xwiki-xmlrpc is a bit weird/ confusing.
Or as Vincent suggested, having xwiki-xmlrpc-model and xwiki-xmlrpc- client is fine as well (even though xwiki-xmlrpc-client would be a module with only 1 class) and maybe it's the right solution to the dilemma :)
I think xwiki-xmlrpc-model should be named xwiki-xmlrpc-api (analogous servlet-api, jackrabbit-api). API is more meaningful for user than model.
yes maybe but it's not the API... :) It's the model... Same as we will call xwiki-model the module for the model in the future... Also this is not for users but for developers. Thanks -Vincent
+1 for xwiki-platform-core/xwiki-xmlrpc/* placement.
On 15 avr. 08, at 11:23, Vincent Massol wrote:
The only thing I propose to put in it (at least for the moment) is the swizzle replacement Fabio wrote, a standalone library containing both xwiki xmlrpc model and client code (like swizzle).
I think I don't understand what you're proposing.
More specifically why do you want to introduce a xwiki-commons directory?
Why not create:
xwiki-platform-core/xwiki-xmlrpc/ |_ xwiki-xmlrpc-model/ |_ xwiki-xmlrpc-client/
And then in the future when we move the server part it can go in xwiki- xmlrpc-server/?
The reason why I wrote only one module is that the 95% of the code in this module is shared and there is only one class that is not used by both the client and the server, namely the XWikiXmlRpcClient (which is used, of course, only by the client). So I thought that creating a module for just one class was a bit overkill. It was some kind of module-proliferation optimization :) However, the solution you mentioned is better from the logical point of view, and makes even more sense if we think of a future xwiki- xmlrpc-server that, if I am not wrong, would incorporate the current xmlprc logic as a separate (plexus?) plugin.
note: I assumed the model is used by both the client and the server
That's correct. Thanks, Fabio
participants (5)
-
Artem Melentyev -
Fabio Mancinelli -
Jean-Vincent Drean -
Thomas Mortagne -
Vincent Massol