[xwiki-devs] [VOTE] Add apis to set current user and current wiki
Hi devs, To fix http://jira.xwiki.org/jira/browse/XWIKI-5282 I can't find other way that adding the following apis: * DocumentAccessBridge#setCurrentUser (we already have DocumentAccessBridge#getCurrentUser) * ModelContext#setCurrentEntityReference (we will have to add it at some point anyway) Here is my +1 Also this imply that to fix the bug in 2.3 we need to add theses new apis in 2.3 too. I'm +1 for it too. It can't break anything. WDYT ? -- Thomas Mortagne
On Jun 17, 2010, at 2:37 PM, Thomas Mortagne wrote:
Hi devs,
To fix http://jira.xwiki.org/jira/browse/XWIKI-5282 I can't find other way that adding the following apis: * DocumentAccessBridge#setCurrentUser (we already have DocumentAccessBridge#getCurrentUser) * ModelContext#setCurrentEntityReference (we will have to add it at some point anyway)
Here is my +1
Also this imply that to fix the bug in 2.3 we need to add theses new apis in 2.3 too.
I'm +1 for it too. It can't break anything.
WDYT ?
+1 for both. Thanks -Vincent PS: For the 2.3 branch, it does break source compatibility (as reported by CLIRR) but not binary compatibility.
On Jun 17, 2010, at 2:50 PM, Vincent Massol wrote:
On Jun 17, 2010, at 2:37 PM, Thomas Mortagne wrote:
Hi devs,
To fix http://jira.xwiki.org/jira/browse/XWIKI-5282 I can't find other way that adding the following apis: * DocumentAccessBridge#setCurrentUser (we already have DocumentAccessBridge#getCurrentUser) * ModelContext#setCurrentEntityReference (we will have to add it at some point anyway)
Here is my +1
Also this imply that to fix the bug in 2.3 we need to add theses new apis in 2.3 too.
I'm +1 for it too. It can't break anything.
WDYT ?
+1 for both.
Thanks -Vincent
PS: For the 2.3 branch, it does break source compatibility (as reported by CLIRR) but not binary compatibility.
Actually it break binary compatibility too if some code calls that new interface and some extension had implemented that interface.... -Vincent
+0 for both Thanks, Marius On 06/17/2010 03:37 PM, Thomas Mortagne wrote:
Hi devs,
To fix http://jira.xwiki.org/jira/browse/XWIKI-5282 I can't find other way that adding the following apis: * DocumentAccessBridge#setCurrentUser (we already have DocumentAccessBridge#getCurrentUser) * ModelContext#setCurrentEntityReference (we will have to add it at some point anyway)
Here is my +1
Also this imply that to fix the bug in 2.3 we need to add theses new apis in 2.3 too.
I'm +1 for it too. It can't break anything.
WDYT ?
participants (3)
-
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol