[xwiki-devs] [VOTE] Upgrade jruby macro to use jruby 1.4.0 release
Hi Devs, Among many things jruby-1.4.0 release bundles JSR223 support. See full release notes at http://www.jruby.org/2009/11/02/jruby-1-4-0 I was planning to this upgrade in 2.1 time frame but got a little packed and now we are at 2.1 RC1. However I think it's still safe to do this upgrade with adequate testing (note that jruby-macro is not budled with XE by default). Please let me know if you think this is unwise. Extremely sorry about not doing this sooner. Thanks. - Asiri
Hi Asiri, On Dec 4, 2009, at 6:46 PM, Asiri Rathnayake wrote:
Hi Devs,
Among many things jruby-1.4.0 release bundles JSR223 support. See full release notes at http://www.jruby.org/2009/11/02/jruby-1-4-0
I was planning to this upgrade in 2.1 time frame but got a little packed and now we are at 2.1 RC1. However I think it's still safe to do this upgrade with adequate testing (note that jruby-macro is not budled with XE by default).
Please let me know if you think this is unwise.
Extremely sorry about not doing this sooner.
Why do we need this for XE 2.1 final? If there's no urgency I'd rather have it in 2.1.1 or even 2.2M1. Thanks -Vincent
Hi, Why do we need this for XE 2.1 final? If there's no urgency I'd rather
have it in 2.1.1 or even 2.2M1.
It's not an urgency but I've agreed once on the dev chat that I'm going to do this before 2.1 final release. Also, 1. Currently we are using our own customized JSR223 engine for jruby 1.3.0 ( http://maven.xwiki.org/externals/com/sun/script/jruby-engine/). This is because the default engine had problems when working with current jruby releases. 2. The source code for xwiki-jruby-engine was not hosted anywhere on xwiki public repos (it was on my local machine), and I have accidentally deleted it :( I should have mentioned these two reasons on my previous email. I think these two reasons makes this little urgent? Thanks. - Asiri
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Fri, Dec 4, 2009 at 19:18, Asiri Rathnayake <[email protected]> wrote:
Hi,
Why do we need this for XE 2.1 final? If there's no urgency I'd rather
have it in 2.1.1 or even 2.2M1.
It's not an urgency but I've agreed once on the dev chat that I'm going to do this before 2.1 final release. Also,
1. Currently we are using our own customized JSR223 engine for jruby 1.3.0 ( http://maven.xwiki.org/externals/com/sun/script/jruby-engine/). This is because the default engine had problems when working with current jruby releases.
2. The source code for xwiki-jruby-engine was not hosted anywhere on xwiki public repos (it was on my local machine), and I have accidentally deleted it :(
I should have mentioned these two reasons on my previous email. I think these two reasons makes this little urgent?
Well it's does not make it that urgent but it has to be done. Anyway since we don't distribute it with XE i don't see any issue to do it now.
Thanks.
- Asiri
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Dec 4, 2009, at 7:27 PM, Thomas Mortagne wrote:
On Fri, Dec 4, 2009 at 19:18, Asiri Rathnayake <[email protected]> wrote:
Hi,
Why do we need this for XE 2.1 final? If there's no urgency I'd rather
have it in 2.1.1 or even 2.2M1.
It's not an urgency but I've agreed once on the dev chat that I'm going to do this before 2.1 final release. Also,
1. Currently we are using our own customized JSR223 engine for jruby 1.3.0 ( http://maven.xwiki.org/externals/com/sun/script/jruby-engine/). This is because the default engine had problems when working with current jruby releases.
2. The source code for xwiki-jruby-engine was not hosted anywhere on xwiki public repos (it was on my local machine), and I have accidentally deleted it :(
I should have mentioned these two reasons on my previous email. I think these two reasons makes this little urgent?
Well it's does not make it that urgent but it has to be done. Anyway since we don't distribute it with XE i don't see any issue to do it now.
You're right, I had forgotten this. Still it's bad idea to close jira issues against the final version. This is not a blocker bug fix. I'm still against rushing this. Thanks -Vincent
On Dec 4, 2009, at 7:18 PM, Asiri Rathnayake wrote:
Hi,
Why do we need this for XE 2.1 final? If there's no urgency I'd rather
have it in 2.1.1 or even 2.2M1.
It's not an urgency but I've agreed once on the dev chat that I'm going to do this before 2.1 final release.
Yes but then you should have done it before ;)
Also,
1. Currently we are using our own customized JSR223 engine for jruby 1.3.0 ( http://maven.xwiki.org/externals/com/sun/script/jruby-engine/). This is because the default engine had problems when working with current jruby releases.
2. The source code for xwiki-jruby-engine was not hosted anywhere on xwiki public repos (it was on my local machine), and I have accidentally deleted it :(
I should have mentioned these two reasons on my previous email. I think these two reasons makes this little urgent?
I don't think any of these make it urgent at all. Is the jruby macro working or not right now? If it is then it's not urgent. It's only internal refactoring. RCs are over. If you commit this then we need a RC2. I really really wouldn't like to commit in a final without a RC. I also doubt that you have really tested enough to be sure it's going to work fine. Since there's no need to rush, I'd rather we move this to 2.1.1 or 2.2M1. Thanks -Vincent
On 12/04/2009 07:28 PM, Vincent Massol wrote:
On Dec 4, 2009, at 7:18 PM, Asiri Rathnayake wrote:
Hi,
Why do we need this for XE 2.1 final? If there's no urgency I'd rather
have it in 2.1.1 or even 2.2M1.
It's not an urgency but I've agreed once on the dev chat that I'm going to do this before 2.1 final release.
Yes but then you should have done it before ;)
Also,
1. Currently we are using our own customized JSR223 engine for jruby 1.3.0 ( http://maven.xwiki.org/externals/com/sun/script/jruby-engine/). This is because the default engine had problems when working with current jruby releases.
2. The source code for xwiki-jruby-engine was not hosted anywhere on xwiki public repos (it was on my local machine), and I have accidentally deleted it :(
I should have mentioned these two reasons on my previous email. I think these two reasons makes this little urgent?
I don't think any of these make it urgent at all. Is the jruby macro working or not right now? If it is then it's not urgent. It's only internal refactoring. RCs are over. If you commit this then we need a RC2. I really really wouldn't like to commit in a final without a RC.
This is the downside of using the same release cycle for a component that's not even bundled in the default XE. So, I agree with Vincent that it shouldn't be fixed in the final 2.1 version, but I agree with Asiri that it should be released ASAP, since it doesn't have a really tight bond with the rest of the platform.
I also doubt that you have really tested enough to be sure it's going to work fine. Since there's no need to rush, I'd rather we move this to 2.1.1 or 2.2M1.
Thanks -Vincent
-- Sergiu Dumitriu http://purl.org/net/sergiu/
+1 On Fri, Dec 4, 2009 at 18:46, Asiri Rathnayake <[email protected]> wrote:
Hi Devs,
Among many things jruby-1.4.0 release bundles JSR223 support. See full release notes at http://www.jruby.org/2009/11/02/jruby-1-4-0
I was planning to this upgrade in 2.1 time frame but got a little packed and now we are at 2.1 RC1. However I think it's still safe to do this upgrade with adequate testing (note that jruby-macro is not budled with XE by default).
Please let me know if you think this is unwise.
Extremely sorry about not doing this sooner.
Thanks.
- Asiri _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
participants (4)
-
Asiri Rathnayake -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol