On 12/04/2009 07:28 PM, Vincent Massol wrote:
On Dec 4, 2009, at 7:18 PM, Asiri Rathnayake wrote:
Hi,
Why do we need this for XE 2.1 final? If there's no urgency I'd rather
have it in 2.1.1 or even 2.2M1.
It's not an urgency but I've agreed once on the dev chat that I'm going to do this before 2.1 final release.
Yes but then you should have done it before ;)
Also,
1. Currently we are using our own customized JSR223 engine for jruby 1.3.0 ( http://maven.xwiki.org/externals/com/sun/script/jruby-engine/). This is because the default engine had problems when working with current jruby releases.
2. The source code for xwiki-jruby-engine was not hosted anywhere on xwiki public repos (it was on my local machine), and I have accidentally deleted it :(
I should have mentioned these two reasons on my previous email. I think these two reasons makes this little urgent?
I don't think any of these make it urgent at all. Is the jruby macro working or not right now? If it is then it's not urgent. It's only internal refactoring. RCs are over. If you commit this then we need a RC2. I really really wouldn't like to commit in a final without a RC.
This is the downside of using the same release cycle for a component that's not even bundled in the default XE. So, I agree with Vincent that it shouldn't be fixed in the final 2.1 version, but I agree with Asiri that it should be released ASAP, since it doesn't have a really tight bond with the rest of the platform.
I also doubt that you have really tested enough to be sure it's going to work fine. Since there's no need to rush, I'd rather we move this to 2.1.1 or 2.2M1.
Thanks -Vincent
-- Sergiu Dumitriu http://purl.org/net/sergiu/