[xwiki-devs] Proposal to make Document.addAttachment public
Hi developers, I have been having the need for the exact same function that is available as protected in com.xpn.xwiki.api.Document I propose we make this api public http://jira.xwiki.org/jira/browse/XWIKI-2549 WDYT ? Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
2008/7/9 Ludovic Dubost <[email protected]>:
Hi developers,
I have been having the need for the exact same function that is available as protected in com.xpn.xwiki.api.Document I propose we make this api public
http://jira.xwiki.org/jira/browse/XWIKI-2549
WDYT ?
Only after seeing your mail I realized that i have the same requirement for webdav. I had assumed that this was already available since getAttachment() methods were there. So, a big +1 from me :) Thanks. - Asiri
Ludovic
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On 9 juil. 08, at 19:55, Asiri Rathnayake wrote:
Only after seeing your mail I realized that i have the same requirement for webdav. I had assumed that this was already available since getAttachment() methods were there.
So, a big +1 from me :)
Same thing for XMLRPC. Now the attachment logic is programmed by bypassing the public API. It would be good to make things more uniform and elegant. +1 -Fabio
Ludovic Dubost wrote:
Hi developers,
I have been having the need for the exact same function that is available as protected in com.xpn.xwiki.api.Document I propose we make this api public
http://jira.xwiki.org/jira/browse/XWIKI-2549
WDYT ?
+1 I think getDoc().save() is not needed in public addAttachment. Because if user adds 2 attachments then unneeded save will perform. Explicitly save() is better. -- Artem Melentyev
On Thu, Jul 10, 2008 at 10:42 AM, Artem Melentyev <[email protected]> wrote:
Ludovic Dubost wrote:
Hi developers,
I have been having the need for the exact same function that is available as protected in com.xpn.xwiki.api.Document I propose we make this api public
http://jira.xwiki.org/jira/browse/XWIKI-2549
WDYT ?
+1
I think getDoc().save() is not needed in public addAttachment. Because if user adds 2 attachments then unneeded save will perform. Explicitly save() is better.
+1 and +1 for not adding save in addAttachment
-- Artem Melentyev _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Ludovic Dubost wrote:
Hi developers,
I have been having the need for the exact same function that is available as protected in com.xpn.xwiki.api.Document I propose we make this api public
+1
+1 On Thu, Jul 17, 2008 at 7:04 PM, Sergiu Dumitriu <[email protected]> wrote:
Ludovic Dubost wrote:
Hi developers,
I have been having the need for the exact same function that is available as protected in com.xpn.xwiki.api.Document I propose we make this api public
+1 _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (8)
-
Artem Melentyev -
Asiri Rathnayake -
Fabio Mancinelli -
Jean-Vincent Drean -
Ludovic Dubost -
Miguel Bento -
Sergiu Dumitriu -
Thomas Mortagne