Re: [xwiki-devs] Proposal to make Document.addAttachment public

Ludovic Dubost wrote:

Hi developers,

I have been having the need for the exact same function that is available as protected in com.xpn.xwiki.api.Document I propose we make this api public

http://jira.xwiki.org/jira/browse/XWIKI-2549

WDYT ?

+1 I think getDoc().save() is not needed in public addAttachment. Because if user adds 2 attachments then unneeded save will perform. Explicitly save() is better. -- Artem Melentyev