Hi, Ali, and welcome to XWiki! Hope you'll have a great summer and enjoy discovering our product and being part of our community! Looking forward to see your project come to life. Best, Eduard On Mon, May 13, 2019 at 4:00 PM Ecaterina Moraru (Valica) <valicac(a)gmail.com> wrote:

On Mon, May 20, 2019 at 11:50 AM Fawad Ali <m.fawaadali98(a)gmail.com> wrote: Since you already have a repository the best would be to move it to xwiki-contrib instead of creating a new one. I think you need to make one of the xwiki-contrib organization owner the owner of your current repository to transfert it. -- Thomas Mortagne

Eduard, Thanks for the heads up. I think I was focusing too much on the official documentation and forgot to take a look at the well documented pages for GSoC students. The repository has been moved to xwiki-contrib (thanks to Thomas for that). The updated link is: https://github.com/xwiki-contrib/application-map Thanks, Fawad On Mon, May 20, 2019 at 3:44 PM Eduard Moraru <enygma2002(a)gmail.com> wrote:

Hi, It’s hard to choose without knowing how you position this app vs the existing map macro for example. What’s the proposal? Thanks -Vincent

Ecaterina, Thanks for that. Vincent, regarding the macro the Interactive Maps Application. It will only be used to reference the maps that are already created with some tweaking options to go along. I will be focusing on the main features for now and will create the macro when we are somewhat in the middle of the project so I know which options the macro needs to have. Best, Fawad On Mon, May 20, 2019, 8:35 PM Ecaterina Moraru (Valica) <valicac(a)gmail.com wrote:

Hi developers, Hope you all are well. Interactive maps application's SNAPSHOT 1.0.2 is now available on GitHub. :) Link: https://github.com/xwiki-contrib/application-interactive-maps What has been done so far. - Markers and popups - Custom image support for markers - "xwiki/2.1" syntax support for popups - Simple forms for adding maps - Dedicated "Map Editor" for creating maps - Current location and location search controls - Generating routes between two points Maps can be created simply from Map.WebHome page or with the dedicated Map Editor for live preview. ToDo. - Implement WYSIWYG for "Popup Information" field (I have had some errors in doing it) - Compliance of code with XWiki standards (I should have done it from the start. Sorry about that.) Ecaterina and Stephane, I would like to ask you to evaluate how the application is so far. Your reviews will be highly appreciated. :) Best, Fawad On Mon, May 20, 2019 at 9:18 PM Vincent Massol <vincent(a)massol.net> wrote:

Should I create jira issues for any updates I do during development? I made my commits like INTMAP-R<number> for each revision I did. For simple commits like changing the Progress.md file or a line or two in pom.xml, do I use "[Misc]" for identifying the commit? 8.4-6 is the default version on https://www.xwiki.org/xwiki/bin/view/Documentation/DevGuide/Tutorials/Creat… so I did not change that. It is changed to 11.1 after the fix with encoding issues. Thanks for that. I was using the snapshots version to mark the completion of every major function. Mainly a simple map and a path map for now so the version 1.0.2. I would like to know if snapshots are supposed to be released. For the URL path Map/Maps do you have a better path in mind for the created maps? I think its right when all the other paths are hidden for the user. I will be sure to provide screenshots for the next time. :) For combining all the maps in a single livetable, I have a perspective that for this application, every map is of a "kind" like a "path map" or "simple map" or later on "filtered list map". So I separated the maps based on that perspective. WDYT? Should I treat all the maps same? Thankfully, the Map Macro uses the Macros.MapMacro space so we are safe for that. For the creation options, should I create a single template for the "Add" button and separate the map editors with tabs? If I create a template for each kind of map, the templates will become bulky I think. I also wanted to talk about filtered list maps so that I can move on with the development. Stephane sent me a link in the talks we had prior to this. https://napoleon-sainte-helene.plan-interactif.com/en/#!/category/886826/@-… What kind of options do you have in mind for the filterable list? A general flow would really help me in direction. Thanks. :) Best, Fawad On Fri, May 24, 2019 at 10:02 PM Ecaterina Moraru (Valica) < valicac(a)gmail.com&gt; wrote:

Hi, Hope all are doing well. Extremely thanks for the information Ecaterina. It really helps. :) I am trying to make filterable list maps but I am more or less stuck. This is what I have done so far: [image: image.png] So what I have in mind for this is that each marker will have a category and a custom popup. Then we can have custom marker image for each of the category or for each of the marker separately. I wanted to have forms directly inside the popup but that does not seem to be possible giving how popups in leaflet work. This is a little afar from what I observe in https://napoleon-sainte-helene.plan-interactif.com and I am unable to think of a better way to manage everything. Stephane or Ecaterina, if you have a better approach and flow for this then please let me know. And Stephane, your help would be highly appreciable. Thanks. Best, Fawad On Mon, May 27, 2019 at 6:03 PM Ecaterina Moraru (Valica) &lt;valicac(a)gmail.com&gt; wrote:

Hi Caty, Fawad, all, [...] I would say it's important that a point of interest or any other entity can be present in multiple maps indeed. A map is defined in particular by a query imho – I would suggest a Solr query as argued on the design page, what do you think? – which returns a set of elements. Then the user can refine this set at will using full-text search, facets or spatial search. Ideally that'd be great to support both options I would say. In terms of priority I would go for one object per page to start with. Typically, in the encyclopedia use case defined in the design page, having one object attached to each target page would be very convenient imho: it would ease the maintenance of information, both textual and geographical, related to each page. Supporting multiple objects per page could be quite useful as well. Imagine for instance that we want to represent the "Battle of the Somme" on a map. The content itself may refer to multiple locations (as on the Wikipedia article below and its static image map representation), so it could be handy to let the user input all these locations (points, areas, lines...) as objects attached to the "Battle of the Somme" page itself without the need to create individual pages for each location. There is no reason to hit a very large number of objects in this scenario though. What do you think? https://en.wikipedia.org/wiki/Battle_of_the_Somme Indeed, a map page will consist of a map configuration imho. We need to define what is needed to configure a map, beside the query. The visual configuration is important as well and can be possibly complex, and other options could arise... Stéphane -- Stéphane Laurière XWiki – https://xwiki.com

Fawad, Thanks for your feedback. Regarding the data model: - Map: we clearly need a Map class :-). As discussed, it will hold the map configuration, and possible links to sub-configurations (such as the visual theme, to be discussed). Primarily, the map needs data, so it needs a field for storing a query that will make it possible to retrieve data. You certainly already found the Solr Query API documentation below, I suggest you give it a try and read the basic query principles, then we can set up dedicated examples together on real data in the next days. This brings us to the question of real data. We will quickly need sample data to work with, I think, I'm investigating how to download GeoJSON data from OpenStreetMap, which itself contains links to Wikidata or Wikipedia, this would allow us to grab some content and even images and to have a good sample data set to work with. I'll keep you posted about that. https://extensions.xwiki.org/xwiki/bin/view/Extension/Solr%20Search%20Query… In parallel, you could start thinking about the design and implementation of the query endpoint that will return GeoJSON. Looking a bit into the code of "Main.SolrSearchMacros" could be useful I would say, I'll think about it as well. - Spatial entities : Point, Shape, Path, ...: I agree with you having one XClass for each is probably the way to go, but I would suggest we start just with "Point" and postpone the decision to a bit later if you agree, just to make sure we don't make wrong assumptions and introduce too much complexity (probably not, but to be discussed). Even the "icon" property might be too early at this stage imho, because in real world scenarios I believe it's more important to provide the ability to associate icons to facets key/value pairs than to individual items. It may be useful in the future, but we'll see, I would say. - Content: considering using content ids, or XPaths or XWiki DOM (XDOM) queries could be quite powerful. We don't want the users to maintain manually popup content, while they already have the burden to maintain the main content itself. Using content ids / queries would avoid duplicating content. This shares some concern with the Page Preview application, see links below. I don't have a clear answer yet, we need to discuss a bit further. But we could start with the first page paragraph for instance. https://dev.xwiki.org/xwiki/bin/view/Drafts/Page%20Preview%20Application https://xwiki.markmail.org/message/zhbaw7m3rsnbm26m?q=preview https://github.com/xwiki-contrib/application-page-preview I'll be off in the next couple of hours but I'll provide more feedback as soon as possible. Cheers Stéphane Fawad Ali: -- Stéphane Laurière XWiki – https://xwiki.com

What I will be doing now is create a Map class that can hold configuration properties. If these properties are filled then that data will be used while generating the map else some default configuration will be used. Maybe I will make a separate object for default configuration of the map? Then once I am able to generate a map with the map class I will add a query based property to the map which will hold the query to what the map will have. A macro (maybe some other option?) will be made to handle the data gotten from the query. As we are focusing on a Point for now, I will make the macro so that if a Point object is queried, I will get all the properties of that particular point and add it to the map. For now I will only be querying objects on the same page to reduce complexity at an early stage. Is this a good approach for now or am I in the wrong direction? I really think we should have a detailed video conference since that will get us all on the same page and will take minimum time. Best, Fawad On Tue, May 28, 2019 at 8:30 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

Fawad, I see at two distinct aspects there: - How to associate a visual marker to a category or possibly to any attribute, conceptually - Which user interface do we design and implement to help users define such associations Imho, we have first to agree on the global mechanism to configure markers, then we'll think about the most appropriate user interface. Introducing the concept of category is handy but I fear it could be quicly limited in real world scenarios, not sure. Take the encyclopedia use case, we have HLS at hand, here is a list of places referenced in HLS (by pure coincidence the end point is named "category" here, but the underlying mechanism is a Solr facet): https://hls-dhs-dss.ch/fr/search/category?f_hls.lexicofacet_string=1%2F0068…. Imagine we want to represent these places on a map, with one icon per top level facet: political entity, ecclesiastical entity, environmnent, archeologia, etc. How can we specify that at the data model level? One option would be to introduce a mapping that associates pairs of Solr facet key, value to icons in the map configuration. We could have a large text field for that in the map configuration, what do you think? Another option would be to define a class for individual mappings, not sure it's needed though, a global text field might be enough, at least to begin with. Obviously this question hinges on the more general one about the query language we use to specify a set of entities to be represented on a map. Regarding the user interface for configuring such associations, I have no clear proposal at this stage on my side, however I would suggest we validate the mechanism first, we implement it, and we consider making a visual configurator in a second step, what is your view on that? I agree it's not very handy to define such mappings as text, but on the other hand we gain in extensibility, and easing the configuration remains possible once the global use case is validated and accepted by real-world users (hopefully not far in future, in the frame of the GSoC itself if possible). Sorry, I don't understand well what's the scope of the comparison. Are you referring to the marker display, or the filters, or to the way markers can be configured, and if so, how did you access the marker configuration? Cheers Stéphane -- Stéphane Laurière XWiki – https://xwiki.com

Hi Stéphane, Ecaterina and all, Hope all of you are doing wonderful! So I am working on the new iteration for the Interactive Maps Application and have made some progress which I would like to share with all of you. As suggested by Stephane, the application is now being developed on a new architecture which emphasizes the use of Solr queries for gathering data to display on the map. The space has also been changed to "Maps" as suggested by Ecaterina. Link: https://github.com/9inpachi/interactive-maps-new I have not shifted the files to xwiki-contrib because I wanted an initial review if I am doing the right thing so I don't have to change the whole repo twice. I have been able to generate a map and the application is now able to handle basic queries to include points (markers) inside the map. I would like you to please give it a look and let me know if I am going in the right direction. :) Main application pages: - Maps.Code.Map.MapClass => The main map class - Maps.Code.Map.MapSheet => Map sheet that renders the map - Maps.Code.Map.WebHome => Simple form for creating a map object page - Maps.Code.Point.PointClass => Main class for a simple point (marker) - Maps.Code.Leaflet => Page where all the javascript and stylesheet extensions exist - Maps.Code.CommonMacros => Some common macros used throughout the application - Maps.MapTesting => Space that contains objects and maps for testing For adding a Point, create a simple page, add content to it and attach a PointClass object with a value to it. If you want to have a look at how the map is rendered, see the MapSheet and the relevant jsx (leaflet-main) code on the Leaflet page. I have attached some screenshots to show what the application does at this point. Best, Fawad On Wed, May 29, 2019 at 5:12 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

Hi all, Thanks for the detailed review, Stephane. I have made the changes you suggested with some next steps also done. Furthermore, I will make changes to the application space once we have confirmed response from Caty or other developers. I have started to work on the other next steps and will provide with updates soon. The original github repo is also updated, so future updates will be available at https://github.com/xwiki-contrib/application-interactive-maps . Thanks, Fawad On Mon, Jun 3, 2019 at 12:38 PM Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; wrote:

Hi Stephane, Caty and all, Hope you are doing fine. I am glad you brought up the topic of custom marker icon. I am well aware of the issue. Actually there are two problems with custom markers. - The icon offset - The document attachment For the icon offset, when I tried to fix it initially it seemed that I can overcome the offset either by height or width which means that the offset still exists from a single side so I had that postponed since I thought solr query tasks take priority. For the attachment, for now I am getting the first attachment (0th index) from the Point page which is not very reliable. For example if we have images on the page, it could be that the marker takes one of the attachments even if the user did not want a custom icon or an image different from what the user wanted to choose is selected as the marker icon. What I have in mind is that we define categories for marker icons dynamically. We could make a separate dedicated page "MarkerIcons" and attach multiple images to it. Then these images could appear in a list as one of the properties in the Point object where we can choose the icon from. WDYT? Thanks, Fawad On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière &lt;slauriere(a)xwiki.com wrote:

Hi, Some notes: - We don't have guidelines regarding the singular / plural thing. I'm glad that on the new sources we don't have the Maps/Map anymore. I'm fine with Maps. In practice we have a mix of singular (like Diagram, Calendar, Meeting) and plural (like Ideas, Forums). I prefer the plural version, although in practice I think we have more with singular. There was a tentative old draft for having such guidelines https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines but we didn't worked on it for some time. - Regarding the new Git repository. Since you've committed the initial commits in issues, you should do a release with the initial version, and than just release a new version for the interactive-maps-new . It's normal in an application's development flow that changes happen, that's why versioning schemes are all about. - I still have the error I've mentioned before : Uncaught Error: Script error for "leaflet", needed by: leafletSearch http://requirejs.org/docs/errors.html#scripterror at F (require.min.js?r=1:7) at HTMLScriptElement.onScriptError (require.min.js?r=1:30) leaflet.css:1 Failed to load resource: the server responded with a status of 404 (Not Found) so I cannot actually test the build, since I don't see the maps. I have this both on Chrome and Firefox. Do I need to do something? Thanks, Caty On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

I've used the latest build from https://github.com/9inpachi/interactive-maps-new and I have the error both on 11.4-rc-1 and some 11.4-snapshot. Thanks, Caty On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

I just built and imported the application from my own repo ( https://github.com/9inpachi/interactive-maps-new) and everything seems fine. There was that error in the more earlier builds but it was fixed, may be some of the source files (especially Leaflet.xml) are old? Try building the source files anew with "mvn clean install". May be that will help. Thanks, Fawad On Wed, Jun 5, 2019, 10:37 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com wrote:

Hi Caty, The last thing to be wary of is to have the Leaflet dependency installed. If I remove my Leaflet webjar, I get this set of errors. GET http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.css net::ERR_ABORTED 404 (Not Found) require.min.js?r=1:34 GET http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1 net::ERR_ABORTED 404 (Not Found) require.min.js?r=1:7 Uncaught Error: Script error for "leaflet", needed by: leafletSearch http://requirejs.org/docs/errors.html#scripterror at F (require.min.js?r=1:7) at HTMLScriptElement.onScriptError (require.min.js?r=1:30) I think Its the same problem your side. For installing Leaflet, search for Map Macro in extensions, from its dependencies tab in details go to Leaflet and install it. That ought to work. :) Best, Fawad On Thu, Jun 6, 2019 at 2:24 PM Ecaterina Moraru (Valica) &lt;valicac(a)gmail.com&gt; wrote:

Hi all, Hope you all are doing wonderfully. We still have the issue for the facets rendering but its up on the forum, so I think we will have some fixes for it in due time (thanks to Stephane). In the meantime, I will try making the facets more specific to the map. For now I am considering the following options for facets: - Tags - Search field (searches inside map item pages) - Map item type (PointClass for now) - Map item icon (?) - Map item space I will need some suggestions on which other options should be included. Next, I will - Be working on making a dedicated space for popups inside or besides the map. Something similar to https://abc.gogocarto.fr - Make use of theme styles and colors for the map itself and the items inside - Be making the query search asynchronous Also, I will be working part time for the next week and I have exams the week after that. So I would like to let you know that I would not be available for the exams period for the most part. :( I will try to finish most of the work and get the application in a stable state by then. :) Ecaterina also mentioned that we release the application, I propose we do that next week as soon as the facets are in a stable state. Thanks, Fawad On Thu, Jun 6, 2019 at 6:42 PM Ecaterina Moraru (Valica) &lt;valicac(a)gmail.com&gt; wrote:

Hi Caty, Thanks for the review. This space exists only for testing. It won't be there for the real application. I named them so that its easier to know which type of object pages are located in them (for myself). MapTesting, Maps, Points - spaces don't have homepages. The users will Since we are in the beta stage now, the whole MapTesting space exists for testing for developers. It would not be there once we have a stable version ready for release. Lots of pages that are not hidden. All technical pages needs to be Again, these pages are not technical and exist only for testing purposes. A bit confusing that there are 2 search boxes for the maps, see Yes, thanks for pointing out. We need to move the search function directly inside the map. I will look into it once I am done with the facets. For the search input, its in extremely beta stage. I am still trying to figure out the macros I have borrowed from SolrSearchMacros. So it will take time for me to make a more stable version of the facets. I hope I can do that in due time. :) Regarding the facets, we need some more user friendly translations and As discussed earlier with Stephane, we are still having issues using the normal $facetDisplayer so we are using a workaround for testing purposes that's why it looks like this. More precisely, we are using the #displaySearchFacetValues($facetValues) macro for now. Best, Fawad On Fri, Jun 7, 2019 at 5:18 PM Ecaterina Moraru (Valica) &lt;valicac(a)gmail.com&gt; wrote: > Hi, > > On Fri, Jun 7, 2019 at 2:01 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote: > >> Hi all, >> Hope you all are doing wonderfully. >> >> We still have the issue for the facets rendering but its up on the forum, >> so I think we will have some fixes for it in due time (thanks to Stephane). >> In the meantime, I will try making the facets more specific to the map. >> For now I am considering the following options for facets: >> - Tags >> - Search field (searches inside map item pages) >> - Map item type (PointClass for now) >> - Map item icon (?) >> - Map item space >> I will need some suggestions on which other options should be included. >> >> Next, I will >> - Be working on making a dedicated space for popups inside or besides >> the map. Something similar to https://abc.gogocarto.fr >> - Make use of theme styles and colors for the map itself and the items >> inside >> - Be making the query search asynchronous >> >> Also, I will be working part time for the next week and I have exams the >> week after that. So I would like to let you know that I would not be >> available for the exams period for the most part. :( >> I will try to finish most of the work and get the application in a stable >> state by then. :) >> Ecaterina also mentioned that we release the application, I propose we do >> that next week as soon as the facets are in a stable state. >> > > That would be great in order for people to faster install it and test it. > You could also request feedback on the forum if you want. > When releasing you also need to write the documentation for the existing > features, mentioning how to use them, etc. + list the fixed issues. > > I managed to get the maps working. Thanks for your help. > Some comments on the current state: > - Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space is > duplicated > - MapTesting, Maps, Points - spaces don't have homepages. The users will > navigate to them, since they are present in breadcrumb. So what is the > plan? Simpler paths? or create Homepages for these types of entry? > - Lots of pages that are not hidden. All technical pages needs to be > hidden. > - A bit confusing that there are 2 search boxes for the maps, see > - The Search input is not really working. It kind of works (with a strange > reload effect) for queries like "Paris" or "Moscow", but if you enter > anything else it defaults on Paris. If that search is supposed to filter > only the existing points than the placeholder should state that somehow + > treat the non existing point with a "No point of interest found" or > something. Also when it doesn't find the location, the search facets area > is empty, so kind of hard for an user to recover it's track. > - Regarding the facets, we need some more user friendly translations and > > Thanks, > Caty > > >> Thanks, >> Fawad >> >> >> On Thu, Jun 6, 2019 at 6:42 PM Ecaterina Moraru (Valica) < >> valicac(a)gmail.com&gt; wrote: >> >>> That most likely is the problem, since I've just imported the XAR, no >>> real install. I will try like that, thanks for helping. >>> >>> Caty >>> >>> On Thu, Jun 6, 2019 at 1:03 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >>> wrote: >>> >>>> Hi Caty, >>>> >>>> The last thing to be wary of is to have the Leaflet dependency >>>> installed. >>>> If I remove my Leaflet webjar, I get this set of errors. >>>> >>>> GET >>>> http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.css >>>> net::ERR_ABORTED 404 (Not Found) >>>> require.min.js?r=1:34 GET >>>> http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1 >>>> net::ERR_ABORTED 404 (Not Found) >>>> require.min.js?r=1:7 Uncaught Error: Script error for "leaflet", needed >>>> by: leafletSearch >>>> http://requirejs.org/docs/errors.html#scripterror >>>> at F (require.min.js?r=1:7) >>>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30) >>>> >>>> I think Its the same problem your side. >>>> For installing Leaflet, search for Map Macro in extensions, from its >>>> dependencies tab in details go to Leaflet and install it. >>>> That ought to work. :) >>>> >>>> Best, >>>> Fawad >>>> >>>> >>>> On Thu, Jun 6, 2019 at 2:24 PM Ecaterina Moraru (Valica) < >>>> valicac(a)gmail.com&gt; wrote: >>>> >>>>> Hi Fawad, >>>>> >>>>> I still have the issue: no maps loaded, leaflet.css error in console. >>>>> Tested with the most recent snapshot of 11.5 and with the build from >>>>> https://github.com/xwiki-contrib/application-interactive-maps >>>>> I have the same problem with Firefox, Chrome, Safari and Opera. I'm on >>>>> Mac. >>>>> https://up1.xwikisas.com/#mXONZtF2qcMeftvnyJOSjw >>>>> The script from “ >>>>> http://localhost:8084/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1” >>>>> was loaded even though its MIME type (“text/html”) is not a valid >>>>> JavaScript MIME type. >>>>> >>>>> Also Maps.MapTesting.Points.Islamabad.WebHome page seems to have >>>>> error when importing (with the "Replace the page history with the >>>>> history from the package" option) >>>>> https://up1.xwikisas.com/#ag8AIsPHgcFYqVod2RMJQQ >>>>> >>>>> Thanks, >>>>> Caty >>>>> >>>>> >>>>> On Wed, Jun 5, 2019 at 8:50 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >>>>> wrote: >>>>> >>>>>> I just built and imported the application from my own repo ( >>>>>> https://github.com/9inpachi/interactive-maps-new) and everything >>>>>> seems fine. >>>>>> >>>>>> There was that error in the more earlier builds but it was fixed, may >>>>>> be some of the source files (especially Leaflet.xml) are old? >>>>>> Try building the source files anew with "mvn clean install". May be >>>>>> that will help. >>>>>> >>>>>> Thanks, >>>>>> Fawad >>>>>> >>>>>> On Wed, Jun 5, 2019, 10:37 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com >>>>>> wrote: >>>>>> >>>>>>> We have shifted the repo to xwiki-contrib again. You may try that. I >>>>>>> will also check my own repo for any errors ASAP. >>>>>>> >>>>>>> Best, >>>>>>> Fawad >>>>>>> >>>>>>> On Wed, Jun 5, 2019, 10:35 PM Ecaterina Moraru (Valica) < >>>>>>> valicac(a)gmail.com wrote: >>>>>>> >>>>>>>> I've used the latest build from >>>>>>>> https://github.com/9inpachi/interactive-maps-new >>>>>>>> and I have the error both on 11.4-rc-1 and some 11.4-snapshot. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Caty >>>>>>>> >>>>>>>> On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Caty, do you have the error with the latest git repo as well? >>>>>>>>> Actually the leaflet-commons require leaflet but the functions are >>>>>>>>> not actually called anywhere without the leaflet dependency used in require. >>>>>>>>> >>>>>>>>> There is no error on my or Stephane side. >>>>>>>>> I have the 11.3-rc version of XWiki. >>>>>>>>> You can try Ctrl+F5 for a complete new load of the resources. >>>>>>>>> >>>>>>>>> Best, >>>>>>>>> Fawad >>>>>>>>> >>>>>>>>> On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica) < >>>>>>>>> valicac(a)gmail.com wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Some notes: >>>>>>>>>> - We don't have guidelines regarding the singular / plural thing. >>>>>>>>>> I'm glad that on the new sources we don't have the Maps/Map anymore. I'm >>>>>>>>>> fine with Maps. In practice we have a mix of singular (like Diagram, >>>>>>>>>> Calendar, Meeting) and plural (like Ideas, Forums). I prefer the plural >>>>>>>>>> version, although in practice I think we have more with singular. There was >>>>>>>>>> a tentative old draft for having such guidelines >>>>>>>>>> https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines >>>>>>>>>> but we didn't worked on it for some time. >>>>>>>>>> >>>>>>>>>> - Regarding the new Git repository. Since you've committed the >>>>>>>>>> initial commits in issues, you should do a release with the initial >>>>>>>>>> version, and than just release a new version for the interactive-maps-new . >>>>>>>>>> It's normal in an application's development flow that changes happen, >>>>>>>>>> that's why versioning schemes are all about. >>>>>>>>>> >>>>>>>>>> - I still have the error I've mentioned before : >>>>>>>>>> Uncaught Error: Script error for "leaflet", needed by: >>>>>>>>>> leafletSearch >>>>>>>>>> http://requirejs.org/docs/errors.html#scripterror >>>>>>>>>> at F (require.min.js?r=1:7) >>>>>>>>>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30) >>>>>>>>>> >>>>>>>>>> leaflet.css:1 Failed to load resource: the server responded with >>>>>>>>>> a status of 404 (Not Found) >>>>>>>>>> >>>>>>>>>> so I cannot actually test the build, since I don't see the maps. >>>>>>>>>> I have this both on Chrome and Firefox. Do I need to do something? >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Caty >>>>>>>>>> >>>>>>>>>> On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Also, I forgot to mention it before but we will need a better >>>>>>>>>>> and more expressive way to show popups. We need something that can >>>>>>>>>>> accomodate sufficient amount of text with a scroll if the information >>>>>>>>>>> exceeds the page. >>>>>>>>>>> I will prepare a mockup for this once I am done with some of the >>>>>>>>>>> next steps. >>>>>>>>>>> >>>>>>>>>>> And I think we should use the colortheme colors for our map >>>>>>>>>>> controls and consequently for the popups. I will update you on that as well. >>>>>>>>>>> >>>>>>>>>>> Best, >>>>>>>>>>> Fawad >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali < >>>>>>>>>>> m.fawaadali98(a)gmail.com&gt; wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Stephane, Caty and all, >>>>>>>>>>>> Hope you are doing fine. >>>>>>>>>>>> >>>>>>>>>>>> I am glad you brought up the topic of custom marker icon. I am >>>>>>>>>>>> well aware of the issue. Actually there are two problems with custom >>>>>>>>>>>> markers. >>>>>>>>>>>> - The icon offset >>>>>>>>>>>> - The document attachment >>>>>>>>>>>> >>>>>>>>>>>> For the icon offset, when I tried to fix it initially it seemed >>>>>>>>>>>> that I can overcome the offset either by height or width which means that >>>>>>>>>>>> the offset still exists from a single side so I had that postponed since I >>>>>>>>>>>> thought solr query tasks take priority. >>>>>>>>>>>> >>>>>>>>>>>> For the attachment, for now I am getting the first attachment >>>>>>>>>>>> (0th index) from the Point page which is not very reliable. For example if >>>>>>>>>>>> we have images on the page, it could be that the marker takes one of the >>>>>>>>>>>> attachments even if the user did not want a custom icon or an image >>>>>>>>>>>> different from what the user wanted to choose is selected as the marker >>>>>>>>>>>> icon. >>>>>>>>>>>> >>>>>>>>>>>> What I have in mind is that we define categories for marker >>>>>>>>>>>> icons dynamically. >>>>>>>>>>>> We could make a separate dedicated page "MarkerIcons" and >>>>>>>>>>>> attach multiple images to it. Then these images could appear in a list as >>>>>>>>>>>> one of the properties in the Point object where we can choose the icon >>>>>>>>>>>> from. WDYT? >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Fawad >>>>>>>>>>>> >>>>>>>>>>>> On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière < >>>>>>>>>>>> slauriere(a)xwiki.com wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Fawad, Thanks for letting us know, I could install the new app >>>>>>>>>>>>> version, I confirm that all the changes you added to the progress file >>>>>>>>>>>>> (very handy) work for me, and the refactoring is ok. I noticed a minor >>>>>>>>>>>>> issue that you're certainly aware of already: it seems there's a small >>>>>>>>>>>>> offset between the custom marker position (with the Islamabad point) and >>>>>>>>>>>>> the popup position. >>>>>>>>>>>>> >>>>>>>>>>>>> Talk to you soon, >>>>>>>>>>>>> >>>>>>>>>>>>> Stéphane >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Fawad Ali: >>>>>>>>>>>>> > Hi all, >>>>>>>>>>>>> > >>>>>>>>>>>>> > Thanks for the detailed review, Stephane. I have made the >>>>>>>>>>>>> changes you suggested with some next steps also done. >>>>>>>>>>>>> > >>>>>>>>>>>>> > Furthermore, I will make changes to the application space >>>>>>>>>>>>> once we have confirmed response from Caty or other developers. >>>>>>>>>>>>> > I have started to work on the other next steps and will >>>>>>>>>>>>> provide with updates soon. >>>>>>>>>>>>> > >>>>>>>>>>>>> > The original github repo is also updated, so future updates >>>>>>>>>>>>> will be available at >>>>>>>>>>>>> https://github.com/xwiki-contrib/application-interactive-maps. >>>>>>>>>>>>> > >>>>>>>>>>>>> > Thanks, >>>>>>>>>>>>> > Fawad >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Stéphane Laurière >>>>>>>>>>>>> XWiki – https://xwiki.com >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>

Hi, Thanks for the PR Stephane! It really helps in knowing how I should do things. I will accept the PR now and make changes later if required. I tested it and everything seems fine so far except for some country facets the map goes blank (bad data handling on my part maybe). Hoping such sample data can help developing further and think in greater It helps a lot, thanks. When displaying such a map, that'd be great if the available facets would This has been done and will be included in today's commit. I was actually writing my custom solr configurations for the map. Now that I know a use case, I can include better options. Best, Fawad On Fri, Jun 7, 2019 at 9:59 PM Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; wrote:

Hi everyone, Hope all are well. Ecaterina, Stephane, For the search, do you think that we have to keep both the filter search and the search inside the map? I feel like its an important use case for the users to be able to search a location/place but that is not possible with the query search. One approach is to have a single form with select options if the the user wants to query the data or make a location search. WDYT? Here's a categorical single search form I made about a year ago: https://jsfiddle.net/9inpachi/e428fLgr/ I took a look at the application-releasenotes and what I understand is that there are sample demo pages instead of functional tests. I personally think our Interactive Maps Application aligns well with that approach and we can have the same type of tests/demos. WDYT? I would start preparing for a release for now and implement the tests once we have coordinated on how we do it. Best, Fawad On Fri, Jun 7, 2019 at 10:29 PM Vincent Massol &lt;vincent(a)massol.net&gt; wrote:

Hi, Just realized that the release notes app is a bad example since it currently doesn’t contain any func test! They’re missing and a TODO. You could check other app like the FAQ app for an example of a func test. Sorry about that. Thanks -Vincent

Hi all, Hoping that everything is going well. Stephane, I was able to do implement most of your suggestions except the search results list. I am not too sure where I should place it. As per the latest build, the filter widget appears to the left. Do you think it is practical that we replace this widget with the search results when the user wants to see the search results and show the widget back again when the user clicks on the widget control? I am not too sure what approach I should choose here in terms of UX. Ecaterina, your views on this would help a lot. Thanks. :) Also, do you foresee the map to take full browser height and width as is seen in all the examples you gave me? Regarding the release, I will try preparing everything by tonight so that it is available for your review, including the demo tests that Vincent suggested. Best, Fawad On Thu, Jun 13, 2019 at 12:59 PM Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; wrote:

Hi Fawad, Caty, all, I just gave a try to the latest code, well done with the Solr queries and the search integration in the user interface, that's cool! Imho the most convenient UX is the following for these widgets, something similar to this map: http://carte.preference-commerce.fr/cci-fr/ That is: - The facets can get activated from a button. When they get activated, they show up in an overlay panel on top of the map, without hiding the list. - The list gets displayed under the search input, in an overlay as well, and can be completely hidden on request It's rather close to what Google Maps proposes as well, except that the facets replace the list in that case (when hitting "Autres filtres"), which is a bit less convenient in my opinion, but not a big deal: https://www.google.com/maps/search/Restaurants/@48.865957,2.352974,16z What do you think? That would be a nice feature to have a button on the map to turn it full-screen indeed, similarly to what happens with the XWiki text editor. Cheers Stéphane

Hi all, I have prepared demos and have set up the repository after analyzing application-releasenotes. Please check to see if the tests and demos are working fine so we can move on to releasing the application. https://github.com/xwiki-contrib/application-interactive-maps Best, Fawad On Tue, Jun 18, 2019 at 8:25 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

Hi, How about: * Maximizing the app area by removing the right panels; * Have the map take all the available space https://up1.xwikisas.com/#CnVVQ4JOC1ZPzAHSSbyAaQ * Controls: Search, Full Screen, Zoom * If the user want to search https://up1.xwikisas.com/#UYDXywBeRfcwLX6d06NVtA * expand the search control: allow input and facets using an overlay * If the user has results https://up1.xwikisas.com/#LoeVbE9idboPvoG2w3dE0Q * display using overlay. center map on result click * allow further filtering through facets These are just ideas, maybe there are other solutions. Thanks, Caty On Wed, Jun 19, 2019 at 6:59 PM Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; wrote:

Hi Caty, Stephane and all, Hope you are all well. Stephane, your suggestions regarding the filter and search are great but I feel the flow of our application is more inclined towards what Ecaterina proposes. I will try implementing the mockups. One problem we have though is that both our facets and search lead to a reload of all the content inside the page asynchronously which means any changes made through frontend are lost (like active dropdowns etc.). We need to fix this. Do you think I will have to redo both as a separate JSON service? I can think of a way for search but facets are a little confusing. Also, we still haven't found a way to fix the $facetDisplayer problem. ( https://github.com/xwiki-contrib/application-interactive-maps/blob/master/a… ) How do you think we should proceed with this? Regarding the tests, I will start preparing them as soon as I am done with implementing the new search and facets UI. However, I do have confusion as to what kind of functional tests I should perform. I am listing some that I have in mind. - Map is created properly - Facets are working - Search returns expected results - Popup works fine And other similar functions. I will need some guidance as to how I should take a start since I have not actually made tests for real applications. After analyzing some of the tests that Vincent and Ecaterina have shared, I think we have to perform user actions programmatically and check to see if the output we are receiving is correct. Is that right? Thanks, Fawad On Wed, Jun 19, 2019 at 9:36 PM Ecaterina Moraru (Valica) &lt;valicac(a)gmail.com&gt; wrote:

Hi Stephane, Caty and all, Hope you are doing great. I have deployed a test case for map creation. I would like you to have a look at it. It works fine upto the commented code. There is one problem I am facing which is, during the last part, the marker does not load up. If I restart the same XWiki instance from the target folder and go to the page created during the test, the marker appears perfectly. I am not sure what's wrong. And one time I tried the test, the marker did appear during the test and then I ran the test again without changing anything but the marker did not show up. I am using wait but it does not seem to be the problem with javascript. It appears that the map is not getting the rendered data from velocity and again I am not sure why when it works perfectly if I view the same page outside of test. I would also like your review on the new search and fullscreen controls. Thanks, Fawad On Thu, Jun 20, 2019 at 2:41 PM Ecaterina Moraru (Valica) &lt;valicac(a)gmail.com&gt; wrote:

Hi everyone, Hope to find you well. Their flow is actually completely in line with what I have in mind as well That would certainly be better in my opinion. I would expect the search button to be closer to the area where the widget It was that way in the previous commits. But the idea of this approach is to have the left side completely blank with no controls. What it helps in is to provide a dedicated space for both the popup and search widget. If we place the search control on the top left, our search control is hidden when either popup or the search widget is enabled. And if we place the search widget right beside the search control (to the right of it), it will take unnecessary space. One option is to have the close icon to the right of the search widget popup but it still doesn't fix the problem of search control hiding when the marker popup is opened. Indeed, that's an issue. Regarding facets, page Main.SolrSearch behaves That's exactly what I eventually had in mind besides the JSON service. For the JSON service, we could have a common place for retrieving any kind of map data, like a REST API but that was the secondary approach. What we could do now is utilize the URL parameters. For now, I am thinking of having a multiple URL parameter that can contain different states of the map. For example, if we have both the fullscreen and search popup enabled, we could have the URL parameters "?mfullscreen=true&msearchw=true" where mfullscreen = map full screen and msearchw = map search widget. Other parameters like this can be added for different states. WDYT? We came up with a possible workaround with Anca, which consists in using That's great, I will check it out as soon as I am able. Best, Fawad On Fri, Jun 28, 2019 at 3:02 PM Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; wrote: > Hi Fawad, Caty, all, > > Apologies for the delay. Meantime, I confirm that Caty and I filled in the > 1st GSoC evaluation for the period, with very positive appreciations. > Thumbs up Fawad, and good luck with the next steps. > > Fawad Ali: > > Hi Caty, Stephane and all, > > Hope you are all well. > > > > Stephane, your suggestions regarding the filter and search are great but > I > > feel the flow of our application is more inclined towards what Ecaterina > > proposes. I will try implementing the mockups. > > That's very helpful to have mockups indeed to align the visions. Their > flow is actually completely in line with what I have in mind as well > (except I may prefer personaly to have the facet above the result list > items, to be discussed...), and I see in the latest version (of today) that > you made good progress toward that direction. The fullscreen widget is cool > and works fine. I would expect the search button to be closer to the area > where the widget pops in, that is on the left side in our current setup, > what do you think? > > > One problem we have though is that both our facets and search lead to a > > reload of all the content inside the page asynchronously which means any > > changes made through frontend are lost (like active dropdowns etc.). We > > need to fix this. > > Do you think I will have to redo both as a separate JSON service? I can > > think of a way for search but facets are a little confusing. > > Indeed, that's an issue. Regarding facets, page Main.SolrSearch behaves > > Also, we still haven't found a way to fix the $facetDisplayer problem. > > ( > > > https://github.com/xwiki-contrib/application-interactive-maps/blob/master/a… > > ) > > How do you think we should proceed with this? > > We came up with a possible workaround with Anca, which consists in using > > > https://forum.xwiki.org/t/including-code-dynamically-from-a-sheet/5085/3 > > > Regarding the tests, I will start preparing them as soon as I am done > with > > implementing the new search and facets UI. > > However, I do have confusion as to what kind of functional tests I should > > perform. I am listing some that I have in mind. > > - Map is created properly > > - Facets are working > > - Search returns expected results > > - Popup works fine > > And other similar functions. > > I will need some guidance as to how I should take a start since I have > not > > actually made tests for real applications. > > After analyzing some of the tests that Vincent and Ecaterina have > shared, I > > think we have to perform user actions programmatically and check to see > if > > the output we are receiving is correct. Is that right? > > I need to look more into the testing framework including the pointers and > examples provided by Vincent and Caty, and to go through the steps you > mention in your mail dated from 24/6, I'll get back to you on this. > > Cheers > > Stéphane > > > > Thanks, > > Fawad > >

Hi Fawad, Good to hear from you again, I hope things are fine on your end as well. Thanks for the update. Sorry for the delay, we were traveling yesterday. Releasing the application soon sounds good. I'm facing a few issues though, they may be related to an installation issue on my side, not sure. I grabbed the latest code and imported as a XAR over the existing pages in my 11.x wiki without error, and I notice the following (I'll consider posting some Jira issues if needed): - catalina.out errors (not sure if they were present with previous version): 2019-07-10 11:34:30,349 [http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&am…] WARN c.x.x.w.s.JsExtension - Error at line 203, column 85: missing variable name. Caused by: [ var index = 0, lat = 0, lng = 0, coordinates = [], shift = 0, result = 0, byte = null, latitude_change, longitude_change, factor = Math.pow(10, Number.isInteger(precision) ? precision : 5);] 2019-07-10 11:34:30,350 [http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&am…] WARN c.x.x.w.s.JsExtension - Error at line 206, column 13: identifier is a reserved word. Caused [...] 2019-07-10 11:35:02,841 [http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&am…] ERROR c.x.x.w.s.JsExtension - Runtime error minimizing JSX object: Compilation produced 8 syntax errors. 2019-07-10 11:35:02,841 [http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&am…] WARN c.x.x.w.s.JsExtension - Failed to compress JS extension: null - On the UI side, possibly as a consequence, I can't see a list of results anymore, and the search widget state is not restored. - I notice there is no default radio button checked in the search form: I think either "location" or "item" should be checked, to let the user know what's the default (I'd say "item"). - I think the name "Maps.Code.Leaflet" might be misleading for potential developers: this could mean this page is providing Leaflet, while it does not. I would suggest to choose a name that is closer to what the JavaScript really provides, from a functional point of view, what do you think? - Ludovic just suggested an improvement (for the next versions): let the user configure which existing field could be used in an existing class for retrieving geographical information, that could be interesting indeed, to be discussed. The calendar application works this way already as far as I understood: it lets the user define the date / time field to be used. Cheers Stéphane Fawad Ali:

Hi Fawad, all, The error does not show anymore indeed on my end, thanks. In the meantime, I figured out that the list shows up indeed when issuing a query in the search input, cool. However, as a user I would expect the list to be present also when the search input is empty, with the possibility to reduce the list by hitting the link "Show result items", what do you think? Speaking of the list, that'd be great imho that the popups can be displayed while the list is active, so that the user can browse content via the list, wouldn't it? This should not prevent us from release version 1.0 though. Actually, with the new version, the facet state is restored as I would expect it, sorry for the confusion. Restoring the full screen is working in most cases, that's cool, however if I run a search, then enter full screen, then refine the search, it seems that the full screen state is not preserved, is it? A note about demos: as far as I can see, the museum map demo does not showcase the "country" facet by default, don't you think that'd be worth adding it so that the user has a simple demo with facets working with custom fields? I agree LeafletMap would be closer to what it does, but contrarily to the Macro Map, if I'm not mistaken, the page currently named Maps.Code.Leaflet does not create a JavaScript LeafletMap class, so technically it's more a LeafletUtils than a LeafletMap, isn't it? I acknowledge I'm picky with names... I noticed that leaflet-main requires leaflet-commons but I'm actually wondering how to make sure that leaflet-commons is known from RequireJS before leaflet-main gets loaded. I have not faced any error in practice, but I'm wondering if you tackled the issue already or if we need to figure it out. Ok cool. Cheers Stéphane -- Stéphane Laurière XWiki – https://xwiki.com

Hi Fawad, Hi all, Yes indeed, the number of items would then decrease either when a text search is made or a facet filter is checked. As a user, I like the Airbnb map experience with popups on top of the markers, what about you? <https://www.airbnb.com/s/soweto/homes?refinement_paths%5B%5D=%2Fhomes&query=soweto&click_referer=t%3ASEE_ALL%7Csid%3A8a34e891-60f3-47cd-a4e6-bb4182ff26ac%7Cst%3AMAGAZINE_HOMES&search_type=unknown&zoom=11&search_by_map=true&sw_lat=-26.439251721636115&sw_lng=27.49917114990228&ne_lat=-25.91485138495341&ne_lng=28.197489631347594&checkin=2019-07-18&checkout=2019-07-20&place_id=ChIJcWB04rGmlR4R322eHsI4CDo&s_tag=t8HDGbAs> The ability to highlight a marker when hovering the list is also quite handy. (note also the "search as I move the map feature") Imho the popups could be reasonably small by default, and later on we may consider various improvements such as 1) the ability to increase the popup side dynamically like what happens on the map below when you hit the link "Plus d'information" at the bottom of the panel: http://carte.preference-commerce.fr/cci-fr/ 2) the ability to choose where this contextual information should show up. For instance, for users having large content to get displayed, it could make sense to let the content replace entirely the list one, just like what Google does in this example (which is close to what we have at the moment, except that I wouldn't hide the search input, and I would add a "Back to results" link just like what Google does, and keep the same container so that the user understands better that the two panels are complementary, I find it easier to grasp the underlying behaviour): <https://www.google.com/maps/place/Ch%C3%A2teau+De+Monteton/@44.6171828,0.1365399,11z/data=!4m11!1m2!2m1!1srestaurant!3m7!1s0x12aa94fd12973be1:0x5c1dfe53cb53965f!5m2!4m1!1i2!8m2!3d44.6227756!4d0.2553132> Along this line, another improvement (you probably have it in mind) would be to introduce one or several dedicated sheets for such contextual information so that it can get easily customized by users with development skills. Ok, we need to investigate this. I have a preliminary question about this feature: how come that the URL does not reflect the mode status when hitting the full screen button the first time? I mean, if I'm not mistaken, when hitting the button before running any search, the URL remains unchanged, while the user may want to use that URL to share the map in full screen as is, or to embed it in full screen in a iframe, so shouldn't this parameter be present? Is there any difficulty with that? Wouldn't the facet widget reuse that URL afterwards? Sorry for any possible misunderstanding on my end. Ok cool. I'll think about it and will give you my feedback on this as soon as possible. Cheers Stéphane -- Stéphane Laurière XWiki – https://xwiki.com

Fawad, I would say that typical users will want to choose between displaying information in a popup or over the search results panel, depending on the user experience they prefer and the amount of information they want to display. Typically, Google Maps and the Airbnb map have two different approaches with this respect, and it would be a plus imho to implement the two. Airbnb maps display popups, they are small indeed, but the image slider lets the user obtain a significant amount of information. For displaying more information like hotel schedule, ratings, comments, it's clear that a bigger panel is useful, like what Google Maps is proposing. I would go for small popups to start with (version 1.0), with a link to the underlying XWiki page indeed. Later on, if time permits depending on the priorities we decide, we could implement 1) a dynamic "more information widget" that enlarges the popup dynamically, 2) a different interaction mechanism that is similar to the Google Maps one. Let's add these features as issues in Jira and refine the roadmap while defining the upcoming versions, what do you think? It will become a map item indeed, however, let's look closer at what Airbnb is proposing: they typically manage three sheets: - One for the item page when displayed individually, for example: https://up1.xwikisas.com/#0EcYpY5TQvlCAKuWP3AYIw - One for displaying the item in a list: https://up1.xwikisas.com/#yYiN8KfeKuy1BqibkgSkAA - One for displaying the same item in a popup: same link, right side A customized class sheet would typically get used for the first display as you envision it, but for the two others, which would be useful for advanced maps imho, I was considering we could implement a built-in mechanism allowing easy customization. Ok great, looking forward to testing the new version Cheers Stéphane

Hi all, For the release of the application, in addition to the issues I have fixed so far, I will make the popups smaller and possibly shift the search control to a better location. Is there anything else that you feel is important for the first release? If there is please let me know. Although I will be working on the known issues and other suggestions put forward by Stephane after the release. I feel like it's important that we bring the application to the users soon so there opinions can be gathered for user oriented development in the future. I will also prepare the complete documentation over the weekend if I can. Thank you for all the support and suggestions so far. Especially Stephane. Best, Fawad On Fri, Jul 12, 2019 at 4:07 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

Hi all, Hope you are doing wonderful today. I am very excited to announce that Interaction Maps Application v1.0 is now up. Extension and documentation: https://extensions.xwiki.org/xwiki/bin/view/Extension/InteractiveMapsApplic… Forum post: https://forum.xwiki.org/t/interactive-maps-application-v1-0-released/ Thanks to Thomas for helping with issues in the release; Stephane for all the wonderful and detailed instructions; Ecaterina for all the great help and ideas; Vincent for helping with tests and other issues; and everyone else who helped with the project. It has been a wonderful experience so far to work with the XWiki community! I look forward to how the complete application will turn out. Best, Fawad On Tue, Jul 16, 2019 at 1:31 PM Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; wrote:

Well done Fawad, congrats! A very small detail: we’re strying to have the same styles for images on xwiki.org and we have some guidelines linked from https://contrib.xwiki.org/xwiki/bin/view/Main/WebHome#HDocumenting For example for images here are the best practices: https://dev.xwiki.org/xwiki/bin/view/Community/DocGuide#HScreenshots2FImages So it would be awesome if you could use the {{image}} macro. Thanks -Vincent

Hi Fawad, Hi all, I just commented on this at https://jira.xwiki.org/browse/INTMAP-27 That sounds great to use the same syntax as the Solr one indeed. +1 for removing "_en" since the app could be used in wikis where English is not enabled. I don't have further suggestion on my end so far... Great, I commented also at https://jira.xwiki.org/browse/INTMAP-27 as you probably noticed, Cheers Stéphane -- Stéphane Laurière XWiki – https://xwiki.com

Hi Fawad, I would go for approach C as well, that is storing all shape data entirely in json, since most probably the shapes will either by imported directly from preexisting data in json or any equivalent, or drawn by hand on a map. I see no real use case yet for an intermediary input where part of the data would be entered via a form, then by hand. Query-wise, I don't think we will need to retrieve a huge quantity of shapes with any given property value that would need to break down some specific values into dedicated properties. In case we do some day, we could either build a dedicated index I would say, or fill in dedicated properties automatically from the json input via a listener. Cheers, Stéphane

Hi Fawad, Thanks for the update. I had a look at the ShapeClass and I have a remark about their structure. I see you introduced the properties "points", "type". I'm wondering whether we could simply consider that the shapes are entirely represented in GeoJSON, including the style options, just like http://geojson.io/ behaves, eg in the example below. What would be the use case for storing these properties separately? I thought your previous question were about that, sorry for the misunderstanding. Regarding the editors: good to see there's the point editor (I had not tried it yet), I have some remarks about it: - What about setting it up by default for the PointClass objects, so that these points can be edited using the editor, by creating a PointSheet that uses it? - We could introduce a TemplateProvider for points, so that creating points can be achieved using the standard XWiki create page, what do you think? - What's the rationale for storing the editors in a dedicated space? I would either put all them in the Code space directly, or in a subspace if you really want to group them (I tend to avoid having too many nested spaces but that's a personal taste only). I may have other remarks that I will bring up directly on Jira if that's ok with you. It's good to read that you already have in mind indoor maps as it's a promising feature imho, on the other hand I'd say there could be also much value in improving the current features, I need to get my head around that and to review the current issues. I will do so by tomorrow, then we could set up a call at the end of the day, if possible for you, or on Monday. What about 3pm UTC tomorrow? Or Monday 3pm UTC? Cheers Stéphane { "type": "Feature", "properties": { "stroke": "#c5ce00", "stroke-width": 2, "stroke-opacity": 1, "fill": "#c13d3d", "fill-opacity": 0.5 }, "geometry": { "type": "Polygon", "coordinates": [ [ [ 148.7109375, 54.36775852406841 ], [ 146.95312499999997, 54.16243396806779 ], [ 170.5078125, 6.664607562172573 ], [ 216.2109375, 40.17887331434696 ], [ 198.98437499999997, 76.01609366420995 ], [ 148.7109375, 54.36775852406841 ] ] ] } } Stéphane Laurière XWiki – https://xwiki.com

Stéphane, I agree that GeoJSON would be a much portable and standard option. I went with the structure I implemented because I was directly working with leaflet docs. I have one concern though and that is the flexibility of GeoJSON. By flexibility I mean that it will be harder for XWiki users to get used to the GeoJSON as opposed to the "points" and "options" properties of ShapeClass. Nonetheless, I am going with the GeoJSON now. Best, Fawad On Thu, Aug 1, 2019 at 11:37 PM Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; wrote:

Stéphane, Ecaterina, About the call, I think we should have it so that we all converge on the things to be done. However, tomorrow (Friday), I have a call with the Pakistan's GSoC community at about 5 PM UTC. If the call will be finished in two hours I am fine with it or we could reschedule it to 2:30 PM UTC or else Monday. Best, Fawad On Thu, Aug 1, 2019 at 11:58 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

Fawad, I created the museum-map-test branch in order to progress on this path, I hope this helps. In particular, imho, facets will be provided typically by objects from different classes than the geographical ones, such as a the Museum class (which very basic for now, it's just to expose the idea). My suggestion would be to progress toward an application that works well with a single sample facet + a full text input field + popups indeed + list + configurable icons and colors (typically one per facet value, I would say, so as for instance to represent all archeologia museums in a given color - even though we don't have that data yet, but we could use the countries all the same), and in parallel to gather more sample data with more facets and to progress toward having several configurable facets, what do you think? Great Cheers Stéphane

Hi all, Hoping you a great week-end. I am having trouble testing my application because of some dependencies. This is the POM: https://github.com/xwiki-contrib/application-interactive-maps/blob/master/a… Some of the leaflet dependencies are not being installed during testing. I am not sure why. When I open a page that uses leaflet libraries I get an error from requirejs that the library cannot be loaded. And there is no data when I go to the url generated by $services.webjars.url() which leads me to believe that the dependency is not being installed as an extension. If I manually install the dependencies into my Wiki then it works fine. Do you think there is something missing within the POM? Best, Fawad On Fri, Aug 23, 2019 at 2:42 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

Hi Ecaterina, Good to see you, hope you are doing well. Do you mean "org.webjars.bowergithub.9inpachi"? This is deployed on http://webjars.org I am not sure what could be wrong here. Even the leaflet dependency is not being installed in the latest tests. After installing Extension Manager Application into the test XWiki instance, I found that for Interactive Maps Application, the leaflet dependencies were labeled as "Provided" as opposed to "Installed" for other dependencies. The tests started failing around this commit https://github.com/xwiki-contrib/application-interactive-maps/commit/e3163a… I added leaflet-indoor.js as an attachment temporarily while I was waiting for the one deployed on webjars.org to function properly. I did remove it later on and added as a dependency but that doesn't seem to have solved the problem. I feel like this is some issue with the test itself and since I haven't made any changes to the test, the test frameworks might have been updated. I don't really know the cause since all was working fine before this. Best, Fawad On Sun, Aug 25, 2019 at 1:39 AM Ecaterina Moraru (Valica) &lt;valicac(a)gmail.com&gt; wrote:

Fawad, can you make sure you've released the application on Contrib? I don't see a new version on GitHub or on e.x.o. Thanks, Caty On Sun, Aug 25, 2019 at 9:41 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

Hi Caty, Fawad, all, There's been much progress on the app recently by Fawad, that's great, I spotted a few issues that are likely to block the release indeed, not many, most of the entries I created on Jira today are improvement suggestions for upcoming releases. The three key ones imho are: - JavaScript instability on map at Demo.WebHome https://jira.xwiki.org/browse/INTMAP-76 – In case this is too long to fix, I'd suggest we remove the indoor feature from the demo for the release itself, so that we get a 100% working demo, what do you think? Obviously fixing it would be even better, let me know if you need help Fawad. - Leaflet configuration issue on installation https://jira.xwiki.org/browse/INTMAP-74 – Removing the version number seems to work fine with all recent XWiki versions and matches the WebjarScriptService documentation, to be tested further, and we will need to investigate what fails with the continuous integration, but not a blocker issue imho. - JSON format errors on map at Demo.WebHome https://jira.xwiki.org/browse/INTMAP-75 Fixing the overflow issue would be nice as well since it would enhance the first live contact of the user with the app: https://jira.xwiki.org/browse/INTMAP-85 – Unsetting the "overflow" rule of #xwikicontent fixes the issue but may introduce others. The Mozilla documentation page https://developer.mozilla.org/en-US/docs/Web/CSS/overflow states that "overflow" is useful only when a height is set or "white-space" set to "nowrap". I'm wondering in which cases the height of #xwikicontent needs to be set, or the "white-space" option. Do you have any idea Caty, all? Cheers Stéphane Fawad Ali:

Hi Stephane, Ecaterina and all, I will try solving the key issues as soon as possible so we can move on with the release. It might take some time because my summer break is over and the University opens tomorrow. But I will make sure all of these are done soon. Best, Fawad On Sun, Sep 1, 2019 at 7:54 PM Ecaterina Moraru (Valica) &lt;valicac(a)gmail.com&gt; wrote:

Caty, Fawad, all, Indeed, it'd be a cool achievement. Sure, we don't want to remove the overflow, I was just wondering about its exact role. I'm convinced it's there for a good reason. I also agree with you the issue is minor. Thanks for your suggestion about clearing the float, I gave it a try with no luck so far but I'm for from having a deep understanding of CSS, just a humble admirer Chees Stéphane

Hi Fawad, Thank you also for your hard work and I'm glad you had a nice time during GSOC. Thanks also for providing some status and I will be waiting to install the latest version and see the feedback the others community members will have. Caty On Tue, Sep 3, 2019 at 9:28 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote:

Hi all, All the key issues pointed out by Stephane are fixed. Should we move on to release the application? Best, Fawad On Wed, Sep 4, 2019 at 1:39 PM Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; wrote:

Hi Fawad, Caty, hi all, I tested the latest version on my side and the fix work fine with me as well, that's cool, so Fawad I'd say also that you can go ahead with the release indeed. Cheers Stéphane Ecaterina Moraru (Valica):

On Fri, Aug 23, 2019, 11:52 Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; wrote: Hi, Fawad should follow the instructions given by Google, since they aldo need copies / links to the produced code. Regarding XWiki's expectations, having the code public available on GitHub and released on Contrib / extensions.xwiki.org is enought. Thanks, Caty