Hi,
On 12 Jun 2019, at 20:46, Vincent Massol <[email protected]> wrote:
Hi Fawad,
On 12 Jun 2019, at 18:37, Fawad Ali <[email protected]> wrote:
[snip]
I took a look at the application-releasenotes and what I understand is that there are sample demo pages instead of functional tests.
This is not 100% correct. There are both, and the demo pages are used in the functional tests.
* Demo pages: https://github.com/xwiki-contrib/application-releasenotes/tree/master/applic... * Func tests: https://github.com/xwiki-contrib/application-releasenotes/tree/master/applic... * Demo dep in the func test module: https://github.com/xwiki-contrib/application-releasenotes/blob/master/applic...
Just realized that the release notes app is a bad example since it currently doesn’t contain any func test! They’re missing and a TODO. You could check other app like the FAQ app for an example of a func test. Sorry about that. Thanks -Vincent
Thanks -Vincent
I personally think our Interactive Maps Application aligns well with that approach and we can have the same type of tests/demos. WDYT?
I would start preparing for a release for now and implement the tests once we have coordinated on how we do it.
Best, Fawad
On Fri, Jun 7, 2019 at 10:29 PM Vincent Massol <[email protected]> wrote:
Hi,
On 7 Jun 2019, at 18:59, Stéphane Laurière <[email protected]> wrote:
Fawad, Caty, all,
I have a short comment about the tests:
Hi Caty, Thanks for the review. Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space is duplicated This space exists only for testing. It won't be there for the real application. I named them so that its easier to know which type of object pages are located in them (for myself). MapTesting, Maps, Points - spaces don't have homepages. The users will navigate to them, since they are present in breadcrumb. So what is the plan? Simpler paths? or create Homepages for these types of entry? Since we are in the beta stage now, the whole MapTesting space exists for testing for developers. It would not be there once we have a stable version ready for release.
Actually this raises a question, all the more as we also discussed the importance of having automated functional tests earlier today on #xwiki with Vincent. For automated testing, we will need sample data, and I'm wondering where we should store this sample data (and possible scripts or code for obtaining it). How do other projects deal with test data in such a context? Is the test data stored in the same repository or in a distinct one? I was looking for some Solr application test data but could not find it yet. Note that we may consider the testing area as a set of demos instead in some way, couldn't we? It would make sense to keep it (just like if it's real test data), and to provide a navigation across these pages as you suggest it, Caty.
For the Release Notes app, I also have some data for the tests. See the demo module in https://github.com/xwiki-contrib/application-releasenotes
Thanks -Vincent
Cheers
Stéphane
Lots of pages that are not hidden. All technical pages needs to be
hidden.
Again, these pages are not technical and exist only for testing purposes. A bit confusing that there are 2 search boxes for the maps, see https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA Yes, thanks for pointing out. We need to move the search function directly inside the map. I will look into it once I am done with the facets.
For the search input, its in extremely beta stage. I am still trying to figure out the macros I have borrowed from SolrSearchMacros. So it will take time for me to make a more stable version of the facets. I hope I can do that in due time. :) Regarding the facets, we need some more user friendly translations and customizations for this kind of UI, see https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw As discussed earlier with Stephane, we are still having issues using the normal $facetDisplayer so we are using a workaround for testing purposes that's why it looks like this. More precisely, we are using the #displaySearchFacetValues($facetValues) macro for now. Best, Fawad