[xwiki-devs] [VOTE] Remove automatic plugin reinit when XWikiPreference is modified
Hi dev, Currently each time you modify XWikiPreference all the plugin are reloaded and reinitialized. This is very bad so I would like to remove this. Also this is done only when not in vistual mode (what the...). If either a plugin cache something coming from XWikiPreference it should register to event itself and update its cache when needed. I don't know any plugin which actually count on this "feature". My proposal is to simply remove this code which is useless and does not even work in virtual mode anyway. WDYT ? Here is my +1 -- Thomas Mortagne
Forget that it's actually only answering to plugin property in XWikiPreference. I will refactor this code to use new event system instead which is more clear. On Thu, Jun 16, 2011 at 18:33, Thomas Mortagne <[email protected]> wrote:
Hi dev,
Currently each time you modify XWikiPreference all the plugin are reloaded and reinitialized. This is very bad so I would like to remove this. Also this is done only when not in vistual mode (what the...).
If either a plugin cache something coming from XWikiPreference it should register to event itself and update its cache when needed.
I don't know any plugin which actually count on this "feature".
My proposal is to simply remove this code which is useless and does not even work in virtual mode anyway.
WDYT ?
Here is my +1
-- Thomas Mortagne
-- Thomas Mortagne
On 06/16/2011 06:33 PM, Thomas Mortagne wrote:
Hi dev,
Currently each time you modify XWikiPreference all the plugin are reloaded and reinitialized. This is very bad so I would like to remove this. Also this is done only when not in vistual mode (what the...).
If either a plugin cache something coming from XWikiPreference it should register to event itself and update its cache when needed.
I don't know any plugin which actually count on this "feature".
My proposal is to simply remove this code which is useless and does not even work in virtual mode anyway.
WDYT ?
+0; plugins are on their way out anyway, I don't see this is an important fix, but I agree with it. -- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (2)
-
Sergiu Dumitriu -
Thomas Mortagne