[xwiki-devs] [VOTE] Make checkstyle support clone() method implementation which does not call super.clone()
Hi devs, We have some use case where we don't need/want to call super.clone() in clone: the non modifiable Block like SpaceBlock that should always return the same static unique instance. Also checkstyle does not see when clone() actually call super.clone() but indirectly, using another method which call super.clone(). See AbstractBlock class for example. So I would like to comment this rule out of checkstyle configuration file in the XWiki verification maven plugin. WDYT ? (Note: the modification is already committed, i will revert it if some is against it.) Here is my +1 -- Thomas Mortagne
Thomas Mortagne wrote:
Hi devs,
We have some use case where we don't need/want to call super.clone() in clone: the non modifiable Block like SpaceBlock that should always return the same static unique instance.
Also checkstyle does not see when clone() actually call super.clone() but indirectly, using another method which call super.clone(). See AbstractBlock class for example.
So I would like to comment this rule out of checkstyle configuration file in the XWiki verification maven plugin.
WDYT ?
(Note: the modification is already committed, i will revert it if some is against it.)
Here is my +1
+1 -- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (2)
-
Sergiu Dumitriu -
Thomas Mortagne