On Mar 15, 2011, at 12:23 PM, Paul Libbrecht wrote:
Le 15 mars 2011 à 12:07, Vincent Massol a écrit :
Thanks for the suggestion, done at: http://extensions.xwiki.org/xwiki/bin/view/Extension/Caching-Headers
which you moved to:
http://extensions.xwiki.org/xwiki/bin/view/Extension/Add+Caching+Headers
I am not sure this a good idea since "Adding" is precisely what it was doing inefficiently before the bug is addressed, moreover this snippets does not add any new header, it changes headers that were already output saying to not cache. I would prefer Caching-Headers (or Caching+Headers or...).
Well I aligned it with the "rule" we've used for naming extensions and scripts which is: * Words separated by spaces * Mention action for scripts The idea is when you look at http://extensions.xwiki.org/xwiki/bin/view/Main/ you get some understanding about what the snippet does. We can rename to Set Caching Headers or Adjust Caching Headers or Set/Add/Adjust Cache Headers (not sure we need the -ing ending).
Shall I move it again? I realize I need to adjust wording again for it though.
Thanks. The title says: "a simple example of exposing correct caching headers" Which suggests that the default way xwiki does it is wrong and this is a patch.
That is my feeling but there's a rationale behind both approaches. I have now commented on the default policy of xwiki (which guarantees the best dynamicity).
Thanks! I'm going to add other options on that page: * Rendering cache * Cache macro Thanks -Vincent
paul
Could you explain more in the snippet when someone would use this snippet vs not doing anything (ie do what XWiki provides by default)?