Re: [xwiki-users] Re stricting Images
I don't understand the need for this in the platform since it looks to me a bit too specific a need (unless I don't understand something). I'd rather we have something more generic that encompasses this use case. I may be mistaken though.
I agree that this might be a tad too specific to implement as a core feature. But the extension point for radeox plugins (e.g. ImageMacro) could be improved. I implemented my ImageMacro in the com.xpn.xwiki.render.macro package and copied the class file into the WEB-INF/classes directory to make sure the classloader picks *my* class. Alternatively, I could have edited the META-INF/services/com.xpn.xwiki.render.macro.XWikiMacro file inside the xwiki core jar file. Neither are elegant ways of extending the ImageMacro (in my case to support custom privileges). The most beautiful extension point would be a property in xwiki.cfg that lists the (custom) radeox plugin classes so users can disable/extend/override/add certain plugins. I believe this could be easily implemented inside the com.xpn.xwiki.render.macro.MacroRepository class.
On Jan 12, 2008, at 12:31 AM, Josef Pfleger wrote:
I don't understand the need for this in the platform since it looks to me a bit too specific a need (unless I don't understand something). I'd rather we have something more generic that encompasses this use case. I may be mistaken though.
I agree that this might be a tad too specific to implement as a core feature. But the extension point for radeox plugins (e.g. ImageMacro) could be improved.
Oh definitely. I'm working on the next generation xwiki rendering engine and macros will be very easy to add on. All you'll need is to drop a jar in your WEB-INF/lib and thats all! No need to even define it in a config file. Thanks -Vincent
I implemented my ImageMacro in the com.xpn.xwiki.render.macro package and copied the class file into the WEB-INF/classes directory to make sure the classloader picks *my* class. Alternatively, I could have edited the META-INF/services/com.xpn.xwiki.render.macro.XWikiMacro file inside the xwiki core jar file. Neither are elegant ways of extending the ImageMacro (in my case to support custom privileges).
The most beautiful extension point would be a property in xwiki.cfg that lists the (custom) radeox plugin classes so users can disable/extend/override/add certain plugins. I believe this could be easily implemented inside the com.xpn.xwiki.render.macro.MacroRepository class.
participants (2)
-
Josef Pfleger -
Vincent Massol