September 2026 - notifications

[xwiki/xwiki-platform] 8e9d7d: [Misc] Fix various SonarQube issues
by XWiki Notifications 02 Sep '26

02 Sep '26

Branch: refs/heads/claude/clever-feynman-06p27o Home: https://github.com/xwiki/xwiki-platform Commit: 8e9d7df795c6aaa666e7ea7199dece970445db3a https://github.com/xwiki/xwiki-platform/commit/8e9d7df795c6aaa666e7ea7199de… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-reference/src/test/java/org/xwiki/annotation/reference/internal/AbstractTypedStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-jcaptcha/xwiki-platform-captcha-jcaptcha-api/src/main/java/org/xwiki/captcha/internal/JCaptchaCaptcha.java M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/DefaultCSRFTokenTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/test/java/org/xwiki/eventstream/internal/DefaultUntypedRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/FeedPlugin.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/legacy/LegacyEventDispatcher.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/org/xwiki/legacy/internal/oldcore/notification/LegacyNotificationDispatcher.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/ActionExecutionEventConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/PackageException.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiGroupServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/template/InternalTemplateManagerTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/XWikiRepositoryModel.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/ModelFactory.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/resources/pages/PageTagsResourceImpl.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/test/java/org/xwiki/rest/internal/resources/classes/ClassPropertyValuesResourceImplTest.java Log Message: ----------- [Misc] Fix various SonarQube issues * java:S3599 replace double-brace initialization with a plain collection copy * java:S4838 iterate with the collection's own element type * java:S9016 extract nested mock creations into local variables * java:S5778 hoist the non-throwing calls out of the assertThrows lambdas * java:S1121 extract the assignments out of the substring() arguments * java:S1710 drop the @Extensions wrapper around a single annotation * java:S2676 swap the operands instead of negating compareTo() * java:S1171 make the initializer static, it only fills a static field * java:S115 rename two private test constants to CONSTANT_CASE * java:S1165 make the exception field final, and rename it so that adding "final" does not just trade the issue for a java:S115 on the same line Co-Authored-By: Vincent Massol <vincent(a)massol.net> Co-Authored-By: Claude Opus 5 <noreply(a)anthropic.com> Claude-Session: https://claude.ai/code/session_015Hg3cGVDYpa9k8oLnt5azJ To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-rendering] ef9a77: [Misc] Keep the XML spec's supplementary range doc...
by XWiki Notifications 02 Sep '26

02 Sep '26

Branch: refs/heads/claude/peaceful-archimedes-06p27o Home: https://github.com/xwiki/xwiki-rendering Commit: ef9a77b8147cfab8f5e5a835f3c8c34f241c177b https://github.com/xwiki/xwiki-rendering/commit/ef9a77b8147cfab8f5e5a835f3c… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/WikiPageUtil.java Log Message: ----------- [Misc] Keep the XML spec's supplementary range documented in a comment Answers the objection that deleting the dead range hides the NameStartChar production's supplementary-plane row: it is now stated in a comment, together with why it cannot be tested against a char. Co-Authored-By: Vincent Massol <vincent(a)massol.net> Co-Authored-By: Claude Opus 5 <noreply(a)anthropic.com> Claude-Session: https://claude.ai/code/session_015Hg3cGVDYpa9k8oLnt5azJ To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-commons] b2b082: [Misc] Drop two SonarQube fixes that change behavi...
by XWiki Notifications 02 Sep '26

02 Sep '26

Branch: refs/heads/claude/nifty-bell-06p27o Home: https://github.com/xwiki/xwiki-commons Commit: b2b082f86f111338fa4efe2666380765eb32529b https://github.com/xwiki/xwiki-commons/commit/b2b082f86f111338fa4efe2666380… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M xwiki-commons-core/xwiki-commons-cache/xwiki-commons-cache-infinispan/src/main/java/org/xwiki/cache/infinispan/internal/InfinispanCacheFactory.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/main/java/org/xwiki/logging/LogUtils.java Log Message: ----------- [Misc] Drop two SonarQube fixes that change behaviour or readability * java:S2093 InfinispanCacheFactory: IOUtils.closeQuietly() deliberately swallows a close failure while try-with-resources surfaces it, so the conversion is not behaviour-preserving * java:S3012 LogUtils: the loop appends a suffix of the array, and every bulk replacement needs a guard that reads worse than the loop it replaces Co-Authored-By: Vincent Massol <vincent(a)massol.net> Co-Authored-By: Claude Opus 5 <noreply(a)anthropic.com> Claude-Session: https://claude.ai/code/session_015Hg3cGVDYpa9k8oLnt5azJ To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-rendering] 778a78: [Misc] Fix SonarQube issues by dropping a comparis...
by XWiki Notifications 02 Sep '26

02 Sep '26

Branch: refs/heads/claude/peaceful-archimedes-06p27o Home: https://github.com/xwiki/xwiki-rendering Commit: 778a7843a44f7e5408fea278b319054f36defc83 https://github.com/xwiki/xwiki-rendering/commit/778a7843a44f7e5408fea278b31… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/WikiPageUtil.java Log Message: ----------- [Misc] Fix SonarQube issues by dropping a comparison that can never hold * java:S2198 "ch" is a char, so it can never reach 0x10000 Co-Authored-By: Vincent Massol <vincent(a)massol.net> Co-Authored-By: Claude Opus 5 <noreply(a)anthropic.com> Claude-Session: https://claude.ai/code/session_015Hg3cGVDYpa9k8oLnt5azJ To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-commons] 8727a6: [Misc] Fix various SonarQube issues
by XWiki Notifications 02 Sep '26

02 Sep '26

Branch: refs/heads/claude/nifty-bell-06p27o Home: https://github.com/xwiki/xwiki-commons Commit: 8727a6d9f1008e60135a38e00e828e76dd584574 https://github.com/xwiki/xwiki-commons/commit/8727a6d9f1008e60135a38e00e828… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M xwiki-commons-core/xwiki-commons-cache/xwiki-commons-cache-infinispan/src/main/java/org/xwiki/cache/infinispan/internal/InfinispanCacheFactory.java M xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-default/src/test/java/org/xwiki/component/guice/GuiceCompatibilityTest.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/DefaultExtensionSerializer.java M xwiki-commons-core/xwiki-commons-legacy/xwiki-commons-legacy-classloader/xwiki-commons-legacy-classloader-api/src/main/java/org/xwiki/classloader/internal/ResourceLoader.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/main/java/org/xwiki/logging/LogUtils.java M xwiki-commons-tools/xwiki-commons-tool-extension-plugin/src/main/java/org/xwiki/tool/extension/util/ExtensionMojoHelper.java Log Message: ----------- [Misc] Fix various SonarQube issues * java:S2093 use a try-with-resources where the finally really closes the stream * java:S3012 copy the remaining arguments with a bulk operation * java:S1171 replace the instance initializer with a constructor * java:S119 rename a type parameter that was named "String" * java:S1186 document why two method bodies are empty Co-Authored-By: Vincent Massol <vincent(a)massol.net> Co-Authored-By: Claude Opus 5 <noreply(a)anthropic.com> Claude-Session: https://claude.ai/code/session_015Hg3cGVDYpa9k8oLnt5azJ To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24778: Document cache entries collide across wikis when the context wiki differs from the document's wiki
by XWiki Notifications 01 Sep '26

01 Sep '26

1 0

[[email protected]][Issue] Updates for XWIKI-24720: ImageStyleIT#imageStyleAdministration is flickering
by XWiki Notifications 01 Sep '26

01 Sep '26

1 0

[[email protected]][Issue] Updates for XWIKI-21734: LightboxIT.disabledLightbox is flickering
by XWiki Notifications 01 Sep '26

01 Sep '26

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Sep '26

01 Sep '26

Branch: refs/heads/XWIKI-21734 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] ed1082: XWIKI-21734: LightboxIT.disabledLightbox is flicke...
by XWiki Notifications 01 Sep '26

01 Sep '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: ed10820f925314e51b19b7cd98af2a894349b1c4 https://github.com/xwiki/xwiki-platform/commit/ed10820f925314e51b19b7cd98af… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-01 (Tue, 01 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-lightbox/xwiki-platform-image-lightbox-test/xwiki-platform-image-lightbox-test-docker/src/test/it/org/xwiki/image/lightbox/test/ui/LightboxIT.java M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-lightbox/xwiki-platform-image-lightbox-test/xwiki-platform-image-lightbox-test-pageobjects/src/main/java/org/xwiki/image/lightbox/test/po/LightboxPage.java Log Message: ----------- XWIKI-21734: LightboxIT.disabledLightbox is flickering (#6278) * The test failed because the popover did appear: the page had been rendered with the lightbox enabled although the test had just set isLightboxEnabled to 0. It is the first test of the class and it runs shortly after the test extensions, which ship the configuration document, have been provisioned, so a copy of that document read while the save was running can outlive it in the document cache and keep the previous value in effect for the whole test. * Make enableLightbox() verify that the new value is the one page renders see, on the page the save action already lands on, and save again when it is not, since saving the document again is what drops the stale copy. Fail with an explicit message rather than let a later assertion report a misleading symptom. * Add LightboxPage.isLightboxEnabled(), which tells whether the displayed page was rendered with the lightbox, from the configuration script the UI extension only emits when it is enabled. * Assert that precondition in disabledLightbox: not finding a popover only means the lightbox is disabled if the page was rendered without it. Co-authored-by: Vincent Massol <vincent.massol(a)xwiki.com> Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0