- notifications - lists.xwiki.org

[xwiki/xwiki-platform] e0662c: [Misc] Fix sonarqube-reported issues that block th...
by XWiki Notifications 26 Jul '26

26 Jul '26

Branch: refs/heads/backport/stable-17.10.x/sonar-qualitygate-npe Home: https://github.com/xwiki/xwiki-platform Commit: e0662cfe0a00b62808cc30ef195eba48ded39043 https://github.com/xwiki/xwiki-platform/commit/e0662cfe0a00b62808cc30ef195e… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-api/src/main/java/org/xwiki/livedata/internal/DefaultLiveDataConfigurationResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-async/xwiki-platform-rendering-async-default/src/main/java/org/xwiki/rendering/async/internal/AsyncRendererCacheListener.java M xwiki-platform-core/xwiki-platform-scheduler/xwiki-platform-scheduler-api/src/main/java/com/xpn/xwiki/plugin/scheduler/SchedulerPlugin.java Log Message: ----------- [Misc] Fix sonarqube-reported issues that block the quality gate The three JavaScript files touched by the original commit (attachments.js, locationPicker.js, upload.js) are left out: on this branch they still use the pre-ES6 Prototype.js form, so the lines the original commit rewrote either do not exist here or sit in a differently-shaped function. Their changes are cosmetic rule cleanups (parseInt -> Number.parseInt, replace -> replaceAll) that do not affect this branch's quality gate. Use the "status" literal instead of the STATUS constant in SchedulerPlugin, which this branch does not declare. (cherry picked from commit 630fe598748109ba75f6de268c972ad08c5c3ce3) Commit: 73cb7158262296e3150649272fc7a50bb2575d7f https://github.com/xwiki/xwiki-platform/commit/73cb7158262296e3150649272fc7… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/main/java/org/xwiki/wysiwyg/script/WysiwygEditorScriptService.java Log Message: ----------- [Misc] Fix additional SonarQube-reported NPE risks blocking the quality gate * FileSystemURLFactory: instead of null-checking the file mapping at each call site, make getFileMapping() lazily create and store the mapping in the context, so it's always non-null and callers' mutations still persist. * WysiwygEditorScriptService: handle the null source reference in a single place (the 4-arg overload) rather than short-circuiting in the deprecated 2-arg overload. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply(a)anthropic.com> (cherry picked from commit d33553c3cc47461cb9fc0d3a95b6b2369667c562) Commit: 9e2d508692f22a119d165572b69bcd8c62c36d32 https://github.com/xwiki/xwiki-platform/commit/9e2d508692f22a119d165572b69b… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java Log Message: ----------- [Misc] Fix remaining SonarQube-reported NPE risks blocking the quality gate * copyAttachment: getXWikiContext() can return null, so reuse the captured context and guard the author reference lookup instead of dereferencing a possibly-null context a second time. * backupContext: require a non-null context up front, since all the data backed up below is read from it. * Annotate getXWikiContext() with @Nullable to document that it can return null (which is what makes the direct dereferences above unsafe). (cherry picked from commit de737018e980d44e177dcf801c5e13d2239a2ba5) Compare: https://github.com/xwiki/xwiki-platform/compare/e0662cfe0a00%5E...9e2d50869… To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 213dd3: [Misc] Fix a NullPointerException reported by Sona...
by XWiki Notifications 26 Jul '26

26 Jul '26

Branch: refs/heads/sonar-npe-parsetemplate-skin Home: https://github.com/xwiki/xwiki-platform Commit: 213dd37165bccc924b6ee9ae121835b58f822bec https://github.com/xwiki/xwiki-platform/commit/213dd37165bccc924b6ee9ae1218… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java Log Message: ----------- [Misc] Fix a NullPointerException reported by SonarQube in XWiki#parseTemplate() * getMutableRenderingContext() returns null when the rendering context is not mutable, so guard both the forcing of the XHTML 1.0 target syntax and its restoration instead of dereferencing it unconditionally. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-commons] a19eb1: [Misc] Remove useless assignments to local variabl...
by XWiki Notifications 26 Jul '26

26 Jul '26

Branch: refs/heads/sonarqube-fixes Home: https://github.com/xwiki/xwiki-commons Commit: a19eb1ca9dc0765dc0131520a8f2363c11fdd15d https://github.com/xwiki/xwiki-commons/commit/a19eb1ca9dc0765dc0131520a8f23… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-cipher/src/test/java/org/xwiki/crypto/cipher/internal/symmetric/factory/AbstractSymmetricCipherFactoryTest.java M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-pkix/src/test/java/org/xwiki/crypto/signer/internal/cms/DefaultCMSSignedDataTest.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-api/src/test/java/org/xwiki/filter/internal/AbstractFilterDescriptorManagerTest.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/test/Utils.java Log Message: ----------- [Misc] Remove useless assignments to local variables (SonarQube java:S1854) * Dead stores reported by SonarCloud; side-effecting calls kept as plain statements. Commit: 90901fd2ef2e983806da81bc16114e7e5dce2b02 https://github.com/xwiki/xwiki-commons/commit/90901fd2ef2e983806da81bc16114… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/src/test/java/org/xwiki/crypto/internal/encoder/Base64BinaryStringEncoderTest.java M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/src/test/java/org/xwiki/crypto/internal/encoder/HexBinaryStringEncoderTest.java M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/src/test/java/org/xwiki/crypto/internal/encoder/UrlBase64BinaryStringEncoderTest.java Log Message: ----------- [Misc] Replace string concatenations with text blocks in encoder tests (SonarQube java:S6126) Commit: d1ea24d5768a7153dd5cf6a8d19630cdb038bb83 https://github.com/xwiki/xwiki-commons/commit/d1ea24d5768a7153dd5cf6a8d1963… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/event/LogEventTest.java M xwiki-commons-core/xwiki-commons-store/xwiki-commons-store-blob/xwiki-commons-store-blob-filesystem/src/test/java/org/xwiki/store/blob/internal/FileSystemBlobStoreTest.java Log Message: ----------- [Misc] Fix expected/actual argument order in assertions (SonarQube java:S3415) Commit: e320dbb92a84e28a026e26703c40aac6af146cdb https://github.com/xwiki/xwiki-commons/commit/e320dbb92a84e28a026e26703c40a… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/marker/TranslationMarkerTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/event/ActionExecutionEventTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/event/CancelableEventTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/filter/AlwaysMatchingEventFilterTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/filter/FixedNameEventFilterTest.java M xwiki-commons-core/xwiki-commons-store/xwiki-commons-store-blob/xwiki-commons-store-blob-api/src/test/java/org/xwiki/store/blob/BlobRangeOptionTest.java Log Message: ----------- [Misc] Use assertEquals/assertNotEquals instead of assertTrue/assertFalse with equals() (SonarQube java:S5785) Commit: ea8c42a09e4efe7006017b9f69d0ebf2587d54a1 https://github.com/xwiki/xwiki-commons/commit/ea8c42a09e4efe7006017b9f69d0e… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/test/ExtensionPackager.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/test/FileExtensionRepository.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-test/src/main/java/org/xwiki/filter/test/integration/TestDataParser.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-test/src/main/java/org/xwiki/filter/test/internal/ZIPFileAssertComparator.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-common/src/main/java/org/xwiki/logging/internal/tail/AbstractFileLoggerTail.java Log Message: ----------- [Misc] Use try-with-resources where semantics are preserved (SonarQube java:S2093) * AbstractFileLoggerTail: extracted the read block into a private helper holding the try-with-resources (checkstyle NestedTryDepth); close order and error path unchanged. Compare: https://github.com/xwiki/xwiki-commons/compare/a19eb1ca9dc0%5E...ea8c42a09e… To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-rendering] f65a18: XRENDERING-809: MacroDescriptor legacy getDefaultC...
by XWiki Notifications 26 Jul '26

26 Jul '26

Branch: refs/heads/stable-18.4.x Home: https://github.com/xwiki/xwiki-rendering Commit: f65a18348a6ef7888ed954f8e967c729889dea8b https://github.com/xwiki/xwiki-rendering/commit/f65a18348a6ef7888ed954f8e96… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-rendering-legacy/xwiki-rendering-legacy-transformations/xwiki-rendering-legacy-transformation-macro/pom.xml Log Message: ----------- XRENDERING-809: MacroDescriptor legacy getDefaultCategory() aspect is never weaved * Ignore in Revapi the @Around pointcut change of aroundGetDefaultCategory(), reported as an annotation attribute value change on the public aspect method. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-rendering] 1d7cb1: XRENDERING-809: MacroDescriptor legacy getDefaultC...
by XWiki Notifications 26 Jul '26

26 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-rendering Commit: 1d7cb19ff74225faa13405ff8fae20aa4e937697 https://github.com/xwiki/xwiki-rendering/commit/1d7cb19ff74225faa13405ff8fa… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-rendering-legacy/xwiki-rendering-legacy-transformations/xwiki-rendering-legacy-transformation-macro/pom.xml Log Message: ----------- XRENDERING-809: MacroDescriptor legacy getDefaultCategory() aspect is never weaved * Ignore in Revapi the @Around pointcut change of aroundGetDefaultCategory(), reported as an annotation attribute value change on the public aspect method. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-rendering] 1fe966: XRENDERING-809: MacroDescriptor legacy getDefaultC...
by XWiki Notifications 26 Jul '26

26 Jul '26

Branch: refs/heads/stable-17.10.x Home: https://github.com/xwiki/xwiki-rendering Commit: 1fe9668e7e78bc7f4ea2397759fded34e737ec02 https://github.com/xwiki/xwiki-rendering/commit/1fe9668e7e78bc7f4ea2397759f… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-rendering-legacy/xwiki-rendering-legacy-transformations/xwiki-rendering-legacy-transformation-macro/pom.xml Log Message: ----------- XRENDERING-809: MacroDescriptor legacy getDefaultCategory() aspect is never weaved * Ignore in Revapi the @Around pointcut change of aroundGetDefaultCategory(), reported as an annotation attribute value change on the public aspect method. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-platform] 67b42d: [Misc] Move deprecated PropertyDescriptor#getFied(...
by XWiki Notifications 26 Jul '26

26 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 67b42df723a5166e9217eb8e394556a013cc3b24 https://github.com/xwiki/xwiki-platform/commit/67b42df723a5166e9217eb8e3945… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-platform-distribution/xwiki-platform-distribution-war-legacydependencies/pom.xml Log Message: ----------- [Misc] Move deprecated PropertyDescriptor#getFied() to legacy * Also exclude the clean xwiki-commons-properties JAR from the legacy dependencies that were still pulling it transitively. Now that xwiki-commons-properties is a weaved module, its clean JAR is banned in the WAR, but each legacy module depends on its clean counterpart with <type>pom</type> to inherit its transitive dependencies, and the ban only matches the JAR type, so the clean properties JAR was still coming in underneath those pom nodes and failed the enforcer. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for XDOCKER-8: Also offer an alpine-based image to reduce download size
by XWiki Notifications 26 Jul '26

26 Jul '26

1 0

[[email protected]][Issue] Updates for XWIKI-22786: Update or mark method User#isUserInGroup as deprecated
by XWiki Notifications 26 Jul '26

26 Jul '26

1 0

[xwiki/xwiki-dev-llm] 8aeb9c: [Misc] Add AI attributions instead of removing them
by XWiki Notifications 26 Jul '26

26 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: 8aeb9c067ca9122259875a6152750ca7747275b3 https://github.com/xwiki/xwiki-dev-llm/commit/8aeb9c067ca9122259875a6152750… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki/skills/xwiki-knowledge/SKILL.md M xwiki/skills/xwiki-pull-request/SKILL.md Log Message: ----------- [Misc] Add AI attributions instead of removing them To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0