On 11/29/2010 03:54 PM, Sergiu Dumitriu wrote:
On 11/29/2010 11:05 AM, Sorin Burjan wrote:
Hello devs,
I have a proposal to make about the IRCbot Application. As you know, the bot logs the channel and saves the content in order to make it viewable from the xwiki designated page.
I would like to propose two things :
Proposal 1 In order to make archive logs more easily readable and more easy to follow, I would like to change the way the logs are saved. I would like to use a standard format (also used my all major IRC clients like Pidgin, IRC, XChat, irssi, etc). Because date/time will have always the same length, aligning it and putting it at the begginning of the line, makes the text more easy to follow. So, the proposals are :
Version 1 (the one we have now)
user1 - (20:07): You can comment if you have edit right JohnDoe - (20:07): ok, thx for the answer IreallyLoveXWiki - (20:07): I’m off for today, bye XWikiNormalUser left at 20:07 (Quit: Leaving. EnterpriseUser joined #xwiki at 20:38 EnterpriseUser left at 20:38 (Client Quit sburjan is now known as sburjan1 ([email protected]
Note that the ")" doesn't appear on logs, so this should be fixed any way.
Version 2
[11:05] XWikiNormalUser : How can I edit a page? [11:05] IreallyLoveXWiki : You have to be logged in order to do that [11:05] JohnDoe : I love Open Source ! [22:55] EnterpriseUser : joined #xwiki at 20:38 [22:56] EnterpriseUser : left at 20:38 (Client Quit [14:22] sburjan is now known as sburjan1 ([email protected])
+1
+1 for V2, but: - no space before : - no : on system lines (join, quit, nick change...)
Version 3
[11:05]<XWikiNormalUser> How can I edit a page? [11:05]<IreallyLoveXWiki> You have to be logged in order to do that [11:05]<JohnDoe> I love Open Source ! [22:55]<EnterpriseUser> joined #xwiki at 20:38 [22:56]<EnterpriseUser> left at 20:38 (Client Quit)
Version 1 : keep these addresses in log (like we have now)
sburjan is now known as sburjan1 ([email protected]
Version 2 : remove then from logging
sburjan is now known as sburjan1
I am +1 for 1.3 and +1 for 2.1
Please send your feedback and even your proposals if you have one.
WDYT ?
Regards, Sorin B. [14:22] sburjan is now known as sburjan1 ([email protected])
Proposal 2 We also log the user ip/host addresses when user joins. This also makes the line much longer with information that it's not needed IMO. This could be also a privacy concert, because your ip/host address is exposed to anyone who uses xwiki.org .
Version 1 : keep these addresses in log (like we have now)
sburjan is now known as sburjan1 ([email protected]
I'd rather keep them, since it might be a reference for identifying suspicious activity. The privacy gain from not logging the IP is minimal, since that information is already available live on IRC.
I sort of agree with Sergiu here, it's not the only potential privacy issue, which is why we warn that the channel is archived. Therefore I am 0 on this. If we could make it so that it's not displayed on the IRC channel, I would be +1. Thanks, Anca
Version 2 : remove then from logging
sburjan is now known as sburjan1
I am +1 for 1.3 and +1 for 2.1
Please send your feedback and even your proposals if you have one.
WDYT ?