On Fri, Oct 31, 2014 at 2:28 PM, Jean SIMARD <[email protected]> wrote:
On Fri, Oct 31, 2014 at 01:52:50PM +0100, Thomas Mortagne wrote:
On Fri, Oct 31, 2014 at 12:34 PM, Jean SIMARD <[email protected]> wrote:
Indeed, I did have the commit rights on xwiki-contrib. And I did merge the pull requests yesterday. The only thing I was not able to do was to change the status to "fix" in Jira. Of course, I could have asked on IRC for this but it was late, maybe nobody was there (in fact, I didn't try but I should have ^_^).
But maybe, it would be cool to have rights on Jira for the projects of xwiki-contrib, what do you think? I think it would make sense that I can close the bug on Jira if I can commit on Github*.
Yes there is no reason you don't have the right to close issues on contrib project where you have commit right. Checking the right of this project.
* I actually use PR even if I can commit because it's (in my opinion) a better way to make them visible to the community: an email is sent to every committer, the community may react before I merge it (usually, I leave them open around 2 days), it leaves traces of what happened (more than a list of commits).
You get a mail for a commit too and you can review and comment it the same way. Not sure of that. At least, I don't receive mail for any commit on xwiki-contrib (and I'm glad of that!). Moreover, if the comment is about discussing the solution, this is already too late, the commit is done (yes, of course you could revert it but I don't know if this is the more convenient solution). Anyway, this is just one way of doing things and if it doesn't bother people (tell me if it does), I'll probably keep it for now.
You get mail when you follow the project. Now you do whatever you want, I don't see why it would bother people, you are the only one that would get limitations and extra work in that process ;)
On Fri, Oct 31, 2014 at 12:11:47PM +0100, [email protected] wrote:
Hi Jean,
On 31 Oct 2014 at 11:53:24, Jean SIMARD ([email protected](mailto:[email protected])) wrote:
Hi Eduard,
Yesterday, I did TASKMAN-19 and TASKMAN-25 (see https://github.com/xwiki-contrib/application-task/pull/3 and https://github.com/xwiki-contrib/application-task/pull/20). I added the 'bugfixingday' tag in JIRA but since I have no rights to close them, they cannot appear. How I need to do for participating in BFD without being an official commiter?
Thanks for your participation!
For this case several options: - get on irc during the BFD and discuss with committers to get your PR applied during the day - ask for access on xwiki contrib repos since it’s an open policy (I think you have that access actually ;)) - wait for someone to apply your PRs later on. Even though they won’t appear in the Day’s BFD results, they will appear on the global BFD stats, for example check the bottom of http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352
Any other ideas?
Thanks -Vincent
Thanks
PS : I put the 'bugfixingday' tag on TASKMAN-19 only today. I did it yesterday evening before leaving but close my computer before saving :-P On Fri, Oct 31, 2014 at 12:33:42PM +0200, Eduard Moraru wrote:
Results: http://www.xwiki.org/xwiki/bin/view/Blog/Bug+Fixing+Day+68
Next week: BFD#69
Thanks, Eduard
On Thu, Oct 30, 2014 at 11:57 AM, Eduard Moraru wrote:
> Hi devs, > > As you probably already know, today is BFD#68: > http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingdays > > Our current status for the 1 year period is 107 bugs behind. See: > http://jira.xwiki > .org/secure/Dashboard.jspa?selectPageId=10000#Created-vs-Resolved-Chart/10470 > > Here's the BFD#68 dashboard to follow the progress during the day: > http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=12697 > > Thanks and enjoy your bug fixing day! > > -Eduard >
-- Jean Simard [email protected] Research engineer at XWiki SAS http://www.xwiki.com Committer on the XWiki.org project http://www.xwiki.org _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Jean Simard [email protected] Research engineer at XWiki SAS http://www.xwiki.com Committer on the XWiki.org project http://www.xwiki.org _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne