On Dec 29, 2008, at 3:02 PM, Guillaume Lerouge wrote:
On Mon, Dec 29, 2008 at 2:57 PM, Vincent Massol <[email protected]> wrote:
On Dec 29, 2008, at 2:29 PM, Guillaume Lerouge wrote:
On Mon, Dec 29, 2008 at 2:01 PM, Marius Dumitru Florea < [email protected]> wrote:
Hi devs,
A) Should xwiki/2.0 support multi-line headers?
I'm +0. Wikimodel, HTML and Open Office support them.
I'm -0. I don't think they're useful, but since they are already implemented it doesn't matter much.
B) What should happen when you press Enter inside a header in the new WYSIWYG?
B1) Currently, the text is moved on a new line, but still inside the header (multi-line header).
I'm +1 since it's already done (We agreed that you have to press Enter twice to generate a new paragraph).
+1 for this one since it's what we have and it's consistent with the "press Enter twice" behavior.
Can you explain why it's "consistent"? I don't understand the consistency.
Imagine you're on a header. You've finished typing it and you press enter. You start typing your text to realize you're not in a paragraph. You select the text you've typed and click in the toolbar to select the paragraph style. Yuck!
I think you are making a confusion between 2 situations:
1) The caret is within the header : HEAD|ER 2) The caret is at the end of the header : HEADER|
In case 1) (which I believe is the one Marius was referring to), pressing enter once puts the header on 2 lines and pressing enter twice creates a new paragraph (consistent with what happens when pressing enter twice after the last item fo a list for instance).
In case 2) (which is the one you are referring to), pressing enter indeed already creates a new paragraph.
In which case I agree with keeping it as it is and supporting multi line headers in the rendering (which we've verified with Thomas is not the case right now). However I've just tried hitting enter at the end of a header and it moved to the next line using the same style... Thanks -Vincent
Is that correct Marius?
Guillaume
Thanks -Vincent
Guillaume
B2) Text is moved in a new paragraph, below the header. Shift+Enter would have the effect described in B1).
I'm -0.
B3) Text is moved in a new header of the same level, below the current one. Shift+Enter would have the effect described in B1). This is what Open Office does (and we agreed not to follow it).
I'm -0.
Please cast your vote asap.
Thanks, Marius.