[xwiki-devs] [Proposal] Register global wiki macro at wiki level when the macro document is in a subwiki
Hi devs, It looks like a bug to me, but wiki macro defined for global level in a subwiki, are effectively influencing the whole farm. I would like to change that like this: * global level macro are registered global only if defined in the main wiki * global and wiki level macro defined in a subwiki are registered at wiki level The rationals are: * if the same global macro document is deployed on more than one wiki, which just means the same extension defining that document is installed on multiple wiki, maybe in different version, all those macros will be in conflict, it will not be easy to know which one wins, and even more difficult to detect the problem in the first place. * there is risk (of course limited by the PR), that user of subwiki influence the behaviors of the whole farm, which IMO is quite opposite to the logical structure, and even the physical storage we are used to. * I do not see any benefit of putting a global macro in a subwiki wdyt ? -- Denis Gervalle SOFTEC sa - CEO
On Wed, Oct 21, 2015 at 11:08 AM, Denis Gervalle <[email protected]> wrote:
Hi devs,
It looks like a bug to me, but wiki macro defined for global level in a subwiki, are effectively influencing the whole farm.
If the wiki macro is saved by a global user that has PR.
I would like to change that like this:
* global level macro are registered global only if defined in the main wiki * global and wiki level macro defined in a subwiki are registered at wiki level
The rationals are:
* if the same global macro document is deployed on more than one wiki, which just means the same extension defining that document is installed on multiple wiki, maybe in different version, all those macros will be in conflict, it will not be easy to know which one wins, and even more difficult to detect the problem in the first place.
This can happen also if two different extensions define a macro with the same name (in two different documents), but I guess this is less probable.
* there is risk (of course limited by the PR), that user of subwiki influence the behaviors of the whole farm, which IMO is quite opposite to the logical structure, and even the physical storage we are used to.
What do you mean by "user of subwiki"? It can be a global user. I agree that subwikis should act as namespaces, and normally you expect something defined in an inner namespace to not be visible in the outer namespace. So +1 Thanks, Marius
* I do not see any benefit of putting a global macro in a subwiki
wdyt ?
-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Wed, Oct 21, 2015 at 10:48 AM, Marius Dumitru Florea < [email protected]> wrote:
On Wed, Oct 21, 2015 at 11:08 AM, Denis Gervalle <[email protected]> wrote:
Hi devs,
It looks like a bug to me, but wiki macro defined for global level in a subwiki, are effectively influencing the whole farm.
If the wiki macro is saved by a global user that has PR.
I would like to change that like this:
* global level macro are registered global only if defined in the main wiki * global and wiki level macro defined in a subwiki are registered at wiki level
The rationals are:
* if the same global macro document is deployed on more than one wiki, which just means the same extension defining that document is installed on multiple wiki, maybe in different version, all those macros will be in conflict, it will not be easy to know which one wins, and even more difficult to detect the problem in the first place.
This can happen also if two different extensions define a macro with the same name (in two different documents), but I guess this is less probable.
Well, for sure, this could happen. What annoy me more, is the fact that when I publish an extension with a macro set to Global, I have no way to prevent it to be installed in subwikis, and shot myself in the foot. And mostly the diagnosis is a big issue, since you have no easy way to find why your nice macro on the main wiki is not working as expected in your own wiki, or a subwiki you manage, because another subwiki is killing you.
* there is risk (of course limited by the PR), that user of subwiki influence the behaviors of the whole farm, which IMO is quite opposite to the logical structure, and even the physical storage we are used to.
What do you mean by "user of subwiki"? It can be a global user.
It should be a global user, else no PR, but it could be “sementically” a power user in a that usually only work in a given subwiki.
I agree that subwikis should act as namespaces, and normally you expect something defined in an inner namespace to not be visible in the outer namespace. So +1
You perfectly get my point, thanks for your vote :)
Thanks, Marius
* I do not see any benefit of putting a global macro in a subwiki
wdyt ?
-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO
On Wed, Oct 21, 2015 at 10:48 AM, Marius Dumitru Florea <[email protected]> wrote:
On Wed, Oct 21, 2015 at 11:08 AM, Denis Gervalle <[email protected]> wrote:
Hi devs,
It looks like a bug to me, but wiki macro defined for global level in a subwiki, are effectively influencing the whole farm.
If the wiki macro is saved by a global user that has PR.
I would like to change that like this:
* global level macro are registered global only if defined in the main wiki * global and wiki level macro defined in a subwiki are registered at wiki level
The rationals are:
* if the same global macro document is deployed on more than one wiki, which just means the same extension defining that document is installed on multiple wiki, maybe in different version, all those macros will be in conflict, it will not be easy to know which one wins, and even more difficult to detect the problem in the first place.
This can happen also if two different extensions define a macro with the same name (in two different documents), but I guess this is less probable.
* there is risk (of course limited by the PR), that user of subwiki influence the behaviors of the whole farm, which IMO is quite opposite to the logical structure, and even the physical storage we are used to.
What do you mean by "user of subwiki"? It can be a global user.
I agree that subwikis should act as namespaces, and normally you expect something defined in an inner namespace to not be visible in the outer namespace. So +1
+1 To be consistent we should apply the same logic to other related use cases like translations.
Thanks, Marius
* I do not see any benefit of putting a global macro in a subwiki
wdyt ?
-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+1 2015-10-26 10:53 GMT+01:00 Thomas Mortagne <[email protected]>:
On Wed, Oct 21, 2015 at 10:48 AM, Marius Dumitru Florea <[email protected]> wrote:
On Wed, Oct 21, 2015 at 11:08 AM, Denis Gervalle <[email protected]> wrote:
Hi devs,
It looks like a bug to me, but wiki macro defined for global level in a subwiki, are effectively influencing the whole farm.
If the wiki macro is saved by a global user that has PR.
I would like to change that like this:
* global level macro are registered global only if defined in the main wiki * global and wiki level macro defined in a subwiki are registered at wiki level
The rationals are:
* if the same global macro document is deployed on more than one wiki, which just means the same extension defining that document is installed on multiple wiki, maybe in different version, all those macros will be in conflict, it will not be easy to know which one wins, and even more difficult to detect the problem in the first place.
This can happen also if two different extensions define a macro with the same name (in two different documents), but I guess this is less probable.
* there is risk (of course limited by the PR), that user of subwiki influence the behaviors of the whole farm, which IMO is quite opposite to the logical structure, and even the physical storage we are used to.
What do you mean by "user of subwiki"? It can be a global user.
I agree that subwikis should act as namespaces, and normally you expect something defined in an inner namespace to not be visible in the outer namespace. So +1
+1
To be consistent we should apply the same logic to other related use cases like translations.
Thanks, Marius
* I do not see any benefit of putting a global macro in a subwiki
wdyt ?
-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Hi, I have created https://jira.xwiki.org/browse/XWIKI-12736 for this improvement. Regards, On Tue, Oct 27, 2015 at 11:37 AM, Guillaume "Louis-Marie" Delhumeau < [email protected]> wrote:
+1
2015-10-26 10:53 GMT+01:00 Thomas Mortagne <[email protected]>:
On Wed, Oct 21, 2015 at 10:48 AM, Marius Dumitru Florea <[email protected]> wrote:
On Wed, Oct 21, 2015 at 11:08 AM, Denis Gervalle <[email protected]> wrote:
Hi devs,
It looks like a bug to me, but wiki macro defined for global level in a subwiki, are effectively influencing the whole farm.
If the wiki macro is saved by a global user that has PR.
I would like to change that like this:
* global level macro are registered global only if defined in the main wiki * global and wiki level macro defined in a subwiki are registered at wiki level
The rationals are:
* if the same global macro document is deployed on more than one wiki, which just means the same extension defining that document is installed on multiple wiki, maybe in different version, all those macros will be in conflict, it will not be easy to know which one wins, and even more difficult to detect the problem in the first place.
This can happen also if two different extensions define a macro with the same name (in two different documents), but I guess this is less probable.
* there is risk (of course limited by the PR), that user of subwiki influence the behaviors of the whole farm, which IMO is quite opposite to the logical structure, and even the physical storage we are used to.
What do you mean by "user of subwiki"? It can be a global user.
I agree that subwikis should act as namespaces, and normally you expect something defined in an inner namespace to not be visible in the outer namespace. So +1
+1
To be consistent we should apply the same logic to other related use cases like translations.
Thanks, Marius
* I do not see any benefit of putting a global macro in a subwiki
wdyt ?
-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO
Hi Denis, On 21 Oct 2015 at 10:08:40, Denis Gervalle ([email protected](mailto:[email protected])) wrote:
Hi devs,
It looks like a bug to me, but wiki macro defined for global level in a subwiki, are effectively influencing the whole farm. I would like to change that like this:
* global level macro are registered global only if defined in the main wiki * global and wiki level macro defined in a subwiki are registered at wiki level
The rationals are:
* if the same global macro document is deployed on more than one wiki, which just means the same extension defining that document is installed on multiple wiki, maybe in different version, all those macros will be in conflict, it will not be easy to know which one wins, and even more difficult to detect the problem in the first place. * there is risk (of course limited by the PR), that user of subwiki influence the behaviors of the whole farm, which IMO is quite opposite to the logical structure, and even the physical storage we are used to. * I do not see any benefit of putting a global macro in a subwiki
wdyt ?
I think it’s a more global issue. For example any global user with PR can always impact the whole farm even when he’s on a subwiki, since that user can register components in the Root Component Manager for example. The way we protected against this is by requiring PR on the main wiki. Now I’m ok to do what you suggest, but just know it’s not the only way to impact the whole farm from a subwiki. Makes it a bit less easy though ;) Thanks -Vincent
-- Denis Gervalle
participants (5)
-
Denis Gervalle -
Guillaume "Louis-Marie" Delhumeau -
Marius Dumitru Florea -
Thomas Mortagne -
vincent＠massol.net