[xwiki-devs] [Proposal] Extract the DocumentTree macro from the Index App
Hi devs, I see that the DocumentTree macro is used more and more in several places (as it should) and I’d like to propose to extract the DocumentTree macro from the Index App. Proposal 1: =========== xwiki-platform-tree |_ xwiki-platform-tree-generic |_ ... |_ xwiki-platform-tree-document |_ ... Proposal 2: =========== xwiki-platform-index |_ xwiki-platform-index-ui |_ xwiki-plarform-index-tree |_ … WDYT? Any other proposal? Personally I prefer proposal 1. Thanks -Vincent
On 23 Oct 2015 at 14:25:31, [email protected] ([email protected](mailto:[email protected])) wrote:
Hi devs,
I see that the DocumentTree macro is used more and more in several places (as it should) and I’d like to propose to extract the DocumentTree macro from the Index App.
Rationale is that it doesn’t feel right to depend on lots of other documents if all you need is the DocumentTree macro. Thanks -Vincent
Proposal 1: ===========
xwiki-platform-tree |_ xwiki-platform-tree-generic |_ ... |_ xwiki-platform-tree-document |_ ...
Proposal 2: ===========
xwiki-platform-index |_ xwiki-platform-index-ui |_ xwiki-plarform-index-tree |_ …
WDYT? Any other proposal?
Personally I prefer proposal 1.
Thanks -Vincent
+1 for extracting it. We currently need this in the administration module, for the template provider UI. IMO, xwiki-platform-tree is basically about the tree widget... almost nothing to do with XWiki's data model. In my eyes, this looks like the technology, not the domain. xwiki-platform-index makes much more sense to me, since it defines the domain, which can present an index of documents using various technologies: livetable (documents), tree (documentTree), intepretive dance, etc. +1 for proposal 2 (since we agreed that we were grouping modules by domain and not by technology). Thanks, Eduard P.S.: We could also extract an xwiki-platform-index-livetable (or something with -macro-document if we want to make it about the name of the macro instead of the presentation technology) for the Documents macro (XWiki.DocumentsMacro), currently also bundled in index-ui. On Fri, Oct 23, 2015 at 3:25 PM, [email protected] <[email protected]> wrote:
Hi devs,
I see that the DocumentTree macro is used more and more in several places (as it should) and I’d like to propose to extract the DocumentTree macro from the Index App.
Proposal 1: ===========
xwiki-platform-tree |_ xwiki-platform-tree-generic |_ ... |_ xwiki-platform-tree-document |_ ...
Proposal 2: ===========
xwiki-platform-index |_ xwiki-platform-index-ui |_ xwiki-plarform-index-tree |_ …
WDYT? Any other proposal?
Personally I prefer proposal 1.
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Hi, It would be really nice to get some more feedback on this, since we need it for 7.3M2 (to fix the failing tests). Thanks, Eduard On Fri, Oct 23, 2015 at 3:31 PM, Eduard Moraru <[email protected]> wrote:
+1 for extracting it. We currently need this in the administration module, for the template provider UI.
IMO, xwiki-platform-tree is basically about the tree widget... almost nothing to do with XWiki's data model. In my eyes, this looks like the technology, not the domain.
xwiki-platform-index makes much more sense to me, since it defines the domain, which can present an index of documents using various technologies: livetable (documents), tree (documentTree), intepretive dance, etc.
+1 for proposal 2 (since we agreed that we were grouping modules by domain and not by technology).
Thanks,
Eduard
P.S.: We could also extract an xwiki-platform-index-livetable (or something with -macro-document if we want to make it about the name of the macro instead of the presentation technology) for the Documents macro (XWiki.DocumentsMacro), currently also bundled in index-ui.
On Fri, Oct 23, 2015 at 3:25 PM, [email protected] <[email protected]> wrote:
Hi devs,
I see that the DocumentTree macro is used more and more in several places (as it should) and I’d like to propose to extract the DocumentTree macro from the Index App.
Proposal 1: ===========
xwiki-platform-tree |_ xwiki-platform-tree-generic |_ ... |_ xwiki-platform-tree-document |_ ...
Proposal 2: ===========
xwiki-platform-index |_ xwiki-platform-index-ui |_ xwiki-plarform-index-tree |_ …
WDYT? Any other proposal?
Personally I prefer proposal 1.
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On 26 Oct 2015 at 15:25:17, Eduard Moraru ([email protected](mailto:[email protected])) wrote:
Hi,
It would be really nice to get some more feedback on this, since we need it for 7.3M2 (to fix the failing tests).
On my side I’m +1 for both proposals. Thanks -Vincent
Thanks, Eduard
On Fri, Oct 23, 2015 at 3:31 PM, Eduard Moraru wrote:
+1 for extracting it. We currently need this in the administration module, for the template provider UI.
IMO, xwiki-platform-tree is basically about the tree widget... almost nothing to do with XWiki's data model. In my eyes, this looks like the technology, not the domain.
xwiki-platform-index makes much more sense to me, since it defines the domain, which can present an index of documents using various technologies: livetable (documents), tree (documentTree), intepretive dance, etc.
+1 for proposal 2 (since we agreed that we were grouping modules by domain and not by technology).
Thanks,
Eduard
P.S.: We could also extract an xwiki-platform-index-livetable (or something with -macro-document if we want to make it about the name of the macro instead of the presentation technology) for the Documents macro (XWiki.DocumentsMacro), currently also bundled in index-ui.
On Fri, Oct 23, 2015 at 3:25 PM, [email protected] wrote:
Hi devs,
I see that the DocumentTree macro is used more and more in several places (as it should) and I’d like to propose to extract the DocumentTree macro from the Index App.
Proposal 1: ===========
xwiki-platform-tree |_ xwiki-platform-tree-generic |_ ... |_ xwiki-platform-tree-document |_ ...
Proposal 2: ===========
xwiki-platform-index |_ xwiki-platform-index-ui |_ xwiki-plarform-index-tree |_ …
WDYT? Any other proposal?
Personally I prefer proposal 1.
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Mon, Oct 26, 2015 at 3:24 PM, Eduard Moraru <[email protected]> wrote:
Hi,
It would be really nice to get some more feedback on this, since we need it for 7.3M2 (to fix the failing tests).
Thanks, Eduard
On Fri, Oct 23, 2015 at 3:31 PM, Eduard Moraru <[email protected]> wrote:
+1 for extracting it. We currently need this in the administration module, for the template provider UI.
+1
IMO, xwiki-platform-tree is basically about the tree widget... almost nothing to do with XWiki's data model. In my eyes, this looks like the technology, not the domain.
xwiki-platform-index makes much more sense to me, since it defines the domain, which can present an index of documents using various technologies: livetable (documents), tree (documentTree), intepretive dance, etc.
+1 for proposal 2 (since we agreed that we were grouping modules by domain and not by technology).
My preference goes to proposal 2 with the same feeling already exposed by Edy.
Thanks,
Eduard
P.S.: We could also extract an xwiki-platform-index-livetable (or something with -macro-document if we want to make it about the name of the macro instead of the presentation technology) for the Documents macro (XWiki.DocumentsMacro), currently also bundled in index-ui.
On Fri, Oct 23, 2015 at 3:25 PM, [email protected] <[email protected]> wrote:
Hi devs,
I see that the DocumentTree macro is used more and more in several places (as it should) and I’d like to propose to extract the DocumentTree macro from the Index App.
Proposal 1: ===========
xwiki-platform-tree |_ xwiki-platform-tree-generic |_ ... |_ xwiki-platform-tree-document |_ ...
Proposal 2: ===========
xwiki-platform-index |_ xwiki-platform-index-ui |_ xwiki-plarform-index-tree |_ …
WDYT? Any other proposal?
Personally I prefer proposal 1.
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Mon, Oct 26, 2015 at 4:37 PM, Thomas Mortagne <[email protected]> wrote:
On Mon, Oct 26, 2015 at 3:24 PM, Eduard Moraru <[email protected]> wrote:
Hi,
It would be really nice to get some more feedback on this, since we need it for 7.3M2 (to fix the failing tests).
Thanks, Eduard
On Fri, Oct 23, 2015 at 3:31 PM, Eduard Moraru <[email protected]> wrote:
+1 for extracting it. We currently need this in the administration module, for the template provider UI.
+1
IMO, xwiki-platform-tree is basically about the tree widget... almost nothing to do with XWiki's data model. In my eyes, this looks like the technology, not the domain.
xwiki-platform-index makes much more sense to me, since it defines the domain, which can present an index of documents using various
technologies:
livetable (documents), tree (documentTree), intepretive dance, etc.
+1 for proposal 2 (since we agreed that we were grouping modules by domain and not by technology).
My preference goes to proposal 2 with the same feeling already exposed by Edy.
+1 Thanks, Marius
Thanks,
Eduard
P.S.: We could also extract an xwiki-platform-index-livetable (or something with -macro-document if we want to make it about the name of
the
macro instead of the presentation technology) for the Documents macro (XWiki.DocumentsMacro), currently also bundled in index-ui.
On Fri, Oct 23, 2015 at 3:25 PM, [email protected] <[email protected]
wrote:
Hi devs,
I see that the DocumentTree macro is used more and more in several places (as it should) and I’d like to propose to extract the DocumentTree macro from the Index App.
Proposal 1: ===========
xwiki-platform-tree |_ xwiki-platform-tree-generic |_ ... |_ xwiki-platform-tree-document |_ ...
Proposal 2: ===========
xwiki-platform-index |_ xwiki-platform-index-ui |_ xwiki-plarform-index-tree |_ …
WDYT? Any other proposal?
Personally I prefer proposal 1.
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Tue, Oct 27, 2015 at 8:21 AM, Marius Dumitru Florea < [email protected]> wrote:
On Mon, Oct 26, 2015 at 4:37 PM, Thomas Mortagne < [email protected]> wrote:
On Mon, Oct 26, 2015 at 3:24 PM, Eduard Moraru <[email protected]> wrote:
Hi,
It would be really nice to get some more feedback on this, since we need it for 7.3M2 (to fix the failing tests).
Thanks, Eduard
On Fri, Oct 23, 2015 at 3:31 PM, Eduard Moraru <[email protected]> wrote:
+1 for extracting it. We currently need this in the administration module, for the template provider UI.
+1
IMO, xwiki-platform-tree is basically about the tree widget... almost nothing to do with XWiki's data model. In my eyes, this looks like the technology, not the domain.
xwiki-platform-index makes much more sense to me, since it defines the domain, which can present an index of documents using various
technologies:
livetable (documents), tree (documentTree), intepretive dance, etc.
+1 for proposal 2 (since we agreed that we were grouping modules by domain and not by technology).
My preference goes to proposal 2 with the same feeling already exposed by Edy.
+1
Renaming the current 3 modules in xwiki-platform-tree in xwiki-platform-tree-generic-* doesn't sound right: "generic" feels redundant in the name. I don't have a better proposal than 2.
Thanks, Marius
Thanks,
Eduard
P.S.: We could also extract an xwiki-platform-index-livetable (or something with -macro-document if we want to make it about the name of
the
macro instead of the presentation technology) for the Documents macro (XWiki.DocumentsMacro), currently also bundled in index-ui.
On Fri, Oct 23, 2015 at 3:25 PM, [email protected] < [email protected]> wrote:
Hi devs,
I see that the DocumentTree macro is used more and more in several places (as it should) and I’d like to propose to extract the DocumentTree macro from the Index App.
Proposal 1: ===========
xwiki-platform-tree |_ xwiki-platform-tree-generic |_ ... |_ xwiki-platform-tree-document |_ ...
Proposal 2: ===========
xwiki-platform-index |_ xwiki-platform-index-ui |_ xwiki-plarform-index-tree |_ …
WDYT? Any other proposal?
Personally I prefer proposal 1.
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 for proposal 2, convinced by the Edy's arguments. 2015-10-27 7:26 GMT+01:00 Marius Dumitru Florea < [email protected]>:
On Tue, Oct 27, 2015 at 8:21 AM, Marius Dumitru Florea < [email protected]> wrote:
On Mon, Oct 26, 2015 at 4:37 PM, Thomas Mortagne < [email protected]> wrote:
On Mon, Oct 26, 2015 at 3:24 PM, Eduard Moraru <[email protected]> wrote:
Hi,
It would be really nice to get some more feedback on this, since we need it for 7.3M2 (to fix the failing tests).
Thanks, Eduard
On Fri, Oct 23, 2015 at 3:31 PM, Eduard Moraru <[email protected]> wrote:
+1 for extracting it. We currently need this in the administration module, for the template provider UI.
+1
IMO, xwiki-platform-tree is basically about the tree widget... almost nothing to do with XWiki's data model. In my eyes, this looks like
the
technology, not the domain.
xwiki-platform-index makes much more sense to me, since it defines the domain, which can present an index of documents using various technologies: livetable (documents), tree (documentTree), intepretive dance, etc.
+1 for proposal 2 (since we agreed that we were grouping modules by domain and not by technology).
My preference goes to proposal 2 with the same feeling already exposed by Edy.
+1
Renaming the current 3 modules in xwiki-platform-tree in xwiki-platform-tree-generic-* doesn't sound right: "generic" feels redundant in the name. I don't have a better proposal than 2.
Thanks, Marius
Thanks,
Eduard
P.S.: We could also extract an xwiki-platform-index-livetable (or something with -macro-document if we want to make it about the name
of
the
macro instead of the presentation technology) for the Documents macro (XWiki.DocumentsMacro), currently also bundled in index-ui.
On Fri, Oct 23, 2015 at 3:25 PM, [email protected] < [email protected]> wrote:
Hi devs,
I see that the DocumentTree macro is used more and more in several places (as it should) and I’d like to propose to extract the DocumentTree macro from the Index App.
Proposal 1: ===========
xwiki-platform-tree |_ xwiki-platform-tree-generic |_ ... |_ xwiki-platform-tree-document |_ ...
Proposal 2: ===========
xwiki-platform-index |_ xwiki-platform-index-ui |_ xwiki-plarform-index-tree |_ …
WDYT? Any other proposal?
Personally I prefer proposal 1.
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Thanks, everybody! Done as http://jira.xwiki.org/browse/XWIKI-12734 -Eduard On Tue, Oct 27, 2015 at 12:40 PM, Guillaume "Louis-Marie" Delhumeau < [email protected]> wrote:
+1 for proposal 2, convinced by the Edy's arguments.
2015-10-27 7:26 GMT+01:00 Marius Dumitru Florea < [email protected]>:
On Tue, Oct 27, 2015 at 8:21 AM, Marius Dumitru Florea < [email protected]> wrote:
On Mon, Oct 26, 2015 at 4:37 PM, Thomas Mortagne < [email protected]> wrote:
On Mon, Oct 26, 2015 at 3:24 PM, Eduard Moraru <[email protected]> wrote:
Hi,
It would be really nice to get some more feedback on this, since we need it for 7.3M2 (to fix the failing tests).
Thanks, Eduard
On Fri, Oct 23, 2015 at 3:31 PM, Eduard Moraru < [email protected]> wrote:
+1 for extracting it. We currently need this in the administration module, for the template provider UI.
+1
IMO, xwiki-platform-tree is basically about the tree widget...
almost
nothing to do with XWiki's data model. In my eyes, this looks like the technology, not the domain.
xwiki-platform-index makes much more sense to me, since it defines the domain, which can present an index of documents using various technologies: livetable (documents), tree (documentTree), intepretive dance, etc.
+1 for proposal 2 (since we agreed that we were grouping modules by domain and not by technology).
My preference goes to proposal 2 with the same feeling already exposed by Edy.
+1
Renaming the current 3 modules in xwiki-platform-tree in xwiki-platform-tree-generic-* doesn't sound right: "generic" feels redundant in the name. I don't have a better proposal than 2.
Thanks, Marius
Thanks,
Eduard
P.S.: We could also extract an xwiki-platform-index-livetable (or something with -macro-document if we want to make it about the name
of
the
macro instead of the presentation technology) for the Documents macro (XWiki.DocumentsMacro), currently also bundled in index-ui.
On Fri, Oct 23, 2015 at 3:25 PM, [email protected] < [email protected]> wrote:
> Hi devs, > > I see that the DocumentTree macro is used more and more in several places > (as it should) and I’d like to propose to extract the DocumentTree macro > from the Index App. > > Proposal 1: > =========== > > xwiki-platform-tree > |_ xwiki-platform-tree-generic > |_ ... > |_ xwiki-platform-tree-document > |_ ... > > > Proposal 2: > =========== > > xwiki-platform-index > |_ xwiki-platform-index-ui > |_ xwiki-plarform-index-tree > |_ … > > WDYT? Any other proposal? > > Personally I prefer proposal 1. > > Thanks > -Vincent > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs >
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (5)
-
Eduard Moraru -
Guillaume "Louis-Marie" Delhumeau -
Marius Dumitru Florea -
Thomas Mortagne -
vincent＠massol.net