Hello,
I just updated from
JVM 1.5.0_05
Tomcat 5.0.28
xWiki 0.9.543
to
JVM 1.5.0_06
Tomcat 5.5.16
xWiki 0.9.840
with MySql *4.0.24 *under Windows XP.
Then I can read the previous xwiki database, but I can't update it. As
soon as I try to save a change I get the error below.
Any idea?
Regards
Pierre Raoul
[...]
INFO: Server startup in 71000 ms
20:43:13,046 WARN http-8080-Processor25
http://localhost:8080/xwiki/bin/edit/Main/InstallerxWiki
Configurator:configure:126
- No configuration found. Configuring ehcache from ehcache-failsafe.xml
found in the classpath: jar:file:/C:/Program%20File
s/Apache%20Software%20Foundation/apache-tomcat-5.5.16/webapps/xwiki/WEB-INF/lib/ehcache-1.1.jar!/ehcache-failsafe.xml
20:43:24,000 ERROR http-8080-Processor25
http://localhost:8080/xwiki/bin/edit/Main/InstallerxWiki
XWikiHibernateStore:update
Schema:177 - Schema update for wiki xwiki
21:12:08,750 WARN http-8080-Processor25
http://localhost:8080/xwiki/bin/save/Main/InstallerxWiki
XWikiStatsServiceImpl:addC
ookie:474 - Setting cookie 6PCUESQ34SBN5NBQIZZNWEQSFRPFFENE for name
visitid with domain null and path / and maxage 1333574
21:12:08,859 ERROR http-8080-Processor25
http://localhost:8080/xwiki/bin/save/Main/InstallerxWiki
AssertionFailure:<init>:22
- an assertion failure occured (this may indicate a bug in Hibernate,
but is more likely due to unsafe use of the session)
org.hibernate.AssertionFailure: possible nonthreadsafe access to session
at
org.hibernate.action.EntityDeleteAction.execute(EntityDeleteAction.java:68)
at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:239)
at
org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:223)
at
org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:141)
at
org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:274)
at
org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:27)
at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:726)
at org.hibernate.impl.SessionImpl.managedFlush(SessionImpl.java:320)
at
org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:86)
at
com.xpn.xwiki.store.XWikiHibernateStore.endTransaction(XWikiHibernateStore.java:350)
at
com.xpn.xwiki.store.XWikiHibernateStore.deleteXWikiCollection(XWikiHibernateStore.java:982)
at
com.xpn.xwiki.stats.impl.XWikiStatsServiceImpl.notify(XWikiStatsServiceImpl.java:209)
at
com.xpn.xwiki.notify.XWikiActionRule.verify(XWikiActionRule.java:51)
at
com.xpn.xwiki.notify.XWikiNotificationManager.verify(XWikiNotificationManager.java:93)
at com.xpn.xwiki.web.ViewEditAction.execute(ViewEditAction.java:268)
at
org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)
at
org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)
at
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)
at
org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:415)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:127)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664
)
at
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:595)
com.xpn.xwiki.XWikiException: Error number 3213 in 3: Exception while
deleting object XWiki.Admin
Wrapped Exception: possible nonthreadsafe access to session
at
com.xpn.xwiki.store.XWikiHibernateStore.deleteXWikiCollection(XWikiHibernateStore.java:986)
at
com.xpn.xwiki.stats.impl.XWikiStatsServiceImpl.notify(XWikiStatsServiceImpl.java:209)
at
com.xpn.xwiki.notify.XWikiActionRule.verify(XWikiActionRule.java:51)
at
com.xpn.xwiki.notify.XWikiNotificationManager.verify(XWikiNotificationManager.java:93)
at com.xpn.xwiki.web.ViewEditAction.execute(ViewEditAction.java:268)
at
org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)
at
org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)
at
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)
at
org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:415)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:127)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664
)
at
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:595)
Wrapped Exception:
org.hibernate.AssertionFailure: possible nonthreadsafe access to session
at
org.hibernate.action.EntityDeleteAction.execute(EntityDeleteAction.java:68)
at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:239)
at
org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:223)
at
org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:141)
at
org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:274)
at
org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:27)
at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:726)
at org.hibernate.impl.SessionImpl.managedFlush(SessionImpl.java:320)
at
org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:86)
at
com.xpn.xwiki.store.XWikiHibernateStore.endTransaction(XWikiHibernateStore.java:350)
at
com.xpn.xwiki.store.XWikiHibernateStore.deleteXWikiCollection(XWikiHibernateStore.java:982)
at
com.xpn.xwiki.stats.impl.XWikiStatsServiceImpl.notify(XWikiStatsServiceImpl.java:209)
at
com.xpn.xwiki.notify.XWikiActionRule.verify(XWikiActionRule.java:51)
at
com.xpn.xwiki.notify.XWikiNotificationManager.verify(XWikiNotificationManager.java:93)
at com.xpn.xwiki.web.ViewEditAction.execute(ViewEditAction.java:268)
at
org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)
at
org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)
at
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)
at
org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:415)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:127)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664
)
at
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:595)
21:12:09,062 WARN http-8080-Processor25
RequestUtils:createActionForm:177 - No FormBeanConfig found under 'view'
21:12:13,546 WARN Finalizer JDBCContext:finalize:333 -
afterTransactionCompletion() was never called
21:12:14,718 WARN http-8080-Processor25
http://localhost:8080/xwiki/bin/view/Main/InstallerxWiki
XWikiStatsServiceImpl:addC
ookie:474 - Setting cookie 42GLIZ4WELYCD0NATIHUEUYLBLNALH73 for name
visitid with domain null and path / and maxage 1333568
21:12:14,718 WARN http-8080-Processor25
http://localhost:8080/xwiki/bin/view/Main/InstallerxWiki
XWikiStatsServiceImpl:find
Visit:314 - Found visit with cookie T6ESE8E4VJTZCFROAE9ZTIBXLBG8KYUR in
session 8DEA74E3BA006C10D516BF9A9EC8B299 for request
with cookie 42GLIZ4WELYCD0NATIHUEUYLBLNALH73
21:12:14,734 ERROR http-8080-Processor25
http://localhost:8080/xwiki/bin/view/Main/InstallerxWiki
AssertionFailure:<init>:22
- an assertion failure occured (this may indicate a bug in Hibernate,
but is more likely due to unsafe use of the session)
org.hibernate.AssertionFailure: possible nonthreadsafe access to session
at
org.hibernate.action.EntityDeleteAction.execute(EntityDeleteAction.java:68)
at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:239)
at
org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:223)
at
org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:141)
at
org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:274)
at
org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:27)
at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:726)
at org.hibernate.impl.SessionImpl.managedFlush(SessionImpl.java:320)
at
org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:86)
at
com.xpn.xwiki.store.XWikiHibernateStore.endTransaction(XWikiHibernateStore.java:350)
at
com.xpn.xwiki.store.XWikiHibernateStore.deleteXWikiCollection(XWikiHibernateStore.java:982)
at
com.xpn.xwiki.stats.impl.XWikiStatsServiceImpl.notify(XWikiStatsServiceImpl.java:209)
at
com.xpn.xwiki.notify.XWikiActionRule.verify(XWikiActionRule.java:51)
at
com.xpn.xwiki.notify.XWikiNotificationManager.verify(XWikiNotificationManager.java:93)
at com.xpn.xwiki.web.ViewEditAction.execute(ViewEditAction.java:268)
at
org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)
at
org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)
at
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)
at
org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:397)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:127)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664
)
at
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:595)
com.xpn.xwiki.XWikiException: Error number 3213 in 3: Exception while
deleting object XWiki.Admin
Wrapped Exception: possible nonthreadsafe access to session
at
com.xpn.xwiki.store.XWikiHibernateStore.deleteXWikiCollection(XWikiHibernateStore.java:986)
at
com.xpn.xwiki.stats.impl.XWikiStatsServiceImpl.notify(XWikiStatsServiceImpl.java:209)
at
com.xpn.xwiki.notify.XWikiActionRule.verify(XWikiActionRule.java:51)
at
com.xpn.xwiki.notify.XWikiNotificationManager.verify(XWikiNotificationManager.java:93)
at com.xpn.xwiki.web.ViewEditAction.execute(ViewEditAction.java:268)
at
org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)
at
org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)
at
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)
at
org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:397)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:127)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664
)
at
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:595)
Wrapped Exception:
org.hibernate.AssertionFailure: possible nonthreadsafe access to session
at
org.hibernate.action.EntityDeleteAction.execute(EntityDeleteAction.java:68)
at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:239)
at
org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:223)
at
org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:141)
at
org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:274)
at
org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:27)
at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:726)
at org.hibernate.impl.SessionImpl.managedFlush(SessionImpl.java:320)
at
org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:86)
at
com.xpn.xwiki.store.XWikiHibernateStore.endTransaction(XWikiHibernateStore.java:350)
at
com.xpn.xwiki.store.XWikiHibernateStore.deleteXWikiCollection(XWikiHibernateStore.java:982)
at
com.xpn.xwiki.stats.impl.XWikiStatsServiceImpl.notify(XWikiStatsServiceImpl.java:209)
at
com.xpn.xwiki.notify.XWikiActionRule.verify(XWikiActionRule.java:51)
at
com.xpn.xwiki.notify.XWikiNotificationManager.verify(XWikiNotificationManager.java:93)
at com.xpn.xwiki.web.ViewEditAction.execute(ViewEditAction.java:268)
at
org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)
at
org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)
at
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)
at
org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:397)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:127)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664
)
at
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:595)
21:12:23,906 WARN Finalizer JDBCContext:finalize:333 -
afterTransactionCompletion() was never called