On Wed, Mar 2, 2016 at 3:47 PM, Eduard Moraru <enygma2002(a)gmail.com> wrote:
On Wed, Mar 2, 2016 at 11:41 AM, Marius Dumitru Florea
<
mariusdumitru.florea(a)xwiki.com> wrote:
On Wed, Feb 24, 2016 at 1:58 AM, Eduard Moraru
<enygma2002(a)gmail.com>
wrote:
> Why not launch a javascript event when an attachment is added to a
page?
If
you are in edit mode and you have an editor
listening to such an event,
it
can also include the attachment in the editor (if
it's an image), etc.
Which editor instance? You can have more than one (e.g. two or more Text
Area properties). And where in the edited content? Best is to choose the
insertion point while you drag the file over the editing area, as it
happens in CKEditor.
This sounds like an implementation detail. The javascript event can also
provide the drop target. If its one of your editors (you can also probably
check if an editor is focused before the drop event), insert it in the
particular editor. The actual location in the edited content could also be
determined from the drop target.
It seems you're not taking into account the fact that the editing area is
an iframe, so a different window.
IMO it does not really make sense as a
long-term strategy to reimplement the same basic functionality over and
over again.
Thanks,
Eduard
>
> Right now we already have the feature of adding an attachment from view
> mode. You don`t really need to be in an editor to attach a file to a
page
> so that`s why I saw this as a more generic
feature of the page itself.
>
> Anyway, just an idea.
>
> Thanks,
> Eduard
>
> On Wed, Feb 24, 2016 at 12:28 AM, vincent(a)massol.net <
vincent(a)massol.net
wrote:
> Hi Edy,
>
> On 23 Feb 2016 at 22:35:18, Eduard Moraru (enygma2002(a)gmail.com
(mailto:
> > enygma2002(a)gmail.com)) wrote:
> >
> > > On Tue, Feb 23, 2016 at 7:47 PM, vincent(a)massol.net
> > > wrote:
> > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On 23 Feb 2016 at 15:14:06, Guillaume Lerouge (
guillaume(a)xwiki.com
>
(mailto:
> > > guillaume(a)xwiki.com)) wrote:
> > >
> > > > Hi Edy,
> > > >
> > > > On Tue, Feb 23, 2016 at 2:38 PM, Eduard Moraru wrote:
> > > >
> > > > > On Tue, Feb 23, 2016 at 1:22 PM, vincent(a)massol.net
> > > > > wrote:
> > > > >
> > > > > >
> > > > > >
> > > > > > On 23 Feb 2016 at 12:06:43, Guillaume Lerouge (
> guillaume(a)xwiki.com
> > > > > (mailto:
> > > > > > guillaume(a)xwiki.com)) wrote:
> > > > > >
> > > > > > > Hi Stuart,
> > > > > > >
> > > > > > > thanks for your feedback. This is indeed a frequent
request.
> > In the
> > > > > > > current
> > > > > > > > WYSIWYG editor, it partially works (your image
has to be
> > available
> > > > > > from a
> > > > > > > > public server).
> > > > > > > >
> > > > > > > > However, we added full support for this feature
in the
last
> > version of
> > > > > the
> > > > > > CKEditor extension:
> > > > > >
> > > > >
> > > >
> >
http://extensions.xwiki.org/xwiki/bin/view/Extension/CKEditor+Integration
> > > > > > > > => if
you drag & drop an image in CKEditor, it is
> automatically
> > > > > > attached
> > > > > > > to
> > > > > > > > the wiki page.
> > > > > > > >
> > > > > > > > Please also note that drag & drop of images
currently
work
if
> > you
> > > > go to
> > > > > > > the
> > > > > > > > "attachments" tab of any page (while in
view mode) and
drop
>
your
> > > image
> > > > > > > there.
> > > > > >
> > > > > > hmm are you sure? I’m not aware of this feature. I just
tested
> it
> > > > and it
> > > > > > > didn’t work for me on 8.0M2.
> > > > > > >
> > > > > >
> > > > > > Tried it and it seems to work only if you drop the file
exactly
>
over
> > > the
> > > > > file upload field ("Browse" button or "No files
selected"
label,
> i.e.
> > > field
> > > > > with id "xwikiuploadfile"). This definitely needs to
be
improved.
> > > > > >
> > > > > > Personally, I would prefer we go full page Drag & Drop
support,
> > i.e.
> > > > if a
> > > > > > file is dropped in the XWiki browser tab, a popup asks the
user
> if
> > he
> > > > wants
> > > > > > to attach the dropped files to the current XWiki document.
> > Something
> > > > like
> > > > > > GitHub is doing when you can drop a file anywhere in the
tab
of
> an
> > > > XWiki
> > > > > > repository (and a commit form will show up for you to fill
> > details).
> > > > > >
> > > > >
> > > > > I agree that this would be nice too. However, it doesn't
mean
you
> > don't
> > > > > need it in edition mode. Having to switch back and forth
between
> view
and
> > > > edit because you forgot to upload a file would be tedious. It's
> needed in
> > > > both places.
> > >
> > > +1 to that.
> > >
> >
> > Maybe you`ve missed my next reply:
> > "My point here was that maybe we could make it a page-level feature
and
> > not
> > > an editor-level feature that each editor would have to implement.”
> >
> > I had read that but I misunderstood it as meaning that you were
> suggesting
> > that it shouldn’t be a feature in edit mode while you were just
saying
that
> it shouldn’t an *editor* feature.
>
> Personally I think we need editor-level drag and drop because there
are 2
> > different use cases:
> > * being able to insert an image in the content of a page
> > * being able to add an image as an attachment
> >
> > And whenever the content of a page is affected, then it has to be in
an
> > editor since that requires making
modification to the content and
then
> > letting the user make adjustements and
save the content.
> >
> > Thanks
> > -Vincent
> >
> > > It was about dropping a file in an XWiki tab, regardless of the
mode
> you
> > > are in (edit/view). That`s why I said you don`t need to necessarily
> > > implement it in editor X or Y and it could be a feature of the
XWiki
page
> itself.
>
> Thanks,
> Eduard
>
>
> > Thanks
> > -Vincent
> >
> > PS: I’ve opened
http://jira.xwiki.org/browse/XWIKI-13133 for the
issue
> > > with drag and drop on chrome.
> > >
> > > > Thanks,
> > > >
> > > > Guillaume
> > > >
> > > > Thanks,
> > > > > Eduard
> > > > >
> > > > > >
> > > > > > Thanks
> > > > > > -Vincent
> > > > > >
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Guillaume
> > > > > > >
> > > > > > > On Tue, Feb 23, 2016 at 11:57 AM, Eduard Moraru
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > Found this issue
http://jira.xwiki.org/browse/XWIKI-10026
> > > > > > > > >
> > > > > > > > > However, as far as I have tested it, it
works. Taking a
> > > > screenshot,
> > > > > > > copying
> > > > > > > > > it to the clicpboard and pasting in wysiwyg
produces an
> > > > > > [[image:data:]]
> > > > > > > > > type image.
> > > > > > > > >
> > > > > > > > > Then, right clicking on an image on a
website,
selecting
> > "Copy
> > > > Image"
> > > > > > > > > (Firefox) then going to wysiwyg and pasting
produces an
> > > > > > > [[image:http...]]
> > > > > > > > > type image.
> > > > > > > > >
> > > > > > > > > So copy/paste is one thing, which seems to
work pretty
> well,
> > > > while
> > > > > > > > > Drag&Drop is another and that would be a
nice to have
> > feature.
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Eduard
> > > > > > > > >
> > > > > > > > > On Tue, Feb 23, 2016 at 12:50 PM,
vincent(a)massol.net
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Hi Stuart,
> > > > > > > > > >
> > > > > > > > > > I agree that’s would be a very nice
feature addition:
> > ability
> > > > to
> > > > > > > drag and
> > > > > > > > > > drop images as attachments directly on
wiki pages
> (without
> > > > having
> > > > > > to
> > > > > > > go
> > > > > > > > > > through edit).
> > > > > > > > > >
> > > > > > > > > > Strangely I couldn’t find a jira issue
for this.
Would
be
> > > awesome
> > > > > if
> > > > > > you
> > > > > > > > > could create one at
http://jira.xwiki.org
> > > > > > > > >
> > > > > > > > > Thanks for the idea
> > > > > > > > > -Vincent
> > > > > > > > > On 23 Feb 2016 at 11:47:12, Stuart Stephen
(
> > > > > > > > stuart.stephen(a)tracegroup.com)
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Hi all,
> > > > > > > > >
> > > > > > > > > In various web applications these days it is
now
possible
> > to
> > > > copy
> > > > > > and
> > > > > > > > > > paste images into web pages which makes
the process
of
>
adding
> > > an
> > > > > > image
> > > > > > > > to a
> > > > > > > > > document online so much easier as you do not
need to
save
> it
> > > off
> > > > > > > > somewhere,
> > > > > > > > > then upload it. Copy and paste makes the
process so
much
> more
> > > > > > efficient.
> > > > > > > > >
> > > > > > > > > See the upload feature on
http://imgur.com/
for
example,
where
> > > > they
> > > > > also
> > > > > > > > support drag and drop.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Stuart
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users