14 Apr
2016
14 Apr
'16
10:26 a.m.
On Wed, Apr 13, 2016 at 9:10 AM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
--
Thomas Mortagne
On Tue, Apr 12, 2016 at 10:11 PM, Vincent Massol
<vincent(a)massol.net> wrote:
Hi Peter,
It's a delete not a save so modifying it would be useless. I guess the
intend here was to have the same kind of data than what you get with
DocumentDeletedEvent.
On 05 Apr 2016, at 19:28, Peter Huisman
<p.huisman(a)ximm.nl> wrote:
From the XWiki source code, I see there is a difference in passing a document to the
evenmanager:
The DocumentDeletingEvent is passing a “new
XWikiDocument(doc.getDocumentReference())"
The DocumentUpdatedEvent (as an example) is passing the doc (the actual XWikiDocument)
The difference is, that the Document passed in the DeleteEvent is a new XWikiDocument and
not the XWikiDocument that is about to be deleted.
Is there a reason why this difference exists?
he code in the XWiki class doing the notify has been there for a long time AFAICS:
om.notify(new DocumentDeletingEvent(doc.getDocumentReference()),
new XWikiDocument(doc.getDocumentReference()), context);
However, I think it’s not correct. I think it should pass the document and not a clone,
because an Event Listener should be able to modify the instance that’s going to be saved.
What is wrong and should be fixed is that the document
sent with the
event should have the real one as original document (exactly like it's
done for DocumentDeletedEvent).
Fixed in http://jira.xwiki.org/browse/XWIKI-13331.
So I’d open a bug for this. Let’s see if the others agree.
Thanks
-Vincent
--
Thomas Mortagne Br,
Peter
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users