On Thu, 31 Jan 2008 09:13:32 +0100, Vincent
Massol wrote
On Jan 31, 2008, at 7:41 AM, rssh wrote:
On Wed, 30 Jan 2008 23:24:21 +0100, Sergiu
Dumitriu wrote
> Hi,
>
> Velocity tools is not enabled yet. However, this is planned (I was
> about to do it in the 1.2 timeframe, but didn't have time to commit
> the code).
>
O - are you have ready patch ?
If yes, can you publish one ?
(I now need in velocity tools, so I can test this patch on 1.3
SNAPSHOT)
It's very simple. You just need to add the MathTool java bean
instance to the velocity context and you're done! No need for
velocity tools servlet or stuff like that.
-Vincent
Yes, but if we want more generalized stuff, than sintuation become a
little
more complex:
I think the 'right way' is to keep somewehere static instance of
ToolManager,
create and configure one from some well-known path (better
configurable) on
demand, than in VelocityRendere.prepareContext() merge new-created
context
with context of ToolManager.
(of course, if we want provide standard velocity-tool services,
which can be
externally configured)
The main reason I haven't been touching this part is because I've
written a new Velocity component in the new xwiki architecture and
I'd like to replace our current velocity code with it. The
component is in xwiki-core/xwiki-velocity if you want to have a look.
My idea would be to provide component configuration that allows
users to add any bean they want to the velocity context.
WDYT?