On Mar 6, 2013, at 7:19 PM, Sergiu Dumitriu <sergiu(a)xwiki.org> wrote:
On 03/06/2013 12:54 PM, Jeremie BOUSQUET wrote:
Hello guys,
So it's done, and I've published both versions 1.0.1 (from the original
from
xwiki.org) and 1.0.2 (wich fixes excessive empty lines inserted) both
to github and to nexus staging.
If someone could kindly promote those artifacts from Nexus staging, that
would be nice :-)
groupId: org.xwiki.contrib
artifactId: xwiki-macro-tabs
versions: 1.0.1 and 1.0.2
Very nice POM!
indeed!
Only thing I'd comment is to have consistent # of chars for indentation: in some
places you use 20 chars for indentation and at other places 6, and at others 1 and at
others 2 :)
We use 2 chars everywhere so I'd suggest to use 2 for not having too long lines.
Thanks
-Vincent
I tested the XAR, seems to be working fine. Repo
released:
http://nexus.xwiki.org/nexus/content/repositories/releases/org/xwiki/contriā¦
> Note: as I put "<xwiki.extension.name>Tabs
Macro</xwiki.extension.name>" in
> the pom, and page name on
xwiki.org is "Tabs Macro", I believe that if I
> "import" from Extension Repository, it should update the extension page
> accordingly, is this right ? Because the extension id is different now of
> course...