7 Dec
2010
7 Dec
'10
2:34 p.m.
On 11 November 2010 22:51, Vincent Massol <vincent(a)massol.net> wrote:
On Nov 11, 2010, at 3:42 PM, Florin Ciubotaru wrote:
it's
I'd like to get XWord working, even if it means hacking it myself.
Can anyone give me some pointers on what has to be done?
thanks
Paul
Hi,
On Thu, Nov 11, 2010 at 12:55 PM, Vincent Massol <vincent(a)massol.net>
wrote:
>
> On Nov 11, 2010, at 11:50 AM, Florin Ciubotaru wrote:
>
>> Hi Marius,
>>
>> On Thu, Nov 11, 2010 at 10:06 AM, Marius Dumitru Florea <
>> mariusdumitru.florea(a)xwiki.com> wrote:
>>
>>> Florin, I suspect you have to update the XHTML that XWord generates
when
>>> the user inserts an image to match
the rendering module expectations.
>>> See http://jira.xwiki.org/jira/browse/XWIKI-5554 . Starting with XE
2.5
>>> image and link markers (the XHTML
comments used by the rendering
module)
>>> use the same syntax. Let me know if
you need any help.
>>>
>>
>> Indeed, this could be the cause of the issue. I would have expected
this
>> behavior to be backwords compatible or
having the old one deprecated
for
>> several XWiki versions as we receive this
'formated' XHTML trough
public
>> APIs. At this point the conversion will
simply crash when used by an
> older
>> client.
>
> IMO we should check the version of XE when XWord connects to it and if
it's
not
compatible mention it.
WDYT?
XOffice already checks the XE version for several reasons. For this
particular issue, I'd prefer to implement the fix it rather then saying incompatible. First thing to do until a release
is done, is to at least
document this on the wiki.
The client relies on the XML-RPC and REST APIs which means that it should
be
compatible with the server as long as nothing
changes in the API specs.
I cannot confirm the exact cause of the issue yet. But based on the hint
from Marius I could say that the xhtml parser should have accepted the
old
image marker for several versions. XML-RPC is a
backwards compatible API,
once we introduced the conversion methods, it means we commit to having
them
working properly across several XWiki versions.
On the server side, in the rendering module, we have *voluntarily* broken
several APIs. See the release notes for 2.5:
http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise25#HAPI…
I don't know how this can affect you (i.e how this can affect the XMLRPC
module).
But if you produce XHTML on the XOffice side and if this XHTML contains
markers then the marker syntax has changed in 2.5.
Thanks
-Vincent