3 Mar
2010
3 Mar
'10
11:15 a.m.
Thanks Thomas
I made a JIRA entry against the Panels Application, and a trivial patch to fix
it. It's my first, so It'll be exciting to see what happens. :)
http://jira.xwiki.org/jira/secure/ManageAttachments.jspa?id=29978
-Joel Forsberg
On Tuesday 02 March 2010 20:20:01 Thomas Mortagne wrote:
On Tue, Mar 2, 2010 at 18:25, Sergiu Dumitriu
<sergiu(a)xwiki.com> wrote:
On 03/02/2010 05:01 PM, Joel Forsberg wrote:
No, this is valid because the job of $rdoc.displayTitle is to produce
xhtml content and theses are valid XML escapes. So you don't need to
use getXMLEncoded because any xml content is already properly escaped
(in xwiki/2.0 syntax).
When you want a plain text version of the title you should use
$rdoc.getRenderedTitle("plain/1.0").
Greetings
On my wiki using swedish characters for xwiki page titles give ugly but
working entries in all panels, e.g. "Backlinks" "Recent
modifications"
and "My recent modifications"
An example is having:
"Startsidor för våra intresseområden"
...instead of the correct:
"Startsidor för våra intresseområden"
Another example is putting thiss wiki code on top of a page:
= header that<look ugly> here =
The script responsible for for the texts in the panels is as follow:
<span class="panelitem">
<a href="$rdoc.getURL('view')">
$xwiki.getXMLEncoded($rdoc.displayTitle)
</a></span>
I've noticed that changing the third line into only $rdoc.displayTitle
will produce a nice looking entry, and $rdoc is set via
#set($rdoc = $xwiki.getDocument($docname).getTranslatedDocument())
Now, can anyone see a purpose of using getXMLEncoded() for this? As far
as I have seen, it only breaks things.
This is not caused by getXMLEncoded, it merely makes the problem
visible. This method must be used in order to prevent other problems:
Invalid XML, broken layout, XSS...
The problem is that the code inside getDisplayTitle wrongly uses a XML
escaping option. --
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users