26 Feb
2013
26 Feb
'13
3:38 p.m.
Hello,
I've been using the Tabs Macro [1], and have some feedback on it.
First a very positive because I really like that macro ;-)
But ... :
- in extension page [1], it is said that it's not compatible with 4.x,
though I use it without any issue on a 4.4.1 instance.
- only issue I have (already with XE 3.x) is that several empty lines are
added BEFORE the tabs.
The empty lines consist of 5 lines of :
<div class="wikimodel-emptyline"></div>
To fix the issue, I updated the Macro.TabsMacro macro code, there was a
misplaced empty line in it:
///// BEGIN //////
{{velocity}}
$xwiki.jsx.use("Macro.TabsMacro")
#set ($tabsSortedMapString = $context.macro.params.idsToLabels)
## split incoming string into 2 velocity arrays
#set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
#set( $tabIdsArray = [])
#set( $tabNamesArray = [])
#foreach($tabEntryString in $tabMapEntriesStringArray )
#if ("$!tabEntryString" == "" )
## ignore null or empty (see
http://wiki.apache.org/velocity/CheckingForNull)
#else
#set ($tabEntryArray = $tabEntryString.trim().split('='))
#if ($tabEntryArray.size()!=2)
{{error}}Parameter $tabEntryString is not a valid key=value
pair in the provided map: $tabsSortedMapString{{/error}}
#else
#set ($addResult =
$tabIdsArray.add($tabEntryArray.get(0).trim()))
#set ($addResult =
$tabNamesArray.add($tabEntryArray.get(1).trim()))
#end
(*)
#end
#end
## generate tabs (**)
{{html}}
<div class="floatcontainer">
///// END /////
I had to remove line marked with (*), and add 2 empty lines right after
(**). This result in having only 1 empty line added before the tabs, which
is not perfect but better.
As I didn't find a JIRA project for this macro, I'm posting it here ...
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
26 Feb
26 Feb
4:23 p.m.
New subject: [xwiki-users] Tabs Macro
Hi Jeremie,
On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com> wrote:
Hello,
I've been using the Tabs Macro [1], and have some feedback on it.
First a very positive because I really like that macro ;-)
But ... :
- in extension page [1], it is said that it's not compatible with 4.x,
though I use it without any issue on a 4.4.1 instance.
- only issue I have (already with XE 3.x) is that several empty lines are
added BEFORE the tabs.
The empty lines consist of 5 lines of :
<div class="wikimodel-emptyline"></div>
To fix the issue, I updated the Macro.TabsMacro macro code, there was a
misplaced empty line in it:
///// BEGIN //////
{{velocity}}
$xwiki.jsx.use("Macro.TabsMacro")
#set ($tabsSortedMapString = $context.macro.params.idsToLabels)
## split incoming string into 2 velocity arrays
#set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
#set( $tabIdsArray = [])
#set( $tabNamesArray = [])
#foreach($tabEntryString in $tabMapEntriesStringArray )
#if ("$!tabEntryString" == "" )
## ignore null or empty (see
http://wiki.apache.org/velocity/CheckingForNull)
#else
#set ($tabEntryArray = $tabEntryString.trim().split('='))
#if ($tabEntryArray.size()!=2)
{{error}}Parameter $tabEntryString is not a valid key=value
pair in the provided map: $tabsSortedMapString{{/error}}
#else
#set ($addResult =
$tabIdsArray.add($tabEntryArray.get(0).trim()))
#set ($addResult =
$tabNamesArray.add($tabEntryArray.get(1).trim()))
#end
(*)
#end
#end
## generate tabs (**)
{{html}}
<div class="floatcontainer">
///// END /////
I had to remove line marked with (*), and add 2 empty lines right after
(**). This result in having only 1 empty line added before the tabs, which
is not perfect but better.
As I didn't find a JIRA project for this macro, I'm posting it here …
Cool
What would be great Jeremie is if you could contact the creators of the Tabs Macro
extension and ask them if they're ok to publish their project on xwiki-contrib (or on
their own github which we would fork in xwiki-contrib's github).
Alternatively what you could do, is simply set up a project in xwiki-contrib based on the
published 1.0.1 sources and just let the original creators know about it (this is possible
since the sources are under LGPL).
WDYT?
Thanks
-Vincent
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
5:07 p.m.
New subject: [xwiki-users] Tabs Macro
Hi Vincent,
Ok, I'll warn them about that, and see where it gets ...
BR,
Jeremie
2013/2/26 Vincent Massol <vincent(a)massol.net>
Hi Jeremie,
On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
wrote:
Hello,
I've been using the Tabs Macro [1], and have some feedback on it.
First a very positive because I really like that macro ;-)
But ... :
- in extension page [1], it is said that it's not compatible with 4.x,
though I use it without any issue on a 4.4.1 instance.
- only issue I have (already with XE 3.x) is that several empty lines are
added BEFORE the tabs.
The empty lines consist of 5 lines of :
<div class="wikimodel-emptyline"></div>
To fix the issue, I updated the Macro.TabsMacro macro code, there was a
misplaced empty line in it:
///// BEGIN //////
{{velocity}}
$xwiki.jsx.use("Macro.TabsMacro")
#set ($tabsSortedMapString = $context.macro.params.idsToLabels)
## split incoming string into 2 velocity arrays
#set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
#set( $tabIdsArray = [])
#set( $tabNamesArray = [])
#foreach($tabEntryString in $tabMapEntriesStringArray )
#if ("$!tabEntryString" == "" )
## ignore null or empty (see
http://wiki.apache.org/velocity/CheckingForNull)
#else
#set ($tabEntryArray = $tabEntryString.trim().split('='))
#if ($tabEntryArray.size()!=2)
{{error}}Parameter $tabEntryString is not a valid
key=value
pair in the provided map:
$tabsSortedMapString{{/error}}
#else
#set ($addResult =
$tabIdsArray.add($tabEntryArray.get(0).trim()))
#set ($addResult =
$tabNamesArray.add($tabEntryArray.get(1).trim()))
#end
(*)
#end
#end
## generate tabs (**)
{{html}}
<div class="floatcontainer">
///// END /////
I had to remove line marked with (*), and add 2 empty lines right after
(**). This result in having only 1 empty line added before the tabs,
which
is not perfect but better.
As I didn't find a JIRA project for this macro, I'm posting it here …
Cool
What would be great Jeremie is if you could contact the creators of the
Tabs Macro extension and ask them if they're ok to publish their project on
xwiki-contrib (or on their own github which we would fork in
xwiki-contrib's github).
Alternatively what you could do, is simply set up a project in
xwiki-contrib based on the published 1.0.1 sources and just let the
original creators know about it (this is possible since the sources are
under LGPL).
WDYT?
Thanks
-Vincent
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
5:09 p.m.
New subject: [xwiki-users] Tabs Macro
Hi guys :)
"Creators" are OK with either approach ;)
We're glad that it's not only us who make use of the macro :)
I have put "not compatible" with 4.x, because the macro refused to work on our
4.2 installation. After investigation it turned out that for some reason JS
extension's "Use this extension" property (of the macro page) was set to
"On demand" instead of "Always", so it should be updated as well in
the repository.
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On Behalf Of Vincent
Massol
Sent: Tuesday, February 26, 2013 17:24 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi Jeremie,
On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com> wrote:
Hello,
I've been using the Tabs Macro [1], and have some feedback on it.
First a very positive because I really like that macro ;-)
But ... :
- in extension page [1], it is said that it's not compatible with 4.x,
though I use it without any issue on a 4.4.1 instance.
- only issue I have (already with XE 3.x) is that several empty lines
are added BEFORE the tabs.
The empty lines consist of 5 lines of :
<div class="wikimodel-emptyline"></div>
To fix the issue, I updated the Macro.TabsMacro macro code, there was
a misplaced empty line in it:
///// BEGIN //////
{{velocity}}
$xwiki.jsx.use("Macro.TabsMacro")
#set ($tabsSortedMapString = $context.macro.params.idsToLabels)
## split incoming string into 2 velocity arrays
#set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
#set( $tabIdsArray = [])
#set( $tabNamesArray = [])
#foreach($tabEntryString in $tabMapEntriesStringArray )
#if ("$!tabEntryString" == "" )
## ignore null or empty (see
http://wiki.apache.org/velocity/CheckingForNull)
#else
#set ($tabEntryArray = $tabEntryString.trim().split('='))
#if ($tabEntryArray.size()!=2)
{{error}}Parameter $tabEntryString is not a valid
key=value pair in the provided map: $tabsSortedMapString{{/error}}
#else
#set ($addResult =
$tabIdsArray.add($tabEntryArray.get(0).trim()))
#set ($addResult =
$tabNamesArray.add($tabEntryArray.get(1).trim()))
#end
(*)
#end
#end
## generate tabs (**)
{{html}}
<div class="floatcontainer">
///// END /////
I had to remove line marked with (*), and add 2 empty lines right
after (**). This result in having only 1 empty line added before the
tabs, which is not perfect but better.
As I didn't find a JIRA project for this macro, I'm posting it here ...
Cool
What would be great Jeremie is if you could contact the creators of the Tabs Macro
extension and ask them if they're ok to publish their project on xwiki-contrib (or on
their own github which we would fork in xwiki-contrib's github).
Alternatively what you could do, is simply set up a project in xwiki-contrib based on the
published 1.0.1 sources and just let the original creators know about it (this is possible
since the sources are under LGPL).
WDYT?
Thanks
-Vincent
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
5:11 p.m.
New subject: [xwiki-users] Tabs Macro
Hi Roman,
On Feb 26, 2013, at 5:09 PM, Roman Muntyanu <rmuntyan(a)softserveinc.com> wrote:
Hi guys :)
"Creators" are OK with either approach ;)
We're glad that it's not only us who make use of the macro :)
Great!
If you give me your github id I can add you to the xwikiorg group for xwiki-contrib so
that you have write access to this contrib project when it's created!
Thanks
-Vincent
I have put "not compatible" with 4.x,
because the macro refused to work on our 4.2 installation. After investigation it turned
out that for some reason JS extension's "Use this extension" property (of
the macro page) was set to "On demand" instead of "Always", so it
should be updated as well in the repository.
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On Behalf Of Vincent
Massol
Sent: Tuesday, February 26, 2013 17:24 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi Jeremie,
On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com> wrote:
Hello,
I've been using the Tabs Macro [1], and have some feedback on it.
First a very positive because I really like that macro ;-)
But ... :
- in extension page [1], it is said that it's not compatible with 4.x,
though I use it without any issue on a 4.4.1 instance.
- only issue I have (already with XE 3.x) is that several empty lines
are added BEFORE the tabs.
The empty lines consist of 5 lines of :
<div class="wikimodel-emptyline"></div>
To fix the issue, I updated the Macro.TabsMacro macro code, there was
a misplaced empty line in it:
///// BEGIN //////
{{velocity}}
$xwiki.jsx.use("Macro.TabsMacro")
#set ($tabsSortedMapString = $context.macro.params.idsToLabels)
## split incoming string into 2 velocity arrays
#set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
#set( $tabIdsArray = [])
#set( $tabNamesArray = [])
#foreach($tabEntryString in $tabMapEntriesStringArray )
#if ("$!tabEntryString" == "" )
## ignore null or empty (see
http://wiki.apache.org/velocity/CheckingForNull)
#else
#set ($tabEntryArray = $tabEntryString.trim().split('='))
#if ($tabEntryArray.size()!=2)
{{error}}Parameter $tabEntryString is not a valid
key=value pair in the provided map: $tabsSortedMapString{{/error}}
#else
#set ($addResult =
$tabIdsArray.add($tabEntryArray.get(0).trim()))
#set ($addResult =
$tabNamesArray.add($tabEntryArray.get(1).trim()))
#end
(*)
#end
#end
## generate tabs (**)
{{html}}
<div class="floatcontainer">
///// END /////
I had to remove line marked with (*), and add 2 empty lines right
after (**). This result in having only 1 empty line added before the
tabs, which is not perfect but better.
As I didn't find a JIRA project for this macro, I'm posting it here ...
Cool
What would be great Jeremie is if you could contact the creators of the Tabs Macro
extension and ask them if they're ok to publish their project on xwiki-contrib (or on
their own github which we would fork in xwiki-contrib's github).
Alternatively what you could do, is simply set up a project in xwiki-contrib based on the
published 1.0.1 sources and just let the original creators know about it (this is possible
since the sources are under LGPL).
WDYT?
Thanks
-Vincent
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
5:28 p.m.
New subject: [xwiki-users] Tabs Macro
Its "coldserenity"
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On Behalf Of Vincent
Massol
Sent: Tuesday, February 26, 2013 18:12 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi Roman,
On Feb 26, 2013, at 5:09 PM, Roman Muntyanu <rmuntyan(a)softserveinc.com> wrote:
Hi guys :)
"Creators" are OK with either approach ;) We're glad that it's not
only us who make use of the macro :)
Great!
If you give me your github id I can add you to the xwikiorg group for xwiki-contrib so
that you have write access to this contrib project when it's created!
Thanks
-Vincent
I have put "not compatible" with 4.x,
because the macro refused to work on our 4.2 installation. After investigation it turned
out that for some reason JS extension's "Use this extension" property (of
the macro page) was set to "On demand" instead of "Always", so it
should be updated as well in the repository.
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On
Behalf Of Vincent Massol
Sent: Tuesday, February 26, 2013 17:24 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi Jeremie,
On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com> wrote:
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
Hello,
I've been using the Tabs Macro [1], and have some feedback on it.
First a very positive because I really like that macro ;-)
But ... :
- in extension page [1], it is said that it's not compatible with
4.x, though I use it without any issue on a 4.4.1 instance.
- only issue I have (already with XE 3.x) is that several empty lines
are added BEFORE the tabs.
The empty lines consist of 5 lines of :
<div class="wikimodel-emptyline"></div>
To fix the issue, I updated the Macro.TabsMacro macro code, there was
a misplaced empty line in it:
///// BEGIN //////
{{velocity}}
$xwiki.jsx.use("Macro.TabsMacro")
#set ($tabsSortedMapString = $context.macro.params.idsToLabels)
## split incoming string into 2 velocity arrays
#set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
#set( $tabIdsArray = [])
#set( $tabNamesArray = [])
#foreach($tabEntryString in $tabMapEntriesStringArray )
#if ("$!tabEntryString" == "" )
## ignore null or empty (see
http://wiki.apache.org/velocity/CheckingForNull)
#else
#set ($tabEntryArray = $tabEntryString.trim().split('='))
#if ($tabEntryArray.size()!=2)
{{error}}Parameter $tabEntryString is not a valid
key=value pair in the provided map: $tabsSortedMapString{{/error}}
#else
#set ($addResult =
$tabIdsArray.add($tabEntryArray.get(0).trim()))
#set ($addResult =
$tabNamesArray.add($tabEntryArray.get(1).trim()))
#end
(*)
#end
#end
## generate tabs (**)
{{html}}
<div class="floatcontainer">
///// END /////
I had to remove line marked with (*), and add 2 empty lines right
after (**). This result in having only 1 empty line added before the
tabs, which is not perfect but better.
As I didn't find a JIRA project for this macro, I'm posting it here ...
Cool
What would be great Jeremie is if you could contact the creators of the Tabs Macro
extension and ask them if they're ok to publish their project on xwiki-contrib (or on
their own github which we would fork in xwiki-contrib's github).
Alternatively what you could do, is simply set up a project in xwiki-contrib based on the
published 1.0.1 sources and just let the original creators know about it (this is possible
since the sources are under LGPL).
WDYT?
Thanks
-Vincent
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
6:51 p.m.
New subject: [xwiki-users] Tabs Macro
Hi guys,
I've created a github repository for the tabs macro on xwiki-contrib:
https://github.com/xwiki-contrib/macro-tabs
Now I'll leave it to you to create the maven build there for it and to move the
sources of the tabs macro in it.
Thanks
-Vincent
PS: I've added Roman to the xwikiorg group so he has write access to it.
On Feb 26, 2013, at 5:28 PM, Roman Muntyanu <rmuntyan(a)softserveinc.com> wrote:
Its "coldserenity"
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On Behalf Of Vincent
Massol
Sent: Tuesday, February 26, 2013 18:12 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi Roman,
On Feb 26, 2013, at 5:09 PM, Roman Muntyanu <rmuntyan(a)softserveinc.com> wrote:
Hi guys :)
"Creators" are OK with either approach ;) We're glad that it's not
only us who make use of the macro :)
Great!
If you give me your github id I can add you to the xwikiorg group for xwiki-contrib so
that you have write access to this contrib project when it's created!
Thanks
-Vincent
> I have put "not compatible" with 4.x, because the macro refused to work on
our 4.2 installation. After investigation it turned out that for some reason JS
extension's "Use this extension" property (of the macro page) was set to
"On demand" instead of "Always", so it should be updated as well in
the repository.
>
> -----Original Message-----
> From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On
> Behalf Of Vincent Massol
> Sent: Tuesday, February 26, 2013 17:24 PM
> To: XWiki Users
> Subject: Re: [xwiki-users] Tabs Macro
>
> Hi Jeremie,
>
> On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
wrote:
>
>> Hello,
>>
>> I've been using the Tabs Macro [1], and have some feedback on it.
>>
>> First a very positive because I really like that macro ;-)
>>
>> But ... :
>> - in extension page [1], it is said that it's not compatible with
>> 4.x, though I use it without any issue on a 4.4.1 instance.
>> - only issue I have (already with XE 3.x) is that several empty lines
>> are added BEFORE the tabs.
>>
>> The empty lines consist of 5 lines of :
>> <div class="wikimodel-emptyline"></div>
>>
>> To fix the issue, I updated the Macro.TabsMacro macro code, there was
>> a misplaced empty line in it:
>>
>> ///// BEGIN //////
>> {{velocity}}
>> $xwiki.jsx.use("Macro.TabsMacro")
>> #set ($tabsSortedMapString = $context.macro.params.idsToLabels)
>> ## split incoming string into 2 velocity arrays
>> #set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
>> #set( $tabIdsArray = [])
>> #set( $tabNamesArray = [])
>> #foreach($tabEntryString in $tabMapEntriesStringArray )
>> #if ("$!tabEntryString" == "" )
>> ## ignore null or empty (see
>> http://wiki.apache.org/velocity/CheckingForNull)
>> #else
>> #set ($tabEntryArray = $tabEntryString.trim().split('='))
>> #if ($tabEntryArray.size()!=2)
>> {{error}}Parameter $tabEntryString is not a valid
>> key=value pair in the provided map: $tabsSortedMapString{{/error}}
>> #else
>> #set ($addResult =
>> $tabIdsArray.add($tabEntryArray.get(0).trim()))
>> #set ($addResult =
>> $tabNamesArray.add($tabEntryArray.get(1).trim()))
>> #end
>> (*)
>> #end
>> #end
>> ## generate tabs (**)
>> {{html}}
>> <div class="floatcontainer">
>> ///// END /////
>>
>> I had to remove line marked with (*), and add 2 empty lines right
>> after (**). This result in having only 1 empty line added before the
>> tabs, which is not perfect but better.
>>
>> As I didn't find a JIRA project for this macro, I'm posting it here ...
>
> Cool
>
> What would be great Jeremie is if you could contact the creators of the Tabs Macro
extension and ask them if they're ok to publish their project on xwiki-contrib (or on
their own github which we would fork in xwiki-contrib's github).
>
> Alternatively what you could do, is simply set up a project in xwiki-contrib based on
the published 1.0.1 sources and just let the original creators know about it (this is
possible since the sources are under LGPL).
>
> WDYT?
>
> Thanks
> -Vincent
>
>>
>> BR,
>> Jeremie
>>
>> [1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
4 Mar
4 Mar
12:05 p.m.
New subject: [xwiki-users] Tabs Macro
Hi again,
2013/2/26 Roman Muntyanu <rmuntyan(a)softserveinc.com>
Hi guys :)
"Creators" are OK with either approach ;)
We're glad that it's not only us who make use of the macro :)
I have put "not compatible" with 4.x, because the macro refused to work on
our 4.2 installation. After investigation it turned out that for some
reason JS extension's "Use this extension" property (of the macro page)
was
set to "On demand" instead of "Always", so it should be updated as
well in
the repository.
Indeed, but first line of macro content is:
$xwiki.jsx.use("Macro.TabsMacro")
So "on demand" should work properly, as the JSX is used whenever the macro
is used ?
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On Behalf
Of Vincent Massol
Sent: Tuesday, February 26, 2013 17:24 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi Jeremie,
On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
wrote:
Hello,
I've been using the Tabs Macro [1], and have some feedback on it.
First a very positive because I really like that macro ;-)
But ... :
- in extension page [1], it is said that it's not compatible with 4.x,
though I use it without any issue on a 4.4.1 instance.
- only issue I have (already with XE 3.x) is that several empty lines
are added BEFORE the tabs.
The empty lines consist of 5 lines of :
<div class="wikimodel-emptyline"></div>
To fix the issue, I updated the Macro.TabsMacro macro code, there was
a misplaced empty line in it:
///// BEGIN //////
{{velocity}}
$xwiki.jsx.use("Macro.TabsMacro")
#set ($tabsSortedMapString = $context.macro.params.idsToLabels)
## split incoming string into 2 velocity arrays
#set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
#set( $tabIdsArray = [])
#set( $tabNamesArray = [])
#foreach($tabEntryString in $tabMapEntriesStringArray )
#if ("$!tabEntryString" == "" )
## ignore null or empty (see
http://wiki.apache.org/velocity/CheckingForNull)
#else
#set ($tabEntryArray = $tabEntryString.trim().split('='))
#if ($tabEntryArray.size()!=2)
{{error}}Parameter $tabEntryString is not a valid
key=value pair in the provided map: $tabsSortedMapString{{/error}}
#else
#set ($addResult =
$tabIdsArray.add($tabEntryArray.get(0).trim()))
#set ($addResult =
$tabNamesArray.add($tabEntryArray.get(1).trim()))
#end
(*)
#end
#end
## generate tabs (**)
{{html}}
<div class="floatcontainer">
///// END /////
I had to remove line marked with (*), and add 2 empty lines right
after (**). This result in having only 1 empty line added before the
tabs, which is not perfect but better.
As I didn't find a JIRA project for this macro, I'm posting it here ...
Cool
What would be great Jeremie is if you could contact the creators of the
Tabs Macro extension and ask them if they're ok to publish their project on
xwiki-contrib (or on their own github which we would fork in
xwiki-contrib's github).
Alternatively what you could do, is simply set up a project in
xwiki-contrib based on the published 1.0.1 sources and just let the
original creators know about it (this is possible since the sources are
under LGPL).
WDYT?
Thanks
-Vincent
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
12:24 p.m.
New subject: [xwiki-users] Tabs Macro
Hi,
BTW, I prepared a working build for the macro, retrieving sources for
version 1.0.1 from xar.
I chose the following coordinates for the build:
<groupId>org.xwiki.contrib</groupId>
<artifactId>xwiki-macro-tabs</artifactId>
<version>1.0.1</version>
It worked ok when importing the generated xar in a 4.4.1 XE.
May I push it to the contrib project ? Or Roman if you prefer I can send it
to you, so you can push it by yourself.
BR,
Jeremie
2013/3/4 Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
Hi again,
2013/2/26 Roman Muntyanu <rmuntyan(a)softserveinc.com>
Hi guys :)
"Creators" are OK with either approach ;)
We're glad that it's not only us who make use of the macro :)
I have put "not compatible" with 4.x, because the macro refused to work
on our 4.2 installation. After investigation it turned out that for some
reason JS extension's "Use this extension" property (of the macro page)
was
set to "On demand" instead of "Always", so it should be updated as
well in
the repository.
Indeed, but first line of macro content is:
$xwiki.jsx.use("Macro.TabsMacro")
So "on demand" should work properly, as the JSX is used whenever the macro
is used ?
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On Behalf
Of Vincent Massol
Sent: Tuesday, February 26, 2013 17:24 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi Jeremie,
On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
wrote:
Hello,
I've been using the Tabs Macro [1], and have some feedback on it.
First a very positive because I really like that macro ;-)
But ... :
- in extension page [1], it is said that it's not compatible with 4.x,
though I use it without any issue on a 4.4.1 instance.
- only issue I have (already with XE 3.x) is that several empty lines
are added BEFORE the tabs.
The empty lines consist of 5 lines of :
<div class="wikimodel-emptyline"></div>
To fix the issue, I updated the Macro.TabsMacro macro code, there was
a misplaced empty line in it:
///// BEGIN //////
{{velocity}}
$xwiki.jsx.use("Macro.TabsMacro")
#set ($tabsSortedMapString = $context.macro.params.idsToLabels)
## split incoming string into 2 velocity arrays
#set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
#set( $tabIdsArray = [])
#set( $tabNamesArray = [])
#foreach($tabEntryString in $tabMapEntriesStringArray )
#if ("$!tabEntryString" == "" )
## ignore null or empty (see
http://wiki.apache.org/velocity/CheckingForNull)
#else
#set ($tabEntryArray = $tabEntryString.trim().split('='))
#if ($tabEntryArray.size()!=2)
{{error}}Parameter $tabEntryString is not a valid
key=value pair in the provided map: $tabsSortedMapString{{/error}}
#else
#set ($addResult =
$tabIdsArray.add($tabEntryArray.get(0).trim()))
#set ($addResult =
$tabNamesArray.add($tabEntryArray.get(1).trim()))
#end
(*)
#end
#end
## generate tabs (**)
{{html}}
<div class="floatcontainer">
///// END /////
I had to remove line marked with (*), and add 2 empty lines right
after (**). This result in having only 1 empty line added before the
tabs, which is not perfect but better.
As I didn't find a JIRA project for this macro, I'm posting it here ...
Cool
What would be great Jeremie is if you could contact the creators of the
Tabs Macro extension and ask them if they're ok to publish their project on
xwiki-contrib (or on their own github which we would fork in
xwiki-contrib's github).
Alternatively what you could do, is simply set up a project in
xwiki-contrib based on the published 1.0.1 sources and just let the
original creators know about it (this is possible since the sources are
under LGPL).
WDYT?
Thanks
-Vincent
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
1:03 p.m.
New subject: [xwiki-users] Tabs Macro
Jeremie, I trust it to you ;)
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On Behalf Of Jeremie
BOUSQUET
Sent: Monday, March 04, 2013 13:25 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi,
BTW, I prepared a working build for the macro, retrieving sources for version 1.0.1 from
xar.
I chose the following coordinates for the build:
<groupId>org.xwiki.contrib</groupId>
<artifactId>xwiki-macro-tabs</artifactId>
<version>1.0.1</version>
It worked ok when importing the generated xar in a 4.4.1 XE.
May I push it to the contrib project ? Or Roman if you prefer I can send it to you, so you
can push it by yourself.
BR,
Jeremie
2013/3/4 Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
Hi again,
2013/2/26 Roman Muntyanu <rmuntyan(a)softserveinc.com>
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
Hi guys :)
"Creators" are OK with either approach ;) We're glad that it's not
only us who make use of the macro :)
I have put "not compatible" with 4.x, because the macro refused to
work on our 4.2 installation. After investigation it turned out that
for some reason JS extension's "Use this extension" property (of the
macro page) was set to "On demand" instead of "Always", so it should
be updated as well in the repository.
Indeed, but first line of macro content is:
$xwiki.jsx.use("Macro.TabsMacro")
So "on demand" should work properly, as the JSX is used whenever the
macro is used ?
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On
Behalf Of Vincent Massol
Sent: Tuesday, February 26, 2013 17:24 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi Jeremie,
On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET
<jeremie.bousquet(a)gmail.com>
wrote:
Hello,
I've been using the Tabs Macro [1], and have some feedback on it.
First a very positive because I really like that macro ;-)
But ... :
- in extension page [1], it is said that it's not compatible with
4.x, though I use it without any issue on a 4.4.1 instance.
- only issue I have (already with XE 3.x) is that several empty
lines are added BEFORE the tabs.
The empty lines consist of 5 lines of :
<div class="wikimodel-emptyline"></div>
To fix the issue, I updated the Macro.TabsMacro macro code, there
was a misplaced empty line in it:
///// BEGIN //////
{{velocity}}
$xwiki.jsx.use("Macro.TabsMacro")
#set ($tabsSortedMapString = $context.macro.params.idsToLabels)
## split incoming string into 2 velocity arrays
#set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
#set( $tabIdsArray = [])
#set( $tabNamesArray = [])
#foreach($tabEntryString in $tabMapEntriesStringArray )
#if ("$!tabEntryString" == "" )
## ignore null or empty (see
http://wiki.apache.org/velocity/CheckingForNull)
#else
#set ($tabEntryArray = $tabEntryString.trim().split('='))
#if ($tabEntryArray.size()!=2)
{{error}}Parameter $tabEntryString is not a valid
key=value pair in the provided map: $tabsSortedMapString{{/error}}
#else
#set ($addResult =
$tabIdsArray.add($tabEntryArray.get(0).trim()))
#set ($addResult =
$tabNamesArray.add($tabEntryArray.get(1).trim()))
#end
(*)
#end
#end
## generate tabs (**)
{{html}}
<div class="floatcontainer">
///// END /////
I had to remove line marked with (*), and add 2 empty lines right
after (**). This result in having only 1 empty line added before
the tabs, which is not perfect but better.
As I didn't find a JIRA project for this macro, I'm posting it here ...
Cool
What would be great Jeremie is if you could contact the creators of
the Tabs Macro extension and ask them if they're ok to publish their
project on xwiki-contrib (or on their own github which we would fork
in xwiki-contrib's github).
Alternatively what you could do, is simply set up a project in
xwiki-contrib based on the published 1.0.1 sources and just let the
original creators know about it (this is possible since the sources
are under LGPL).
WDYT?
Thanks
-Vincent
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
6 Mar
6 Mar
6:54 p.m.
New subject: [xwiki-users] Tabs Macro
Hello guys,
So it's done, and I've published both versions 1.0.1 (from the original
from xwiki.org) and 1.0.2 (wich fixes excessive empty lines inserted) both
to github and to nexus staging.
If someone could kindly promote those artifacts from Nexus staging, that
would be nice :-)
groupId: org.xwiki.contrib
artifactId: xwiki-macro-tabs
versions: 1.0.1 and 1.0.2
Note: as I put "<xwiki.extension.name>Tabs
Macro</xwiki.extension.name>" in
the pom, and page name on xwiki.org is "Tabs Macro", I believe that if I
"import" from Extension Repository, it should update the extension page
accordingly, is this right ? Because the extension id is different now of
course...
BR,
Jeremie
2013/3/4 Roman Muntyanu <rmuntyan(a)softserveinc.com>
Jeremie, I trust it to you ;)
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On Behalf
Of Jeremie BOUSQUET
Sent: Monday, March 04, 2013 13:25 PM
To: XWiki Users
Subject: Re: [xwiki-users] Tabs Macro
Hi,
BTW, I prepared a working build for the macro, retrieving sources for
version 1.0.1 from xar.
I chose the following coordinates for the build:
<groupId>org.xwiki.contrib</groupId>
<artifactId>xwiki-macro-tabs</artifactId>
<version>1.0.1</version>
It worked ok when importing the generated xar in a 4.4.1 XE.
May I push it to the contrib project ? Or Roman if you prefer I can send
it to you, so you can push it by yourself.
BR,
Jeremie
2013/3/4 Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
Hi again,
2013/2/26 Roman Muntyanu <rmuntyan(a)softserveinc.com>
...
Hi guys :)
"Creators" are OK with either approach ;) We're glad that it's not
only us who make use of the macro :)
I have put "not compatible" with 4.x, because the macro refused to
work on our 4.2 installation. After investigation it turned out that
for some reason JS extension's "Use this extension" property (of the
macro page) was set to "On demand" instead of "Always", so it should
be updated as well in the repository.
Indeed, but first line of macro content is:
$xwiki.jsx.use("Macro.TabsMacro")
So "on demand" should work properly, as the JSX is used whenever the
macro is used ?
>
> -----Original Message-----
> From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org] On
> Behalf Of Vincent Massol
> Sent: Tuesday, February 26, 2013 17:24 PM
> To: XWiki Users
> Subject: Re: [xwiki-users] Tabs Macro
>
> Hi Jeremie,
>
> On Feb 26, 2013, at 3:38 PM, Jeremie BOUSQUET
> <jeremie.bousquet(a)gmail.com>
> wrote:
>
> > Hello,
> >
> > I've been using the Tabs Macro [1], and have some feedback on it.
> >
> > First a very positive because I really like that macro ;-)
> >
> > But ... :
> > - in extension page [1], it is said that it's not compatible with
> > 4.x, though I use it without any issue on a 4.4.1 instance.
> > - only issue I have (already with XE 3.x) is that several empty
> > lines are added BEFORE the tabs.
> >
> > The empty lines consist of 5 lines of :
> > <div class="wikimodel-emptyline"></div>
> >
> > To fix the issue, I updated the Macro.TabsMacro macro code, there
> > was a misplaced empty line in it:
> >
> > ///// BEGIN //////
> > {{velocity}}
> > $xwiki.jsx.use("Macro.TabsMacro")
> > #set ($tabsSortedMapString = $context.macro.params.idsToLabels)
> > ## split incoming string into 2 velocity arrays
> > #set ($tabMapEntriesStringArray = $tabsSortedMapString.split(','))
> > #set( $tabIdsArray = [])
> > #set( $tabNamesArray = [])
> > #foreach($tabEntryString in $tabMapEntriesStringArray )
> > #if ("$!tabEntryString" == "" )
> > ## ignore null or empty (see
> > http://wiki.apache.org/velocity/CheckingForNull)
> > #else
> > #set ($tabEntryArray = $tabEntryString.trim().split('='))
> > #if ($tabEntryArray.size()!=2)
> > {{error}}Parameter $tabEntryString is not a valid
> > key=value pair in the provided map: $tabsSortedMapString{{/error}}
> > #else
> > #set ($addResult =
> > $tabIdsArray.add($tabEntryArray.get(0).trim()))
> > #set ($addResult =
> > $tabNamesArray.add($tabEntryArray.get(1).trim()))
> > #end
> > (*)
> > #end
> > #end
> > ## generate tabs (**)
> > {{html}}
> > <div class="floatcontainer">
> > ///// END /////
> >
> > I had to remove line marked with (*), and add 2 empty lines right
> > after (**). This result in having only 1 empty line added before
> > the tabs, which is not perfect but better.
> >
> > As I didn't find a JIRA project for this macro, I'm posting it here
Cool
What would be great Jeremie is if you could contact the creators of
the Tabs Macro extension and ask them if they're ok to publish their
project on xwiki-contrib (or on their own github which we would fork
in xwiki-contrib's github).
Alternatively what you could do, is simply set up a project in
xwiki-contrib based on the published 1.0.1 sources and just let the
original creators know about it (this is possible since the sources
are under LGPL).
WDYT?
Thanks
-Vincent
BR,
Jeremie
[1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tabs+Macro
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
7:19 p.m.
New subject: [xwiki-users] Tabs Macro
On 03/06/2013 12:54 PM, Jeremie BOUSQUET wrote:
Hello guys,
So it's done, and I've published both versions 1.0.1 (from the original
from xwiki.org) and 1.0.2 (wich fixes excessive empty lines inserted) both
to github and to nexus staging.
If someone could kindly promote those artifacts from Nexus staging, that
would be nice :-)
groupId: org.xwiki.contrib
artifactId: xwiki-macro-tabs
versions: 1.0.1 and 1.0.2
Very nice POM!
I tested the XAR, seems to be working fine. Repo released:
http://nexus.xwiki.org/nexus/content/repositories/releases/org/xwiki/contri…
Note: as I put "<xwiki.extension.name>Tabs
Macro</xwiki.extension.name>" in
the pom, and page name on xwiki.org is "Tabs Macro", I believe that if I
"import" from Extension Repository, it should update the extension page
accordingly, is this right ? Because the extension id is different now of
course...
--
Sergiu Dumitriu
http://purl.org/net/sergiu
7:28 p.m.
New subject: [xwiki-users] Tabs Macro
Many thanks Sergiu !
Le 6 mars 2013 19:20, "Sergiu Dumitriu" <sergiu(a)xwiki.org> a écrit :
On 03/06/2013 12:54 PM, Jeremie BOUSQUET wrote:
Hello guys,
So it's done, and I've published both versions 1.0.1 (from the original
from xwiki.org) and 1.0.2 (wich fixes excessive empty lines inserted)
both
to github and to nexus staging.
If someone could kindly promote those artifacts from Nexus staging, that
would be nice :-)
groupId: org.xwiki.contrib
artifactId: xwiki-macro-tabs
versions: 1.0.1 and 1.0.2
Very nice POM!
I tested the XAR, seems to be working fine. Repo released:
http://nexus.xwiki.org/nexus/content/repositories/releases/org/xwiki/contri…
Note: as I put
"<xwiki.extension.name>Tabs Macro</xwiki.extension.name>"
in
the pom, and page name on xwiki.org is "Tabs
Macro", I believe that if I
"import" from Extension Repository, it should update the extension page
accordingly, is this right ? Because the extension id is different now of
course...
--
Sergiu Dumitriu
http://purl.org/net/sergiu
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
7:34 p.m.
New subject: [xwiki-users] Tabs Macro
Just tried the import on xwiki.org, so here are some feedbacks:
- if a "<developer>" (from pom.xml) doesn't have an id existing in
xwiki.org,
it is listed on imported page as xwiki:null
- import created a page "Tabs+Macro+1", instead of updated page
"Tabs+Macro", maybe I did something wrong or it's because extension id is
different ?
Apart from these little points, it's pretty cool :)
Merging things in existing page ...
BR,
Jeremie
2013/3/6 Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
Many thanks Sergiu !
Le 6 mars 2013 19:20, "Sergiu Dumitriu" <sergiu(a)xwiki.org> a écrit :
On 03/06/2013 12:54 PM, Jeremie BOUSQUET wrote:
Hello
guys,
So it's done, and I've published both versions 1.0.1 (from the original
from xwiki.org) and 1.0.2 (wich fixes excessive empty lines inserted)
both
to github and to nexus staging.
If someone could kindly promote those artifacts from Nexus staging, that
would be nice :-)
groupId: org.xwiki.contrib
artifactId: xwiki-macro-tabs
versions: 1.0.1 and 1.0.2
Very nice POM!
I tested the XAR, seems to be working fine. Repo released:
http://nexus.xwiki.org/nexus/content/repositories/releases/org/xwiki/contri…
Note: as I put
"<xwiki.extension.name>Tabs Macro</xwiki.extension.name>"
in
the pom, and page name on xwiki.org is "Tabs
Macro", I believe that if
I
"import" from Extension Repository, it
should update the extension page
accordingly, is this right ? Because the extension id is different now
of
course...
--
Sergiu Dumitriu
http://purl.org/net/sergiu
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
7:45 p.m.
New subject: [xwiki-users] Tabs Macro
Ok, I also updated extension page on xwiki.org [1] ...
I just checked from EM, that I could uninstall my current extension
(1.0.1), and install version 1.0.2. Seems that it did not detect new
version and propose an upgrade.
Also, I added old extension id into field "features", and set the new id
instead ("org.xwiki.contrib:xwiki-macro-tabs"). I'm not sure if it was the
correct way to do that.
BR,
Jeremie
2013/3/6 Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
Just tried the import on xwiki.org, so here are some
feedbacks:
- if a "<developer>" (from pom.xml) doesn't have an id existing in
xwiki.org, it is listed on imported page as xwiki:null
- import created a page "Tabs+Macro+1", instead of updated page
"Tabs+Macro", maybe I did something wrong or it's because extension id is
different ?
Apart from these little points, it's pretty cool :)
Merging things in existing page ...
BR,
Jeremie
2013/3/6 Jeremie BOUSQUET <jeremie.bousquet(a)gmail.com>
Many thanks Sergiu !
Le 6 mars 2013 19:20, "Sergiu Dumitriu" <sergiu(a)xwiki.org> a écrit :
On 03/06/2013 12:54 PM, Jeremie BOUSQUET wrote:
Hello
guys,
So it's done, and I've published both versions 1.0.1 (from the original
from xwiki.org) and 1.0.2 (wich fixes excessive empty lines inserted)
both
to github and to nexus staging.
If someone could kindly promote those artifacts from Nexus staging,
that
would be nice :-)
groupId: org.xwiki.contrib
artifactId: xwiki-macro-tabs
versions: 1.0.1 and 1.0.2
Very nice POM!
I tested the XAR, seems to be working fine. Repo released:
http://nexus.xwiki.org/nexus/content/repositories/releases/org/xwiki/contri…
Note: as I put
"<xwiki.extension.name>Tabs Macro</xwiki.extension.name>"
in
the pom, and page name on xwiki.org is "Tabs
Macro", I believe that
if I
"import" from Extension Repository, it
should update the extension page
accordingly, is this right ? Because the extension id is different now
of
course...
--
Sergiu Dumitriu
http://purl.org/net/sergiu
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
7 Mar
7 Mar
8:16 a.m.
New subject: [xwiki-users] Tabs Macro
On Mar 6, 2013, at 7:19 PM, Sergiu Dumitriu <sergiu(a)xwiki.org> wrote:
On 03/06/2013 12:54 PM, Jeremie BOUSQUET wrote:
indeed!
Only thing I'd comment is to have consistent # of chars for indentation: in some
places you use 20 chars for indentation and at other places 6, and at others 1 and at
others 2 :)
We use 2 chars everywhere so I'd suggest to use 2 for not having too long lines.
Thanks
-Vincent
Hello guys,
So it's done, and I've published both versions 1.0.1 (from the original
from xwiki.org) and 1.0.2 (wich fixes excessive empty lines inserted) both
to github and to nexus staging.
If someone could kindly promote those artifacts from Nexus staging, that
would be nice :-)
groupId: org.xwiki.contrib
artifactId: xwiki-macro-tabs
versions: 1.0.1 and 1.0.2
Very nice POM! I tested the XAR, seems to be working fine. Repo
released:
http://nexus.xwiki.org/nexus/content/repositories/releases/org/xwiki/contri…
> Note: as I put "<xwiki.extension.name>Tabs
Macro</xwiki.extension.name>" in
> the pom, and page name on xwiki.org is "Tabs Macro", I believe that if I
> "import" from Extension Repository, it should update the extension page
> accordingly, is this right ? Because the extension id is different now of
> course...
10:36 a.m.
New subject: [xwiki-users] Tabs Macro
Le 7 mars 2013 08:17, "Vincent Massol" <vincent(a)massol.net> a écrit :
indeed!
Only thing I'd comment is to have consistent # of chars for indentation: in
some places you use 20 chars for indentation and at other places 6, and
at others 1 and at others 2 :)
On Mar 6, 2013, at 7:19 PM, Sergiu Dumitriu <sergiu(a)xwiki.org> wrote:
> On 03/06/2013 12:54 PM, Jeremie BOUSQUET wrote:
>> Hello guys,
>>
>> So it's done, and I've published both versions 1.0.1 (from the original
>> from xwiki.org) and 1.0.2 (wich fixes excessive empty lines inserted)
both
>> to github and to nexus staging.
>>
>> If someone could kindly promote those artifacts from Nexus staging,
that
would be nice :-)
groupId: org.xwiki.contrib
artifactId: xwiki-macro-tabs
versions: 1.0.1 and 1.0.2
Very nice POM!
We use 2 chars everywhere so I'd suggest to use 2 for not having too long
lines.
You're right, I forgot to beautify it ... I'll fix that for next versions.
Thanks,
Jeremie
Thanks
-Vincent
> I tested the XAR, seems to be working fine. Repo released:
>
http://nexus.xwiki.org/nexus/content/repositories/releases/org/xwiki/contri…
>
>> Note: as I put "<xwiki.extension.name>Tabs
Macro</xwiki.extension.name>"
in
>> the pom, and page name on xwiki.org is
"Tabs Macro", I believe that if
I
>> "import" from Extension Repository,
it should update the extension page
>> accordingly, is this right ? Because the extension id is different now
of
> course...
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
4211
days inactive
4220
days old
16 comments
4 participants
participants (4)
-
Jeremie BOUSQUET -
Roman Muntyanu -
Sergiu Dumitriu -
Vincent Massol