________________________________________ From: users-bounces(a)xwiki.org [users-bounces(a)xwiki.org] On Behalf Of Marius Dumitru Florea [mariusdumitru.florea(a)xwiki.com] Sent: 15 March 2013 10:24 To: XWiki Users Subject: Re: [xwiki-users] Rendering of a particular version of a document Fixed in 2.5RC1 by https://github.com/xwiki/xwiki-platform/commit/c08cca8cae375ea306b071fedbae… . See http://jira.xwiki.org/browse/XWIKI-5575 . The viewattachrev action is needed for attachments of the context document because attachments are also versioned and when you view a revision of a document you want to view the version of the attached images from that revision.

Hope this helps, Marius On Fri, Mar 15, 2013 at 2:41 AM, &lt;Ricardo.Julio.Rodriguez.Fernandez(a)sergas.es&gt; wrote: > Hi! > > In an old XWIKI ENTERPRISE 2.4.30451, I'm having problems when rendering a particular version of a document, rev is not null and the asked revision exists. I got this... > > <div id="companylogo"> > <a href="/bin/Main/" title="Home" rel="home"> > <img src="/bin/viewattachrev/XWiki/IDISSkin/glIdisMotto.png" alt="Wiki Logo"/> > </a> > </div> > > Instead of the HTML code generated when rev is not used... > > <div id="companylogo"> > <a href="/bin/Main/" title="Home" rel="home"> > <img src="/bin/download/XWiki/IDISSkin/glIdisMotto.png" alt="Wiki Logo"/> > </a> > </div> > > It seems that the use of ?rev forces the viewattachrev action to be included in the img URL. I don't understand why does this happen. Please, could this be avoided? > > Please, check this behavior on line here... > > 1) No rev in the URL: IT WORKS FINE > http://www.idisantiago.es/bin/OpenInitiative/TranslationalOmics2013 > > 2) Rev is not null and revision exists: THE LOGO DOESN'T SHOW UP > http://www.idisantiago.es/bin/viewrev/OpenInitiative/TranslationalOmics2013… > > 3) Rev is not null but it doesn't exist: IT WORKS FINE http://www.idisantiago.es/bin/viewrev/OpenInitiative/TranslationalOmics2013… 4) Rev is used but null: IT THROUGHS AN EXCEPTION AND THE HEADER IS NOT RENDERED > http://www.idisantiago.es/bin/viewrev/OpenInitiative/TranslationalOmics2013… > > Please, is it possible to find a solution at least for case 1)? > > Thank you so much for your help! > > Ricardo > > -- > Ricardo Rodríguez > Research Management and Promotion Technician > Technical Secretariat > Health Research Institute of Santiago de Compostela (IDIS) > http://www.idisantiago.es > > Nota: A información contida nesta mensaxe e os seus posibles documentos adxuntos é privada e confidencial e está dirixida únicamente ó seu destinatario/a. Se vostede non é o/a destinatario/a orixinal desta mensaxe, por favor elimínea. A distribución ou copia desta mensaxe non está autorizada. > > Nota: La información contenida en este mensaje y sus posibles documentos adjuntos es privada y confidencial y está dirigida únicamente a su destinatario/a. Si usted no es el/la destinatario/a original de este mensaje, por favor elimínelo. La distribución o copia de este mensaje no está autorizada. > > See more languages: http://www.sergas.es/aviso_confidencialidad.htm > _______________________________________________ > users mailing list > users(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/users _______________________________________________ users mailing list users(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/users

________________________________________ From: users-bounces(a)xwiki.org [users-bounces(a)xwiki.org] On Behalf Of Marius Dumitru Florea [mariusdumitru.florea(a)xwiki.com] Sent: 18 March 2013 09:40 To: XWiki Users Subject: Re: [xwiki-users] Rendering of a particular version of a document On Sat, Mar 16, 2013 at 4:58 PM, &lt;Ricardo.Julio.Rodriguez.Fernandez(a)sergas.es&gt; wrote: > Thanks, Marius! Please, read below... > >> ________________________________________ >> From: users-bounces(a)xwiki.org [users-bounces(a)xwiki.org] On Behalf Of Marius Dumitru Florea [mariusdumitru.florea(a)xwiki.com] >> Sent: 15 March 2013 10:24 >> To: XWiki Users >> Subject: Re: [xwiki-users] Rendering of a particular version of a document >> >> Fixed in 2.5RC1 by >> https://github.com/xwiki/xwiki-platform/commit/c08cca8cae375ea306b071fedbae… >> . See http://jira.xwiki.org/browse/XWIKI-5575 . >> >> The viewattachrev action is needed for attachments of the context >> document because attachments are also versioned and when you view a >> revision of a document you want to view the version of the attached >> images from that revision. >> > > I get the point! Thank you very much for the explanation. > > Please, Marius, could it be possible to substitute the old XWikiServletURLFactory.java class with the new one in xwiki-core-2.4.jar and keep running XWiki Enterprise 2.4.30451? You can try taking XWikiServletURLFactory.class from xwiki-core-2.5.jar and put it in WEB-INF/classes where you have deployed XWiki (under the same path as in the jar, i.e. the class package) but it might not work properly because it may contain other changes besides XWIKI-5575 which are not compatible with the xwiki-core-2.4.jar.

Your best option is to patch the xwiki-core.2.4.jar. It's quite easy if you're not afraid of Git and Maven:

Make sure you use the same Java version as the one running your application server.

> > For good or for bad I need to keep alive this server and I've not time to make a full update to the current version! I do hope I'll find that time soon! > > Thanks for your help! > > >> Hope this helps, >> Marius >> >> On Fri, Mar 15, 2013 at 2:41 AM, >> &lt;Ricardo.Julio.Rodriguez.Fernandez(a)sergas.es&gt; wrote: >> Hi! >> >> In an old XWIKI ENTERPRISE 2.4.30451, I'm having problems when rendering a particular version of a document, rev is not null and the asked revision exists. I got this... >> >> <div id="companylogo"> >> <a href="/bin/Main/" title="Home" rel="home"> >> <img src="/bin/viewattachrev/XWiki/IDISSkin/glIdisMotto.png" alt="Wiki Logo"/> >> </a> >> </div> >> >> Instead of the HTML code generated when rev is not used... >> >> <div id="companylogo"> >> <a href="/bin/Main/" title="Home" rel="home"> >> <img src="/bin/download/XWiki/IDISSkin/glIdisMotto.png" alt="Wiki Logo"/> >> </a> >> </div> >> >> It seems that the use of ?rev forces the viewattachrev action to be included in the img URL. I don't understand why does this happen. Please, could this be avoided? >> >> Please, check this behavior on line here... >> >> 1) No rev in the URL: IT WORKS FINE >> http://www.idisantiago.es/bin/OpenInitiative/TranslationalOmics2013 >> >> 2) Rev is not null and revision exists: THE LOGO DOESN'T SHOW UP >> http://www.idisantiago.es/bin/viewrev/OpenInitiative/TranslationalOmics2013… >> >> 3) Rev is not null but it doesn't exist: IT WORKS FINE > http://www.idisantiago.es/bin/viewrev/OpenInitiative/TranslationalOmics2013… > > 4) Rev is used but null: IT THROUGHS AN EXCEPTION AND THE HEADER IS NOT RENDERED >> http://www.idisantiago.es/bin/viewrev/OpenInitiative/TranslationalOmics2013… >> >> Please, is it possible to find a solution at least for case 1)? >> >> Thank you so much for your help! >> >> Ricardo >> >> -- >> Ricardo Rodríguez >> Research Management and Promotion Technician >> Technical Secretariat >> Health Research Institute of Santiago de Compostela (IDIS) >> http://www.idisantiago.es >> >> Nota: A información contida nesta mensaxe e os seus posibles documentos adxuntos é privada e confidencial e está dirixida únicamente ó seu destinatario/a. Se vostede non é o/a destinatario/a orixinal desta mensaxe, por favor elimínea. A distribución ou copia desta mensaxe non está autorizada. >> >> Nota: La información contenida en este mensaje y sus posibles documentos adjuntos es privada y confidencial y está dirigida únicamente a su destinatario/a. Si usted no es el/la destinatario/a original de este mensaje, por favor elimínelo. La distribución o copia de este mensaje no está autorizada. >> >> See more languages: http://www.sergas.es/aviso_confidencialidad.htm >> _______________________________________________ >> users mailing list >> users(a)xwiki.org >> http://lists.xwiki.org/mailman/listinfo/users >_______________________________________________ >users mailing list &gt;users(a)xwiki.org >http://lists.xwiki.org/mailman/listinfo/users Nota: A información contida nesta mensaxe e os seus posibles documentos adxuntos é privada e confidencial e está dirixida únicamente ó seu destinatario/a. Se vostede non é o/a destinatario/a orixinal desta mensaxe, por favor elimínea. A distribución ou copia desta mensaxe non está autorizada. Nota: La información contenida en este mensaje y sus posibles documentos adjuntos es privada y confidencial y está dirigida únicamente a su destinatario/a. Si usted no es el/la destinatario/a original de este mensaje, por favor elimínelo. La distribución o copia de este mensaje no está autorizada. See more languages: http://www.sergas.es/aviso_confidencialidad.htm _______________________________________________ users mailing list users(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/users