20 May
2008
20 May
'08
2:48 p.m.
Sergiu,
Which bit is fixed? The generation of the empty file in the XAR on export OR
the import failing on the reading of an empty file in the XAR? Or both!?!
Thanks.
Richard
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org]On Behalf
Of Sergiu Dumitriu
Sent: 20 May 2008 13:38
To: XWiki Users
Subject: Re: [xwiki-users] Import problem
project_trainees(a)amritatech.com wrote:
Hi Richard,
I had an empty file in my XAR and that was the problem. Thank You very
much.
This error is (supposed to be) fixed in 1.4.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
Thales UK Ltd (Wells) DISCLAIMER: The information contained in this e-mail
is confidential. It may also be legally privileged. It is intended only for
the stated addressee(s) and access to it by any other person is
unauthorised. If you are not an addressee, you must not disclose, copy,
circulate or in any other way use or rely on the information contained in
this e-mail. Such unauthorised use may be unlawful. We may monitor all
e-mail communications through our networks. If you have received this e-mail
in error, please inform us immediately on +44 (0) 1749 672081 and delete it
and all copies from your system. We accept no responsibility for changes to
any e-mail which occur after it has been sent. Attachments to this e-mail
may contain software viruses which could damage your system. We therefore
recommend you virus-check all attachments before opening. A business of
Thales UK Ltd. Registered Office: 2 Dashwood Lang Road, The Bourne Business
Park, Addlestone, Weybridge, Surrey KT15 2NX Registered in England No.
868273
20 May
20 May
3:14 p.m.
New subject: [xwiki-users] Import problem
goldring, richard wrote:
Sergiu,
Which bit is fixed? The generation of the empty file in the XAR on export OR
the import failing on the reading of an empty file in the XAR? Or both!?!
Both, but there might still be some bugs that could cause one or the
other to fail under certain circumstances. Unfortunately, we can't push
those fixes in the already released versions, to fix the export in
running instances, right?
-----Original Message-----
From: users-bounces(a)xwiki.org [mailto:users-bounces@xwiki.org]On Behalf
Of Sergiu Dumitriu
Sent: 20 May 2008 13:38
To: XWiki Users
Subject: Re: [xwiki-users] Import problem
project_trainees(a)amritatech.com wrote:
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
Hi Richard,
I had an empty file in my XAR and that was the problem. Thank You very
much.
This error is (supposed to be) fixed in 1.4. 
7:58 p.m.
New subject: [xwiki-users] Import problem
On Tue, May 20, 2008 at 6:14 AM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
Both, but there might still be some bugs that could
cause one or the
other to fail under certain circumstances.
Have other exceptions on import been properly trapped so that they display a
user-vibible error condition rather than failing silently?
In particular, i'm wondering if this situation got "caught" which has to do
with a packages.xml out-of-sync with reality. Also, shouldn't this be a more
severe error condition than WARN. The user clicks a button, and nothing
happens other than writing out an error in log4j.
13:48:52,163 [
http://............./bin/import/XWiki/Import?action=getPackageInfos&name=wiki.xar&xpage=plain&_=<http://nielsmayer.com/curriki/bin/import/XWiki/Import?action=getPackageInfos&name=curriki-wiki.xar&xpage=plain&_=>]
[http-127.0.0.1-8080-Processor2] WARN web.XWikiAction -
Uncaught exception: Error number 11015 in 11: Exception while importing
Wrapped Exception: Error number 0 in 5: Package: document Demo.WECCooley
does not exist in package definition
com.xpn.xwiki.XWikiException: Error number 11015 in 11: Exception while
importing
Wrapped Exception: Error number 0 in 5: Package: document Demo.WECCooley
does not exist in package definition
IMHO -- my EXTREME view is that all uncaught exceptions should abort the
application. For one, this tends to force the application to catch all
exceptions in very short order as it becomes painfully obvious that there's
a problem when you start getting 404's...; for two, you really can't trust
the application state after an uncaught exception anyways...
In the case of import exceptions, it could leave the wiki in a fairly
undetermined state. In the case of an import failure it's pretty easy to
"clean up" after, so aborting might be extreme overkill. But the best would
be for such exceptions to actually "roll back" the import. This means that
if a failed import overwrote a previous page or space, it would revert to
the original version before the import failure. In simple cases, it would
just delete any new pages or spaces created prior to failure.
Of course, that sounds like a ridiculous amount of work. Instead, perhaps
imports should be "pre-validated" (parsed and consistency-checked) to ensure
that once importing starts, it is an "atomic operation" that won't fail and
leave the wiki in an indeterminate state.
--
Niels
http://nielsmayer.com
6016
days inactive
6016
days old
2 comments
3 participants
participants (3)
-
goldring, richard -
Niels Mayer -
Sergiu Dumitriu