30 Jul
2013
30 Jul
'13
3:11 p.m.
Hi,
I just noticed that whenever someone creates a new blog page, this new blog page shows up
in the Activity Stream, even if the page entry is not yet published.
I guess this makes just sense from the point of view of the Activity-stream, as creating
the blog page always creates an entry in the activity stream DB of type
"create".
However I feel it might upset some users who expect that their unpublished blog pages
remain "secret".
I wonder where I should dig in to prevent these entries showing up. Is it possible to
suppress logging the "create" event in the activity DB until the Blog entry gets
published?
Or should I better try to filter these events in the macro displaying the activity
stream.
Oh, and is there any general interest in suppressing these entries in the activity stream,
or is it just me and I can look for a solution on the "works-for-me" level
instead of something others might find reusable?
Cheers,
Clemens
--
Clemens Klein-Robbenhaar
Software Development
EsPresto AG
Breite Str. 30-31
10178 Berlin/Germany
Tel: +49.(0)30.90 226.763
Fax: +49.(0)30.90 226.760
robbenhaar(a)espresto.com
HRB 77554 B - Berlin-Charlottenburg
Vorstand: Maya Biersack, Peter Biersack
Vorsitzender des Aufsichtsrats: Dipl.-Wirtsch.-Ing. Winfried Weber
Zertifiziert nach ISO 9001:2008
30 Jul
30 Jul
4:21 p.m.
New subject: [xwiki-users] Unpublished Blog-entries show up in the Activity stream
On 07/30/2013 09:11 AM, Clemens Klein-Robbenhaar wrote:
Hi,
I just noticed that whenever someone creates a new blog page, this new blog page shows
up in the Activity Stream, even if the page entry is not yet published.
I guess this makes just sense from the point of view of the Activity-stream, as creating
the blog page always creates an entry in the activity stream DB of type
"create".
However I feel it might upset some users who expect that their unpublished blog pages
remain "secret".
I wonder where I should dig in to prevent these entries showing up. Is it possible to
suppress logging the "create" event in the activity DB until the Blog entry gets
published?
Or should I better try to filter these events in the macro displaying the activity
stream.
Oh, and is there any general interest in suppressing these entries in the activity
stream, or is it just me and I can look for a solution on the "works-for-me"
level instead of something others might find reusable?
Cheers,
Clemens
That's kind of a bug/missing feature. The blog app was developed before
the "hidden documents" feature was fully adopted, so it used a
poor-man's document hiding method that only works inside the blog
application itself. It needs an update so that unpublished blog posts
are also hidden.
--
Sergiu Dumitriu
http://purl.org/net/sergiu
4:37 p.m.
On Jul 30, 2013, at 4:21 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
On 07/30/2013 09:11 AM, Clemens Klein-Robbenhaar
wrote:
Hmm I'm not sure about that Sergiu. Imagine the following:
* I am a normal user (I haven't touched my preferences)
* I create a blog post and save
* Suddenly when I go to the blog home page, my blog post doesn't show any more
(because it's hidden)
* I also search in the wiki and I don't see it. I go to AllDocs index page and I
don't see it listed either. I click ctrl+G and I don't get it too…
Published doesn't mean that page is visible/not visible. It means visible to RSS
feeds.
The notion of draft vs published page is a different concept that we don't currently
have.
Now what we need to do with the planned rewrite of the AS is introduce the notion of
persistent filters for the AS so that you can decide what to display or not display.
Clements, FYI this notion of filters was in the spec of the AS UI from the beginning but
it's not been implemented yet (a first version was done by Edy on a research project
AFAIK but not integrated). We wanted to do this in 5.2 (the rewrite of the AS but it got
delayed). I don't know if anyone will have the time to work on this before the end of
the year but it's pretty high in our todo list since the AS is a hog ATM…
What you could do in the meantime is edit the Main.Activity page objects to modify the
activity macro and filter out what you want.
Thanks
-Vincent
Hi,
I just noticed that whenever someone creates a new blog page, this new blog page shows up
in the Activity Stream, even if the page entry is not yet published.
I guess this makes just sense from the point of view of the Activity-stream, as creating
the blog page always creates an entry in the activity stream DB of type
"create".
However I feel it might upset some users who expect that their unpublished blog pages
remain "secret".
I wonder where I should dig in to prevent these entries showing up. Is it possible to
suppress logging the "create" event in the activity DB until the Blog entry gets
published?
Or should I better try to filter these events in the macro displaying the activity
stream.
Oh, and is there any general interest in suppressing these entries in the activity
stream, or is it just me and I can look for a solution on the "works-for-me"
level instead of something others might find reusable?
Cheers,
Clemens
That's kind of a bug/missing feature. The blog app was developed before
the "hidden documents" feature was fully adopted, so it used a
poor-man's document hiding method that only works inside the blog
application itself. It needs an update so that unpublished blog posts
are also hidden.
5:33 p.m.
New subject: [xwiki-users] Unpublished Blog-entries show up in the Activity stream
On 07/30/2013 04:37 PM, Vincent Massol wrote:
That's kind of a bug/missing feature. The blog app was developed before
the "hidden documents" feature was fully adopted, so it used a
poor-man's document hiding method that only works inside the blog
application itself. It needs an update so that unpublished blog posts
are also hidden.
Hmm I'm not sure about that Sergiu. Imagine the following:
* I am a normal user (I haven't touched my preferences)
* I create a blog post and save
* Suddenly when I go to the blog home page, my blog post doesn't show any more
(because it's hidden)
* I also search in the wiki and I don't see it. I go to AllDocs index page and I
don't see it listed either. I click ctrl+G and I don't get it too…
Published doesn't mean that page is visible/not visible. It means visible to RSS
feeds.
The notion of draft vs published page is a different concept that we don't currently
have.
Now what we need to do with the planned rewrite of the AS is introduce the notion of
persistent filters for the AS so that you can decide what to display or not display.
Clements, FYI this notion of filters was in the spec of the AS UI from the beginning but
it's not been implemented yet (a first version was done by Edy on a research project
AFAIK but not integrated). We wanted to do this in 5.2 (the rewrite of the AS but it got
delayed). I don't know if anyone will have the time to work on this before the end of
the year but it's pretty high in our todo list since the AS is a hog ATM…
What you could do in the meantime is edit the Main.Activity page objects to modify the
activity macro and filter out what you want.
Thanks, then I will try to start from the activity macro on that page.
I feel if a complete rewrite of the AS is in the planning, then there is not much that I
could contribute to with my quite limited knowledge about XWiki internals?
Clemens
On Jul 30, 2013, at 4:21 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
> On 07/30/2013 09:11 AM, Clemens Klein-Robbenhaar wrote:
>> Hi,
>>
>> I just noticed that whenever someone creates a new blog page, this new blog page
shows up in the Activity Stream, even if the page entry is not yet published.
>> I guess this makes just sense from the point of view of the Activity-stream, as
creating the blog page always creates an entry in the activity stream DB of type
"create".
[...]
6:19 p.m.
Hi Clements,
Maybe I will get some time in the near future to review my old pull request
[1] and apply it. It's on my personal TODO list as well.
In the meanwhile, if you`re eager, have a look at the code [1] and maybe
try it out.
Thanks,
Eduard
[1] https://github.com/xwiki/xwiki-enterprise/pull/27/files
On Tue, Jul 30, 2013 at 6:33 PM, Clemens Klein-Robbenhaar <
c.robbenhaar(a)espresto.com> wrote:
On 07/30/2013 04:37 PM, Vincent Massol wrote:
That's kind of a bug/missing feature. The blog app was developed before
the "hidden documents" feature was fully adopted, so it used a
poor-man's document hiding method that only works inside the blog
application itself. It needs an update so that unpublished blog posts
are also hidden.
Hmm I'm not sure about that Sergiu. Imagine the following:
* I am a normal user (I haven't touched my preferences)
* I create a blog post and save
* Suddenly when I go to the blog home page, my blog post doesn't show any more
(because it's hidden)
Thanks, then I will try to start from the activity macro on that page.
I feel if a complete rewrite of the AS is in the planning, then there is
not much that I could contribute to with my quite limited knowledge about
XWiki internals?
Clemens
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
On Jul 30, 2013, at 4:21 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
> On 07/30/2013 09:11 AM, Clemens Klein-Robbenhaar wrote:
>> Hi,
>>
>> I just noticed that whenever someone creates a new blog page, this new
blog page shows up in the Activity Stream, even if the page entry is not
yet published.
>> I guess this makes just sense from the
point of view of the
Activity-stream, as creating the blog page always creates an
entry in the
activity stream DB of type "create".
[...]
* I also search in the wiki and I don't see
it. I go to AllDocs index
page and I don't see it listed either. I click ctrl+G
and I don't get it
too…
Published doesn't mean that page is visible/not visible. It means
visible to
RSS feeds.
The notion of draft vs published page is a different concept that we
don't
currently have.
Now what we need to do with the planned rewrite of the AS is introduce
the notion
of persistent filters for the AS so that you can decide what to
display or not display.
Clements, FYI this notion of filters was in the spec of the AS UI from
the
beginning but it's not been implemented yet (a first version was done
by Edy on a research project AFAIK but not integrated). We wanted to do
this in 5.2 (the rewrite of the AS but it got delayed). I don't know if
anyone will have the time to work on this before the end of the year but
it's pretty high in our todo list since the AS is a hog ATM…
What you could do in the meantime is edit the Main.Activity page objects
to modify
the activity macro and filter out what you want.
31 Jul
31 Jul
1:53 p.m.
New subject: [xwiki-users] Unpublished Blog-entries show up in the Activity stream
Hi Eduard,
after some trouble I have been able to get this running locally;
I guess if one wants to merge it there is a bit of trouble ahead,
as the Activity.xml seems to have been both been modified and moved around in the git.
Anyway, I can get it running as far as be able to filter for some spaces.
What it does not allow is to ignore some spaces, but I guess that is
some UI issue that mostly requires fiddeling with the filter representation.
I have not seen a way to store the filter permanently on the Activity page;
I guess that is not part of the feature (yet?).
In any case I see that my original idea to hide the "Create" event for
a blog post as long as it is not published is not possible that way,
because "is not published" flag is a property of the blog entry and not
written to the activity stream.
(I guess one could in theory use the "ase_hidden" flag for that?)
Then, if one publishes a blog entry, that would not change this flag retrospectively
(especially if I starts to think about the publication date, etc)
So the only way to make sure unpublished blog entries do not show up in the
activity stream would be to inspect the blog post directly for each entry
after querying the activity stream, or make a big join over the activity stream
and the corresponding pages (which might be blog entries, or not, and if they are,
have an "is published" flag set, and a publication date either not set or in the
past)
... duh, this sounds quite inefficient,
While I am not really closer to a solution of my original problem, (except for
understanding it is a bit harder that I imagined), however I now have a good idea
how e.g to exclude all events relating to "Blog" entries from the activity
stream;
that should be "good enough for now".
Clemens
Hi Clements,
Maybe I will get some time in the near future to review my old pull request
[1] and apply it. It's on my personal TODO list as well.
In the meanwhile, if you`re eager, have a look at the code [1] and maybe
try it out.
Thanks,
Eduard
[1] https://github.com/xwiki/xwiki-enterprise/pull/27/files
On Tue, Jul 30, 2013 at 6:33 PM, Clemens Klein-Robbenhaar <
c.robbenhaar(a)espresto.com> wrote:
mit freundlichen Grüßen
Clemens Klein-Robbenhaar
--
Clemens Klein-Robbenhaar
Software Development
EsPresto AG
Breite Str. 30-31
10178 Berlin/Germany
Tel: +49.(0)30.90 226.763
Fax: +49.(0)30.90 226.760
robbenhaar(a)espresto.com
HRB 77554 B - Berlin-Charlottenburg
Vorstand: Maya Biersack, Peter Biersack
Vorsitzender des Aufsichtsrats: Dipl.-Wirtsch.-Ing. Winfried Weber
Zertifiziert nach ISO 9001:2008
On 07/30/2013 04:37 PM, Vincent Massol wrote:
That's kind of a bug/missing feature. The blog app was developed before
the "hidden documents" feature was fully adopted, so it used a
poor-man's document hiding method that only works inside the blog
application itself. It needs an update so that unpublished blog posts
are also hidden.
Hmm I'm not sure about that Sergiu. Imagine the following:
* I am a normal user (I haven't touched my preferences)
* I create a blog post and save
* Suddenly when I go to the blog home page, my blog post doesn't show any more
(because it's hidden)
Thanks, then I will try to start from the activity macro on that page.
I feel if a complete rewrite of the AS is in the planning, then there is
not much that I could contribute to with my quite limited knowledge about
XWiki internals?
Clemens
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
On Jul 30, 2013, at 4:21 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
> On 07/30/2013 09:11 AM, Clemens Klein-Robbenhaar wrote:
>> Hi,
> >> I just noticed that whenever
someone creates a new blog page, this new
blog page shows up in the Activity
Stream, even if the page entry is not
yet published.
>> I guess this makes just sense from the
point of view of the
Activity-stream, as creating the blog page always creates an
entry in the
activity stream DB of type "create".
[...]
* I also search in the wiki and I don't see
it. I go to AllDocs index
page and I don't see it listed either. I click ctrl+G
and I don't get it
too…
Published doesn't mean that page is visible/not visible. It means
visible to
RSS feeds.
The notion of draft vs published page is a different concept that we
don't
currently have.
Now what we need to do with the planned rewrite of the AS is introduce
the notion
of persistent filters for the AS so that you can decide what to
display or not display.
Clements, FYI this notion of filters was in the spec of the AS UI from
the
beginning but it's not been implemented yet (a first version was done
by Edy on a research project AFAIK but not integrated). We wanted to do
this in 5.2 (the rewrite of the AS but it got delayed). I don't know if
anyone will have the time to work on this before the end of the year but
it's pretty high in our todo list since the AS is a hog ATM…
What you could do in the meantime is edit the Main.Activity page objects
to modify
the activity macro and filter out what you want.
2:05 p.m.
On Jul 31, 2013, at 1:53 PM, Clemens Klein-Robbenhaar <c.robbenhaar(a)espresto.com>
wrote:
Hi Eduard,
after some trouble I have been able to get this running locally;
I guess if one wants to merge it there is a bit of trouble ahead,
as the Activity.xml seems to have been both been modified and moved around in the git.
Anyway, I can get it running as far as be able to filter for some spaces.
What it does not allow is to ignore some spaces, but I guess that is
some UI issue that mostly requires fiddeling with the filter representation.
I have not seen a way to store the filter permanently on the Activity page;
I guess that is not part of the feature (yet?).
In any case I see that my original idea to hide the "Create" event for
a blog post as long as it is not published is not possible that way,
because "is not published" flag is a property of the blog entry and not
written to the activity stream.
(I guess one could in theory use the "ase_hidden" flag for that?)
Then, if one publishes a blog entry, that would not change this flag retrospectively
(especially if I starts to think about the publication date, etc)
So the only way to make sure unpublished blog entries do not show up in the
activity stream would be to inspect the blog post directly for each entry
after querying the activity stream, or make a big join over the activity stream
and the corresponding pages (which might be blog entries, or not, and if they are,
have an "is published" flag set, and a publication date either not set or in
the past)
... duh, this sounds quite inefficient,
Note that it's also possible to pass custom parameters to the activitystream storage,
so it should be possible to add some "display in AS UI" boolean and modify the
AS UI to not display those.
Thanks
-Vincent
While I am not really closer to a solution of my
original problem, (except for
understanding it is a bit harder that I imagined), however I now have a good idea
how e.g to exclude all events relating to "Blog" entries from the activity
stream;
that should be "good enough for now".
Clemens
Hi Clements,
Maybe I will get some time in the near future to review my old pull request
[1] and apply it. It's on my personal TODO list as well.
In the meanwhile, if you`re eager, have a look at the code [1] and maybe
try it out.
Thanks,
Eduard
[1] https://github.com/xwiki/xwiki-enterprise/pull/27/files
On Tue, Jul 30, 2013 at 6:33 PM, Clemens Klein-Robbenhaar <
c.robbenhaar(a)espresto.com> wrote:
mit freundlichen Grüßen
Clemens Klein-Robbenhaar
--
Clemens Klein-Robbenhaar
Software Development
EsPresto AG
Breite Str. 30-31
10178 Berlin/Germany
Tel: +49.(0)30.90 226.763
Fax: +49.(0)30.90 226.760
robbenhaar(a)espresto.com
HRB 77554 B - Berlin-Charlottenburg
Vorstand: Maya Biersack, Peter Biersack
Vorsitzender des Aufsichtsrats: Dipl.-Wirtsch.-Ing. Winfried Weber
Zertifiziert nach ISO 9001:2008
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
On 07/30/2013 04:37 PM, Vincent Massol wrote:
Thanks, then I will try to start from the activity macro on that page.
I feel if a complete rewrite of the AS is in the planning, then there is
not much that I could contribute to with my quite limited knowledge about
XWiki internals?
Clemens
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________
users mailing list
users(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/users
On Jul 30, 2013, at 4:21 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
> On 07/30/2013 09:11 AM, Clemens Klein-Robbenhaar wrote:
>> Hi,
> >> I just noticed that whenever
someone creates a new blog page, this new
blog page shows up in the Activity
Stream, even if the page entry is not
yet published.
>> I guess this makes just sense from the
point of view of the
Activity-stream, as creating the blog page always creates an
entry in the
activity stream DB of type "create".
[...]
>
> That's kind of a
bug/missing feature. The blog app was developed before
> the "hidden documents" feature was fully adopted, so it used a
> poor-man's document hiding method that only works inside the blog
> application itself. It needs an update so that unpublished blog posts
> are also hidden.
Hmm I'm not sure about that Sergiu. Imagine the following:
* I am a normal user (I haven't touched my preferences)
* I create a blog post and save
* Suddenly when I go to the blog home page, my blog post doesn't show
any more
(because it's hidden)
* I also search in the wiki and I don't see
it. I go to AllDocs index
page and I don't see it listed either. I click ctrl+G
and I don't get it
too…
Published doesn't mean that page is visible/not visible. It means
visible to
RSS feeds.
The notion of draft vs published page is a different concept that we
don't
currently have.
Now what we need to do with the planned rewrite of the AS is introduce
the notion
of persistent filters for the AS so that you can decide what to
display or not display.
Clements, FYI this notion of filters was in the spec of the AS UI from
the
beginning but it's not been implemented yet (a first version was done
by Edy on a research project AFAIK but not integrated). We wanted to do
this in 5.2 (the rewrite of the AS but it got delayed). I don't know if
anyone will have the time to work on this before the end of the year but
it's pretty high in our todo list since the AS is a hog ATM…
What you could do in the meantime is edit the Main.Activity page objects
to modify
the activity macro and filter out what you want.
3:06 p.m.
New subject: [xwiki-users] Unpublished Blog-entries show up in the Activity stream
On 07/31/2013 02:05 PM, Vincent Massol wrote:
Ah, so it would be the opposite approach; instead of having the activity stream know
what to filter, one passes this information into the stream when creating the entry.
Are there any pointers how one could hook into the creation of the ActivityStream
elements?
I guess I could replace / inherit from the ActivityStreamImpl event listener,
but I guess this is not the best way to do it ...
Clemens
On Jul 31, 2013, at 1:53 PM, Clemens Klein-Robbenhaar <c.robbenhaar(a)espresto.com>
wrote:
[...]
So the only
way to make sure unpublished blog entries do not show up in the
activity stream would be to inspect the blog post directly for each entry
after querying the activity stream, or make a big join over the activity stream
and the corresponding pages (which might be blog entries, or not, and if they are,
have an "is published" flag set, and a publication date either not set or in
the past)
... duh, this sounds quite inefficient,
Note that it's also possible to pass custom parameters to the activitystream storage,
so it should be possible to add some "display in AS UI" boolean and modify the
AS UI to not display those.
4119
days inactive
4120
days old
7 comments
4 participants
participants (4)
-
Clemens Klein-Robbenhaar -
Eduard Moraru -
Sergiu Dumitriu -
Vincent Massol