March 2008 - xwiki-devs@xwiki.org

Re: [xwiki-devs] [xwiki-notifications] r8184 - xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/main/java/com/xpn/xwiki
by Vincent Massol 04 Mar '08

04 Mar '08

hmmm.... I'm really against adding new features, in a RC phase! I'll prefer this to be rolled back to be honest. However if we want to keep it then we need some tests that'll prove it's not breaking anything. We shouldn't add dangerous stuff like this in a RC phase and especially not without a vote IMO. Thanks -Vincent On Mar 3, 2008, at 10:18 PM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-03-03 22:18:54 +0100 (Mon, 03 Mar 2008) > New Revision: 8184 > > Modified: > xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/main/ > java/com/xpn/xwiki/XWiki.java > Log: > XWIKI-2170: Allow inactive users to see specific pages > Done. > Patch submitted by David Ward, applied with minor changes. > Merged from trunk@8181 > > > Modified: xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/ > main/java/com/xpn/xwiki/XWiki.java > =================================================================== > --- xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/main/ > java/com/xpn/xwiki/XWiki.java 2008-03-03 21:18:14 UTC (rev 8183) > +++ xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/main/ > java/com/xpn/xwiki/XWiki.java 2008-03-03 21:18:54 UTC (rev 8184) > @@ -4211,13 +4211,26 @@ > null, > args); > } else if (checkActive(context) == 0) { > - Object[] args = {context.getUser()}; > - setPhonyDocument(docName, context, vcontext); > - throw new > XWikiException(XWikiException.MODULE_XWIKI_USER, > - XWikiException.ERROR_XWIKI_USER_INACTIVE, > - "User {0} account is inactive", > - null, > - args); > + boolean allow = false; > + String allowed = > Param("xwiki.inactiveuser.allowedpages", ""); > + if (context.getAction().equals("view") && ! > allowed.equals("")) { > + String[] allowedList = StringUtils.split(allowed, > " ,"); > + for (int i=0; i < allowedList.length; i++) { > + if (allowedList[i].equals(doc.getFullName())) { > + allow = true; > + break; > + } > + } > + } > + if (!allow) { > + Object[] args = {context.getUser()}; > + setPhonyDocument(docName, context, vcontext); > + throw new > XWikiException(XWikiException.MODULE_XWIKI_USER, > + XWikiException.ERROR_XWIKI_USER_INACTIVE, > + "User {0} account is inactive", > + null, > + args); > + } > } > > context.put("doc", doc);

1 0

Re: [xwiki-devs] [xwiki-notifications] r8181 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki
by Vincent Massol 04 Mar '08

04 Mar '08

On Mar 3, 2008, at 9:57 PM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-03-03 21:57:43 +0100 (Mon, 03 Mar 2008) > New Revision: 8181 > > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java > Log: > XWIKI-2170: Allow inactive users to see specific pages What's an inactive user? I think the code below would benefit from some comment and from a separate method, like boolean checkAccessForInactiveUsers() Do we have tests to prove this works? :) Since this seems to be a new feature, I think we really need some tests. Thanks -Vincent > Done. > Patch submitted by David Ward, applied with minor changes. > > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/XWiki.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-03-03 20:01:33 UTC (rev 8180) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-03-03 20:57:43 UTC (rev 8181) > @@ -4209,13 +4209,26 @@ > null, > args); > } else if (checkActive(context) == 0) { > - Object[] args = {context.getUser()}; > - setPhonyDocument(docName, context, vcontext); > - throw new > XWikiException(XWikiException.MODULE_XWIKI_USER, > - XWikiException.ERROR_XWIKI_USER_INACTIVE, > - "User {0} account is inactive", > - null, > - args); > + boolean allow = false; > + String allowed = > Param("xwiki.inactiveuser.allowedpages", ""); > + if (context.getAction().equals("view") && ! > allowed.equals("")) { > + String[] allowedList = StringUtils.split(allowed, > " ,"); > + for (int i=0; i < allowedList.length; i++) { > + if (allowedList[i].equals(doc.getFullName())) { > + allow = true; > + break; > + } > + } > + } > + if (!allow) { > + Object[] args = {context.getUser()}; > + setPhonyDocument(docName, context, vcontext); > + throw new > XWikiException(XWikiException.MODULE_XWIKI_USER, > + XWikiException.ERROR_XWIKI_USER_INACTIVE, > + "User {0} account is inactive", > + null, > + args); > + } > } > > context.put("doc", doc); > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications

1 0

Re: [xwiki-devs] Building Xwiki core (Kamna Jain)
by sachin mittal 04 Mar '08

04 Mar '08

Hi, Can you paste the console output. You can add the maven bin directory to the path variable so that you dont have to type the full path to mvn.bat every time you run the mvn scripts. Also what do you get when you type mvn -version in the command prompt. Thanks Sachin > ---------------------------------------------------------------------- > > Message: 1 > Date: Mon, 3 Mar 2008 15:32:30 -0600 > From: "Kamna Jain" <kammy.scorpi(a)gmail.com> > Subject: Re: [xwiki-devs] Building Xwiki core > To: devs(a)xwiki.org > Message-ID: > <fb681d280803031332y756f2f66g72f65d3b687ca66(a)mail.gmail.com> > Content-Type: text/plain; charset="iso-8859-1" > > Yes, > I am setting the JAVA_HOME variable with DOS prompt > and after I set it, I log of and then it is available in the list of env. > variables after I log back in. > But, when I try to run mvn install, it still gives me the same error. > > Also, although, I set the M2_HOMe variable, I am not able to use mvn > command > without its location! (I have to write the full path of the mvn.bat file > and > then say install after a space) > I dont know what I am doing wrong. > > Thanks for your replies. >

1 0

Re: [xwiki-devs] Building Xwiki core
by Kamna Jain 03 Mar '08

03 Mar '08

Yes, I am setting the JAVA_HOME variable with DOS prompt and after I set it, I log of and then it is available in the list of env. variables after I log back in. But, when I try to run mvn install, it still gives me the same error. Also, although, I set the M2_HOMe variable, I am not able to use mvn command without its location! (I have to write the full path of the mvn.bat file and then say install after a space) I dont know what I am doing wrong. Thanks for your replies. On 3/3/08, devs-request(a)xwiki.org <devs-request(a)xwiki.org> wrote: > > Send devs mailing list submissions to > devs(a)xwiki.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.xwiki.org/mailman/listinfo/devs > or, via email, send a message with subject or body 'help' to > devs-request(a)xwiki.org > > You can reach the person managing the list at > devs-owner(a)xwiki.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of devs digest..." > > > Today's Topics: > > 1. Re: Building Xwiki core (Asiri Rathnayake) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Tue, 4 Mar 2008 01:43:58 +0530 > From: "Asiri Rathnayake" <asiri.rathnayake(a)gmail.com> > Subject: Re: [xwiki-devs] Building Xwiki core > To: "XWiki Developers" <devs(a)xwiki.org> > Message-ID: > <9fd36c290803031213r60305c48qbc2c0e5996b402d1(a)mail.gmail.com> > Content-Type: text/plain; charset="iso-8859-1" > > Hi, > > Did you check whether JAVA_HOME is available in dos prompt as well ? > Perhaps > you should try "set JAVA_HOME=C:\abc\Java\jdk1.5.0_14" prior to running > "mvn > install" ? > > - Asiri > > On Tue, Mar 4, 2008 at 1:16 AM, Kamna Jain <kammy.scorpi(a)gmail.com> wrote: > > > Hello, > > > > I am trying to learn how to build XWiki from the source. > > > > I checked out the source code in Eclipse 3.3 using Sunclipse and then I > > created a Java Project out of the XWiki Core/src folder. > > Now, I am trying to follow directions from the links - > > http://dev.xwiki.org/xwiki/bin/view/Community/Building > > I downloaded maven-2.1-SNAPSHOT and create dthe .m2/settings.xml. > > I also created M2_HOME varibale and set the PATH variable with M2_HOME. > > Set the JAVA_HOME to the jdk installed on my system. > > > > But, when I try "mvn install" from the directory where I have the > > XWiki/src checked out (Eclipse workspace), it says that JAVA_HOME is not > set > > and gives me the following error: > > > > ERROR: JAVA_HOME not found in your environment. > > Please set the JAVA_HOME variable in your environment to match the > > location of your Java installation > > > > I have JAVA_HOME set and it shows up in the list of env. variables in my > > system like this: > > > > JAVA_HOME = C:\abc\Java\jdk1.5.0_14 > > PATH = C:\WINDOWS;C:\WINDOWS\System32;C:\Program > > Files\Subversion\bin;C:\Program Files\TortoiseSVN\bin;C:\Program > Files\Quest > > Software\PuTTY\;C:\Program Files\QuickTime\QTSystem\;C:\Program > Files\Quest > > Software\PuTTY\;%JAVA_HOME%\bin;%M2_HOME%\bin > > > > Could you please tell me what I am doing wrong and what I should change > to > > get this right! > > > > Also, am I on the irght path when I I say I am trying to buildthe src of > > XWiki -core? and nothing else! As an eclipse project, it is all compiled > and > > does not show errors implying that it has all the files that it needs > for it > > to complie. > > > > > > Thanks > > > > > > > > > > > > > > On 3/3/08, devs-request(a)xwiki.org <devs-request(a)xwiki.org> wrote: > > > > > > Send devs mailing list submissions to > > > devs(a)xwiki.org > > > > > > To subscribe or unsubscribe via the World Wide Web, visit > > > http://lists.xwiki.org/mailman/listinfo/devs > > > or, via email, send a message with subject or body 'help' to > > > devs-request(a)xwiki.org > > > > > > You can reach the person managing the list at > > > devs-owner(a)xwiki.org > > > > > > When replying, please edit your Subject line so it is more specific > > > than "Re: Contents of devs digest..." > > > > > > > > > Today's Topics: > > > > > > 1. Re: Profiling: Why do attachments require so much memory > > > (Sergiu Dumitriu) > > > 2. [VOTE] Change the attachment archive storage (Sergiu Dumitriu) > > > 3. Re: [VOTE] Change the attachment archive storage (Vincent Massol) > > > 4. Re: [VOTE] Change the attachment archive storage (Sergiu > Dumitriu) > > > 5. [Proposal] XE 1.3 final release date (Vincent Massol) > > > 6. Re: Xwiki Enterprise 1.3 RC1 release date? (Vincent Massol) > > > 7. Re: About GSoC 2008 (Asiri Rathnayake) > > > 8. Re: Xwiki Enterprise 1.3 RC1 release date? (Sergiu Dumitriu) > > > > > > > > > ---------------------------------------------------------------------- > > > > > > Message: 1 > > > Date: Mon, 03 Mar 2008 17:28:21 +0100 > > > From: Sergiu Dumitriu <sergiu(a)xwiki.com> > > > Subject: Re: [xwiki-devs] Profiling: Why do attachments require so > > > much memory > > > To: XWiki Developers <devs(a)xwiki.org> > > > Message-ID: <47CC2725.40707(a)xwiki.com> > > > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > > > > > Vincent Massol wrote: > > > > Nice work Sergiu. We should transform this into a jira issue to not > > > > forget it. > > > > > > > > > > We should vote for it first. > > > > > > > One other idea: store attachments on the file system and not in the > > > DB. > > > > > > > > Thanks > > > > -Vincent > > > > > > > > On Feb 27, 2008, at 3:48 PM, Sergiu Dumitriu wrote: > > > > > > > >> Hi devs, > > > >> > > > >> Last night I checked what happens when uploading a file, and why > does > > > >> that action require huge amounts of memory. > > > >> > > > >> So, whenever uploading a file, there are several places where the > > > file > > > >> content is loaded into memory: > > > >> - as an XWikiAttachment as byte[] ~= filesize > > > >> - as an XWikiAttachmentArchive as Base64 encoded string ~= > > > >> 2*4*filesize > > > >> - as hibernate tokens that are sent to the database, clones of the > > > >> XWikiAttachment and XWikiAttachmentArchive data ~= 9*filesize > > > >> - as Cached attachments and attachment archive, clones of the same > 2 > > > >> objects ~= 9*filesize > > > >> > > > >> Total: ~27*filesize bytes in memory. > > > >> > > > >> So, out of a 10M file, we get at least 270M of needed memory. > > > >> > > > >> Worse, if this is not the first version of the attachment, then the > > > >> complete attachment history is loaded in memory, so add another > > > >> 24*versionsize*versions of memory needed during upload. > > > >> > > > >> After the upload is done, most of these are cleared, only the > cached > > > >> objects will remain in memory. > > > >> > > > >> However, a problem still remains with the cache. It is a LRU cache > > > >> with > > > >> a fixed capacity, so even if the memory is full, the cached > > > >> attachments > > > >> will not be released. > > > >> > > > >> Things we can improve: > > > >> - Make the cache use References. This will allow cached attachments > > > to > > > >> be removed from memory when there's a need for more memory > > > >> - Do a better attachment archive system. I'm not sure it is a good > > > >> idea > > > >> to have diff-based versioning of attachments. In theory, it saves > > > >> space > > > >> when versions are much alike, but it does not really work in > practice > > > >> because it does a line-diff, and a base64 encoded string does not > > > have > > > >> newlines. What's more, the space gain would be efficient when there > > > >> are > > > >> many versions, as one version alone takes 4 times more space than a > > > >> binary dump of the content. > > > >> > > > >> Suppose we switch to a "one version per table row" for attachment > > > >> history, with direct binary dump, then the memory needed for > > > uploading > > > >> would be 6*filesize, which is much less. > > > > > > > > > -- > > > Sergiu Dumitriu > > > http://purl.org/net/sergiu/ > > > > > > > > > ------------------------------ > > > > > > Message: 2 > > > Date: Mon, 03 Mar 2008 17:34:07 +0100 > > > From: Sergiu Dumitriu <sergiu(a)xwiki.com> > > > Subject: [xwiki-devs] [VOTE] Change the attachment archive storage > > > To: XWiki Developers <devs(a)xwiki.org> > > > Message-ID: <47CC287F.9090609(a)xwiki.com> > > > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > > > > > Hi devs, > > > > > > As detailed in another mail > > > (http://lists.xwiki.org/pipermail/devs/2008-February/005344.html) the > > > current attachment archive mechanism is very inefficient. We should > > > write a new one, which stores attachment versions as plain binary > data, > > > and see if the current core is pluggable enough to allow the old > > > mechanism to be preserved as a plugin, and possibly define other > storage > > > mechanisms, like a filesystem based one. > > > > > > Artem, do you think you can help, as this is something related to what > > > you've been working on? > > > -- > > > Sergiu Dumitriu > > > http://purl.org/net/sergiu/ > > > > > > > > > ------------------------------ > > > > > > Message: 3 > > > Date: Mon, 3 Mar 2008 17:40:39 +0100 > > > From: Vincent Massol <vincent(a)massol.net> > > > Subject: Re: [xwiki-devs] [VOTE] Change the attachment archive storage > > > To: XWiki Developers <devs(a)xwiki.org> > > > Message-ID: <D5354D29-6FB9-41CB-A450-C77DE4E9BB54(a)massol.net> > > > Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes > > > > > > > > > On Mar 3, 2008, at 5:34 PM, Sergiu Dumitriu wrote: > > > > > > > Hi devs, > > > > > > > > As detailed in another mail > > > > (http://lists.xwiki.org/pipermail/devs/2008-February/005344.html) > the > > > > current attachment archive mechanism is very inefficient. We should > > > > write a new one, which stores attachment versions as plain binary > > > > data, > > > > and see if the current core is pluggable enough to allow the old > > > > mechanism to be preserved as a plugin, and possibly define other > > > > storage > > > > mechanisms, like a filesystem based one. > > > > > > > > Artem, do you think you can help, as this is something related to > what > > > > you've been working on? > > > > > > My only worry is that last time we changed the database format we > > > spent several months stabilizing it... since there were lots of > > > problems. I'm not even sure we've finished stabilizing it fully... > > > > > > So is there any chance that this would be simpler? :) > > > > > > Thanks > > > -Vincent > > > > > > > > > > > > ------------------------------ > > > > > > Message: 4 > > > Date: Mon, 03 Mar 2008 18:00:12 +0100 > > > From: Sergiu Dumitriu <sergiu(a)xwiki.com> > > > Subject: Re: [xwiki-devs] [VOTE] Change the attachment archive storage > > > To: XWiki Developers <devs(a)xwiki.org> > > > Message-ID: <47CC2E9C.8070404(a)xwiki.com> > > > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > > > > > Vincent Massol wrote: > > > > On Mar 3, 2008, at 5:34 PM, Sergiu Dumitriu wrote: > > > > > > > >> Hi devs, > > > >> > > > >> As detailed in another mail > > > >> (http://lists.xwiki.org/pipermail/devs/2008-February/005344.html) > > > the > > > >> current attachment archive mechanism is very inefficient. We should > > > >> write a new one, which stores attachment versions as plain binary > > > >> data, > > > >> and see if the current core is pluggable enough to allow the old > > > >> mechanism to be preserved as a plugin, and possibly define other > > > >> storage > > > >> mechanisms, like a filesystem based one. > > > >> > > > >> Artem, do you think you can help, as this is something related to > > > what > > > >> you've been working on? > > > > > > > > My only worry is that last time we changed the database format we > > > > spent several months stabilizing it... since there were lots of > > > > problems. I'm not even sure we've finished stabilizing it fully... > > > > > > > > So is there any chance that this would be simpler? :) > > > > > > > > Thanks > > > > -Vincent > > > > > > > > > > It should be simpler, as attachments are just binary blobs, while the > > > XML history is much too fragile. > > > -- > > > Sergiu Dumitriu > > > http://purl.org/net/sergiu/ > > > > > > > > > ------------------------------ > > > > > > Message: 5 > > > Date: Mon, 3 Mar 2008 18:18:18 +0100 > > > From: Vincent Massol <vincent(a)massol.net> > > > Subject: [xwiki-devs] [Proposal] XE 1.3 final release date > > > To: XWiki Developers <devs(a)xwiki.org> > > > Message-ID: <FE2B2F15-5128-47CC-90B7-CAF96398BADE(a)massol.net> > > > Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes > > > > > > Hi, > > > > > > I'm proposing to revise the 1.3 Final release date to this Friday 7th > > > of March 2007. > > > > > > We've already fixed the major issues raised in 1.3RC1 but I think we > > > need a few days to let people report any issues they might have had > > > with 1.3RC1. > > > > > > Let me know what you think and especially if you don't agree. I'm > > > proposing to do the release. > > > > > > Thanks > > > -Vincent > > > > > > > > > > > > ------------------------------ > > > > > > Message: 6 > > > Date: Mon, 3 Mar 2008 18:23:39 +0100 > > > From: Vincent Massol <vincent(a)massol.net> > > > Subject: Re: [xwiki-devs] Xwiki Enterprise 1.3 RC1 release date? > > > To: XWiki Developers <devs(a)xwiki.org> > > > Message-ID: <161441E7-DC86-48ED-A91A-A8F143A2FC4B(a)massol.net> > > > Content-Type: text/plain; charset="us-ascii" > > > > > > > > > On Feb 27, 2008, at 3:17 PM, Everitt, Glenn wrote: > > > > > > > Is the plan to provide a xwiki-enterprise-web1-1.3-rc1.war file on > > > > the Xwiki Download page? When do you think this would be > > > > available? Would it be better to pull it directly from svn? If I > > > > get it from svn how is the RC1 release marked? > > > > > > > It's been released a few days ago... > > > > I noticed that you were looking at using GWT Html editor. Doesn't > > > > GWT Html editor just wrap the FCKEditor? What is the advantage of > > > > using GWT Html Editor instead of just using the FCKEditor? > > > > > > > I have no idea. Anyone knows? > > > > > > Thanks > > > -Vincent > > > > > >

2 1

[xwiki-devs] Building Xwiki core
by Kamna Jain 03 Mar '08

03 Mar '08

Hello, I am trying to learn how to build XWiki from the source. I checked out the source code in Eclipse 3.3 using Sunclipse and then I created a Java Project out of the XWiki Core/src folder. Now, I am trying to follow directions from the links - http://dev.xwiki.org/xwiki/bin/view/Community/Building I downloaded maven-2.1-SNAPSHOT and create dthe .m2/settings.xml. I also created M2_HOME varibale and set the PATH variable with M2_HOME. Set the JAVA_HOME to the jdk installed on my system. But, when I try "mvn install" from the directory where I have the XWiki/src checked out (Eclipse workspace), it says that JAVA_HOME is not set and gives me the following error: ERROR: JAVA_HOME not found in your environment. Please set the JAVA_HOME variable in your environment to match the location of your Java installation I have JAVA_HOME set and it shows up in the list of env. variables in my system like this: JAVA_HOME = C:\abc\Java\jdk1.5.0_14 PATH = C:\WINDOWS;C:\WINDOWS\System32;C:\Program Files\Subversion\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Quest Software\PuTTY\;C:\Program Files\QuickTime\QTSystem\;C:\Program Files\Quest Software\PuTTY\;%JAVA_HOME%\bin;%M2_HOME%\bin Could you please tell me what I am doing wrong and what I should change to get this right! Also, am I on the irght path when I I say I am trying to buildthe src of XWiki -core? and nothing else! As an eclipse project, it is all compiled and does not show errors implying that it has all the files that it needs for it to complie. Thanks On 3/3/08, devs-request(a)xwiki.org <devs-request(a)xwiki.org> wrote: > > Send devs mailing list submissions to > devs(a)xwiki.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.xwiki.org/mailman/listinfo/devs > or, via email, send a message with subject or body 'help' to > devs-request(a)xwiki.org > > You can reach the person managing the list at > devs-owner(a)xwiki.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of devs digest..." > > > Today's Topics: > > 1. Re: Profiling: Why do attachments require so much memory > (Sergiu Dumitriu) > 2. [VOTE] Change the attachment archive storage (Sergiu Dumitriu) > 3. Re: [VOTE] Change the attachment archive storage (Vincent Massol) > 4. Re: [VOTE] Change the attachment archive storage (Sergiu Dumitriu) > 5. [Proposal] XE 1.3 final release date (Vincent Massol) > 6. Re: Xwiki Enterprise 1.3 RC1 release date? (Vincent Massol) > 7. Re: About GSoC 2008 (Asiri Rathnayake) > 8. Re: Xwiki Enterprise 1.3 RC1 release date? (Sergiu Dumitriu) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Mon, 03 Mar 2008 17:28:21 +0100 > From: Sergiu Dumitriu <sergiu(a)xwiki.com> > Subject: Re: [xwiki-devs] Profiling: Why do attachments require so > much memory > To: XWiki Developers <devs(a)xwiki.org> > Message-ID: <47CC2725.40707(a)xwiki.com> > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > Vincent Massol wrote: > > Nice work Sergiu. We should transform this into a jira issue to not > > forget it. > > > > We should vote for it first. > > > One other idea: store attachments on the file system and not in the DB. > > > > Thanks > > -Vincent > > > > On Feb 27, 2008, at 3:48 PM, Sergiu Dumitriu wrote: > > > >> Hi devs, > >> > >> Last night I checked what happens when uploading a file, and why does > >> that action require huge amounts of memory. > >> > >> So, whenever uploading a file, there are several places where the file > >> content is loaded into memory: > >> - as an XWikiAttachment as byte[] ~= filesize > >> - as an XWikiAttachmentArchive as Base64 encoded string ~= > >> 2*4*filesize > >> - as hibernate tokens that are sent to the database, clones of the > >> XWikiAttachment and XWikiAttachmentArchive data ~= 9*filesize > >> - as Cached attachments and attachment archive, clones of the same 2 > >> objects ~= 9*filesize > >> > >> Total: ~27*filesize bytes in memory. > >> > >> So, out of a 10M file, we get at least 270M of needed memory. > >> > >> Worse, if this is not the first version of the attachment, then the > >> complete attachment history is loaded in memory, so add another > >> 24*versionsize*versions of memory needed during upload. > >> > >> After the upload is done, most of these are cleared, only the cached > >> objects will remain in memory. > >> > >> However, a problem still remains with the cache. It is a LRU cache > >> with > >> a fixed capacity, so even if the memory is full, the cached > >> attachments > >> will not be released. > >> > >> Things we can improve: > >> - Make the cache use References. This will allow cached attachments to > >> be removed from memory when there's a need for more memory > >> - Do a better attachment archive system. I'm not sure it is a good > >> idea > >> to have diff-based versioning of attachments. In theory, it saves > >> space > >> when versions are much alike, but it does not really work in practice > >> because it does a line-diff, and a base64 encoded string does not have > >> newlines. What's more, the space gain would be efficient when there > >> are > >> many versions, as one version alone takes 4 times more space than a > >> binary dump of the content. > >> > >> Suppose we switch to a "one version per table row" for attachment > >> history, with direct binary dump, then the memory needed for uploading > >> would be 6*filesize, which is much less. > > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > > > ------------------------------ > > Message: 2 > Date: Mon, 03 Mar 2008 17:34:07 +0100 > From: Sergiu Dumitriu <sergiu(a)xwiki.com> > Subject: [xwiki-devs] [VOTE] Change the attachment archive storage > To: XWiki Developers <devs(a)xwiki.org> > Message-ID: <47CC287F.9090609(a)xwiki.com> > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > Hi devs, > > As detailed in another mail > (http://lists.xwiki.org/pipermail/devs/2008-February/005344.html) the > current attachment archive mechanism is very inefficient. We should > write a new one, which stores attachment versions as plain binary data, > and see if the current core is pluggable enough to allow the old > mechanism to be preserved as a plugin, and possibly define other storage > mechanisms, like a filesystem based one. > > Artem, do you think you can help, as this is something related to what > you've been working on? > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > > > ------------------------------ > > Message: 3 > Date: Mon, 3 Mar 2008 17:40:39 +0100 > From: Vincent Massol <vincent(a)massol.net> > Subject: Re: [xwiki-devs] [VOTE] Change the attachment archive storage > To: XWiki Developers <devs(a)xwiki.org> > Message-ID: <D5354D29-6FB9-41CB-A450-C77DE4E9BB54(a)massol.net> > Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes > > > On Mar 3, 2008, at 5:34 PM, Sergiu Dumitriu wrote: > > > Hi devs, > > > > As detailed in another mail > > (http://lists.xwiki.org/pipermail/devs/2008-February/005344.html) the > > current attachment archive mechanism is very inefficient. We should > > write a new one, which stores attachment versions as plain binary > > data, > > and see if the current core is pluggable enough to allow the old > > mechanism to be preserved as a plugin, and possibly define other > > storage > > mechanisms, like a filesystem based one. > > > > Artem, do you think you can help, as this is something related to what > > you've been working on? > > My only worry is that last time we changed the database format we > spent several months stabilizing it... since there were lots of > problems. I'm not even sure we've finished stabilizing it fully... > > So is there any chance that this would be simpler? :) > > Thanks > -Vincent > > > > ------------------------------ > > Message: 4 > Date: Mon, 03 Mar 2008 18:00:12 +0100 > From: Sergiu Dumitriu <sergiu(a)xwiki.com> > Subject: Re: [xwiki-devs] [VOTE] Change the attachment archive storage > To: XWiki Developers <devs(a)xwiki.org> > Message-ID: <47CC2E9C.8070404(a)xwiki.com> > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > Vincent Massol wrote: > > On Mar 3, 2008, at 5:34 PM, Sergiu Dumitriu wrote: > > > >> Hi devs, > >> > >> As detailed in another mail > >> (http://lists.xwiki.org/pipermail/devs/2008-February/005344.html) the > >> current attachment archive mechanism is very inefficient. We should > >> write a new one, which stores attachment versions as plain binary > >> data, > >> and see if the current core is pluggable enough to allow the old > >> mechanism to be preserved as a plugin, and possibly define other > >> storage > >> mechanisms, like a filesystem based one. > >> > >> Artem, do you think you can help, as this is something related to what > >> you've been working on? > > > > My only worry is that last time we changed the database format we > > spent several months stabilizing it... since there were lots of > > problems. I'm not even sure we've finished stabilizing it fully... > > > > So is there any chance that this would be simpler? :) > > > > Thanks > > -Vincent > > > > It should be simpler, as attachments are just binary blobs, while the > XML history is much too fragile. > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > > > ------------------------------ > > Message: 5 > Date: Mon, 3 Mar 2008 18:18:18 +0100 > From: Vincent Massol <vincent(a)massol.net> > Subject: [xwiki-devs] [Proposal] XE 1.3 final release date > To: XWiki Developers <devs(a)xwiki.org> > Message-ID: <FE2B2F15-5128-47CC-90B7-CAF96398BADE(a)massol.net> > Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes > > Hi, > > I'm proposing to revise the 1.3 Final release date to this Friday 7th > of March 2007. > > We've already fixed the major issues raised in 1.3RC1 but I think we > need a few days to let people report any issues they might have had > with 1.3RC1. > > Let me know what you think and especially if you don't agree. I'm > proposing to do the release. > > Thanks > -Vincent > > > > ------------------------------ > > Message: 6 > Date: Mon, 3 Mar 2008 18:23:39 +0100 > From: Vincent Massol <vincent(a)massol.net> > Subject: Re: [xwiki-devs] Xwiki Enterprise 1.3 RC1 release date? > To: XWiki Developers <devs(a)xwiki.org> > Message-ID: <161441E7-DC86-48ED-A91A-A8F143A2FC4B(a)massol.net> > Content-Type: text/plain; charset="us-ascii" > > > On Feb 27, 2008, at 3:17 PM, Everitt, Glenn wrote: > > > Is the plan to provide a xwiki-enterprise-web1-1.3-rc1.war file on > > the Xwiki Download page? When do you think this would be > > available? Would it be better to pull it directly from svn? If I > > get it from svn how is the RC1 release marked? > > > It's been released a few days ago... > > I noticed that you were looking at using GWT Html editor. Doesn't > > GWT Html editor just wrap the FCKEditor? What is the advantage of > > using GWT Html Editor instead of just using the FCKEditor? > > > I have no idea. Anyone knows? > > Thanks > -Vincent > >

3 2

[xwiki-devs] [Proposal] XE 1.3 final release date
by Vincent Massol 03 Mar '08

03 Mar '08

Hi, I'm proposing to revise the 1.3 Final release date to this Friday 7th of March 2007. We've already fixed the major issues raised in 1.3RC1 but I think we need a few days to let people report any issues they might have had with 1.3RC1. Let me know what you think and especially if you don't agree. I'm proposing to do the release. Thanks -Vincent

4 3

[xwiki-devs] Xwiki Enterprise 1.3 RC1 release date?
by Everitt, Glenn 03 Mar '08

03 Mar '08

Is the plan to provide a xwiki-enterprise-web1-1.3-rc1.war file on the Xwiki Download page? When do you think this would be available? Would it be better to pull it directly from svn? If I get it from svn how is the RC1 release marked? I noticed that you were looking at using GWT Html editor. Doesn't GWT Html editor just wrap the FCKEditor? What is the advantage of using GWT Html Editor instead of just using the FCKEditor? Thanks Glenn Everitt The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please notify us immediately and then destroy it.

3 2

[xwiki-devs] [idea] Velocity uberspector + annotations + deprecated code
by Sergiu Dumitriu 03 Mar '08

03 Mar '08

Hi, Since we decided to switch to Java 1.5, I found a nice use for annotations. We can detect usage of deprecated APIs in java, but it is hard to do in velocity. One way we can accomplish this is by writing our own velocity uberspector, that checks if a method call is deprecated or not, and logs the calls to deprecated methods. This will allow us to easily spot deprecated code in our templates and fix them. The drawback is that it could slow things down a bit. The advantage is that as long as we properly use annotations, any deprecated method used will be listed in the log. -- Sergiu Dumitriu http://purl.org/net/sergiu/

2 2

[xwiki-devs] XWiki - J2EE best pattern
by Iwan S 03 Mar '08

03 Mar '08

Hi developers, Do you have any "best pattern" that can be shared for XWiki integration to J2EE platform? And where can i found any comprehensive documentation for this? Thanks & regards, - iwan _________________________________________________________________ Get your free suite of Windows Live services today! http://www.get.live.com/wl/all

2 1

[Proposal] Internationalizing XWiki Applications
by Vincent Massol 03 Mar '08

03 Mar '08

Hi, Here's my proposal for internationalizing XWiki apps. The idea is to propose several solutions for XWiki apps writers: * Use case 1: I have lots of text on my page - solution: use XWiki's mechanism for translating page by creating several editions of the page in the different languages * Use case 2: I want translation resources for my application only and I'd like to share resources between pages - solution: use: $msg("mykey", "MySpace.MyTranslationDocForThisApplication") - MySpace.MyTranslationDocForThisApplication is a standard document to which a XWiki.PropertiesClass object is attached - It'll search first in that doc's PropertiesClass and if not found in XWiki's registered document bundles and if not there in XWiki's static resource bundle files * Use case 3: I want translation resources only for a given page - solution: use: $msg("mykey", $doc) - You'll need to have attached a PropertieClass object to the page where $msg is used - It'll search first in that object and if not found in XWiki's registered document bundles and if not there in XWiki's static resource bundle files * Use case 4: I want to have a global translation resources for all my apps in the wiki - solution: use: $msg("mykey") - You'll need to have created ad registered resource bundle documents in the Wiki preferences - It'll search first in XWiki's registered document bundles and if not there in XWiki's static resource bundle files Implementation details: * Add XWikiMessageTool.get(String, String) API * Add XWiki.PropertiesClass class in XE in the Administration Application + a class sheet for presenting the properties nicely WDYT? Thanks -Vincent

5 8