Hello all,
FYI I've transfered the xwiki-social-login from my account to
xwiki-contrib on github.
Old references should still work as I've cloned it in my account.
Jerome
Hi devs,
I've installed the UI of a wiki through DW and I've noticed that the Sandbox.WebHome page had 2 revisions instead of the 1 revision I was expecting.
The first revision has a comment that says "Import: add attachment" and the second rev has a comment of "Import: final save".
However, if I skip the DW and import the XAR, I'll get only 1 revision AFAIK.
Is this discrepancy normal? Do we want it?
Thanks
-Vincent
Hi devs,
Similar to commons and rendering, we now have a CI job at http://ci.xwiki.org/view/Platform/job/xwiki-platform%20Quality%20Checks that runs every night and that checks if TPC thresholds are ok. If not a failure email is sent to the list and whoever caused the failure is supposed to add more tests to go back to the TCP level defined in the pom.xml of that module.
This is the last step of http://markmail.org/thread/j5yuaxixbyvytfr3
Let's hope we can make this work and keep increasing the xwiki project's quality as a consequence! I'm sure we'll find some issues but they'll be occasions to discuss quality and testability of our code :)
Thanks
-Vincent
Hi devs,
A missing peace of Extension Manager UI is the fact that the log
associated to a task is not translatable right now. So I'm working on
making easy to translation log in general since that's actually what
EM is displaying: just plain standard slf4j log (see
http://jira.xwiki.org/browse/XCOMMONS-304).
= Possibilities =
Here are several possibilities:
1) translate the message before giving it to the log event, so it's up
to the log producer to translation its log based on the context
language
2) provide an additional translation key along with what will now be
the default message when logging
3) generate a translation key based on the default message
Here is what I think of those:
1) is a bit better for the user than the current situation but not
that much, instead of behind stuck with english he will be stuck with
another language with stored logs. It also make anyone that produce
log depends on many things to actually translate that message so it's
a -1 for me
3) sounds very fragile
= The actual proposal =
Here is a detailed proposal for 2):
The idea would be to pass the translation key using slf4j Marker API.
We introduce a TranslationMarker which implements Marker and is passed
with the log when you want to associated a translation key to a log.
Here is an example:
producer (for example the install job):
""
logger.error(TranslationMarker.getMarker("some.translation.key"), "A
default error message generally in english with a [{}]", "parameter",
exception)
""
displayer (for example the Extension Manager UI, should be a logging
module UI element btw reused by Extension Manager ;)):
""
#set($translationKey = $logEvent.marker.translationKey)
""
WDYT ?
--
Thomas Mortagne
Hi devs,
I've been working in the 4.3 Roadmap for a new skin proposal. You can see
it at
http://incubator.myxwiki.org/xwiki/bin/view/Improvements/Skin4x
I recommend looking at the "Annotations Overview" gallery in order to see
the different elements of the skin and some explanations.
I've made also separate pages for different components of the skin. For
example, you can see more information about how the menus work at
http://incubator.myxwiki.org/xwiki/bin/view/Improvements/Skin4xMenus
For each component you can also see how the elements scale and see the
responsive layout.
For the record, the proposal is made by using Bootstrap (
http://twitter.github.com/bootstrap/).
Thanks,
Caty
Working on l10n change to custom mapping showed up an issue with the l10n
history.
We have a huge history table with 2,3M lines (as well as an activity
stream) and we use the history table for extracting contributor statistics.
However looking at it more closely shows that the source of most data in
the history table is useless.
See here a grouping by dates showing that localisation of already close to
2M lines in 6 month in 2012.
| 201201 | 318346 |
| 201202 | 311403 |
| 201203 | 728703 |
| 201204 | 271657 |
| 201205 | 296384 |
| 201206 | 120463 |
Here is an example of history for an entry
mysql> select
xwr_author,xwr_version1,xwr_version2,xwr_date,xwr_comment,cast(xwr_isdiff
as unsigned), length(xwr_patch) from xwikircs where xwr_docid=596494851 ;
+-----------------------+--------------+--------------+---------------------+-------------+------------------------------+-------------------+
| xwr_author | xwr_version1 | xwr_version2 | xwr_date
| xwr_comment | cast(xwr_isdiff as unsigned) | length(xwr_patch) |
+-----------------------+--------------+--------------+---------------------+-------------+------------------------------+-------------------+
| XWiki.XWikiTranslator | 1 | 1 | 2010-02-23 11:38:27
| | 1 | 163 |
| XWiki.XWikiTranslator | 2 | 1 | 2010-02-23 11:40:26
| | 1 | 330 |
| XWiki.rbuj | 3 | 1 | 2010-03-04 00:24:24
| | 1 | 189 |
| XWiki.rbuj | 4 | 1 | 2010-03-04 01:02:52
| | 1 | 223 |
| XWiki.rbuj | 5 | 1 | 2010-07-30 01:12:58
| | 0 | 5026 |
| XWiki.XWikiTranslator | 6 | 1 | 2012-01-23 11:40:25
| | 1 | 115 |
| XWiki.XWikiTranslator | 7 | 1 | 2012-01-23 11:58:25
| | 1 | 115 |
| XWiki.XWikiTranslator | 8 | 1 | 2012-01-23 13:31:52
| | 1 | 234 |
| XWiki.XWikiTranslator | 8 | 2 | 2012-01-23 15:36:02
| Prepared | 1 | 115 |
| XWiki.XWikiTranslator | 8 | 3 | 2012-01-24 02:01:12
| Prepared | 0 | 5670 |
| XWiki.XWikiTranslator | 8 | 4 | 2012-01-25 02:04:00
| Prepared | 1 | 115 |
| XWiki.XWikiTranslator | 8 | 5 | 2012-01-26 02:02:29
| Prepared | 1 | 115 |
| XWiki.XWikiTranslator | 8 | 6 | 2012-01-27 02:01:18
| Prepared | 1 | 115 |
| XWiki.XWikiTranslator | 8 | 7 | 2012-02-04 02:01:08
| Prepared | 1 | 115 |
| XWiki.XWikiTranslator | 8 | 8 | 2012-02-07 02:02:03
| Prepared | 0 | 5670 |
| XWiki.XWikiTranslator | 8 | 9 | 2012-02-08 02:01:20
| Prepared | 1 | 115 |
| XWiki.XWikiTranslator | 8 | 10 | 2012-02-14 02:01:07
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 11 | 2012-02-28 02:01:32
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 12 | 2012-03-03 02:01:20
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 13 | 2012-03-14 02:01:50
| Prepared | 0 | 5671 |
| XWiki.XWikiTranslator | 8 | 14 | 2012-03-14 18:23:06
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 15 | 2012-03-14 18:32:38
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 16 | 2012-03-14 18:37:17
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 17 | 2012-03-24 02:01:34
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 18 | 2012-03-26 16:40:35
| Prepared | 0 | 5671 |
| XWiki.XWikiTranslator | 8 | 19 | 2012-03-28 02:01:23
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 20 | 2012-03-29 02:01:45
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 21 | 2012-04-11 02:01:36
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 22 | 2012-04-19 15:20:10
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 24 | 2012-04-29 02:01:45
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 25 | 2012-05-04 18:55:30
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 26 | 2012-05-04 19:02:09
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 27 | 2012-05-10 02:04:36
| Prepared | 1 | 116 |
| XWiki.XWikiTranslator | 8 | 28 | 2012-05-30 02:02:08
| Prepared | 0 | 5671 |
| XWiki.XWikiTranslator | 8 | 29 | 2012-06-07 10:44:28
| Prepared | 0 | 5782 |
+-----------------------+--------------+--------------+---------------------+-------------+------------------------------+-------------------+
http://l10n.xwiki.org/xwiki/bin/view/XE/XEXWikiCoreResources_2107067965_cor…
Most entries are "no changes" and have been cause by the L10NUpdater which
wrongefully saved the document with no changes. I believe this must have
been fixed (by Thomas M.?) mid 2012.
Now the 2M lines impact performance significantly and loads the DB for
nothing (and in the activity stream as well).
I suggest we clean up the history and activity stream. We have 2
possibilities:
For xwikircs:
1/ Clean up only the bad data from XWikiTranslator when there are no
changes:
This is complicated as you need to verify if the change is actually a
change and you cannot do that just with sql queries. It could be very long
2/ Clean up old data from pre-201206 from XWikiTranslator
Simpler if it is safe to delete by date in the DB. After discussion with
sergui this is a bit complicated because you need to make sure you don't
delete the latest full version before the versions you keep. So you would
have to do it by API which will take ages.
3/ Clean up up old data from pre-201206 from all users
This is simpler as you can safely delete from the database everything older
than a certain versions. Cleans-up even more but would loose contributor
statistics unless we store 2012 contributor counts in an alternate table
which would then be regularly updated
In any case we should probably create this intermediary table for
statistics as it would be much faster anyway.
For activitystream:
1/ Clean up old data from XWikiTranslator 201206 or earlier
2/ Clean up old date from everybody 201206 or earlier
What value do we see in the l10n history and actvity stream and which
solutions do the other commiters suggest ?
I would say it's interesting for contributor statistics (counting number of
contribution by translators) but beyond that we can delete the data.
So we would fix that by storing monthly statistics in a table and updating
the latest 2 month through a scheduler job. This means that we can also
delete history over 2 month.
WDYT ?
Ludovic
--
Ludovic Dubost
Founder and CEO
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
Hi devs,
We're very late for the 4.5 release. Here are the dates we planned initially (see http://www.xwiki.org/xwiki/bin/view/Roadmaps/WebHome):
* 4.5M1: 14th of Jan 2013
* 4.5RC1: 21st of Jan 2013
* 4.5 Final: 4th of February 2013
Here are outstanding issues currently marked for 4.5M1:
http://jira.xwiki.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=fixVer…
Since we're late and since there are already interesting changes in 4.5M1 (see RN: http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWiki45M1), I'm proposing to have the following new dates:
* 4.5M1: Monday 28th of Jan
* 4.5RC1: Monday 4th of Feb
* 4.5Final: Monday 11th of Feb
WDYT? (that's one week of delay compared to original plan)
Volunteers are also welcome to act as Release Manager for these releases. Barring that I'll do it but I'm getting a bit tired (I've done the last 4 releases).
Thanks
-Vincent
Hi devs,
I am currently working on XWIKI-8718 (
http://jira.xwiki.org/browse/XWIKI-8718) to improve the reporting of failed
or missing migration directly in the error reported by the browser. To do
so, I keep a cache of the exceptions generated by migrations, and reattach
them to all access failure to a given database. This will really help the
end user, since it is no more necessary to dig the logs to notice a
duplicate key issue in a migration.
However, during a simple initial request to XWiki, a lot of access is done
to the database, and many of them are not fatal (especially in a farm with
a valid main wiki), but reports warnings or errors to stdout. This produce
between 5K (main wiki had failed) to 22K lines (a subwiki has failed).
Most of them are caused while getting a value in preference of user, space
or wiki. And since these are linked together, in a fallback manner, getting
a user preferences cause three error reports and space two.
Currently these errors are logged at WARN level. Since all these are not
fatal, and provide correct fallbacks for the current situation, I would
like to reduce that log level to DEBUG. Doing so will significantly
simplify the logs (around 2K lines), and avoid really repetitive reports,
since each access to a single value of the preferences are reported
individually.
Here is my +1 to reduce to DEBUG, the log level of:
XWiki#getUserPreference(String prefname, XWikiContext context)
XWiki#getSpacePreference(String preference, String space, String
defaultValue, XWikiContext context)
XWiki#getXWikiPreference(String prefname, String fallback_param, String
default_value, XWikiContext context)
WDYT ?
--
Denis Gervalle
SOFTEC sa - CEO
eGuilde sarl - CTO